Merged
Conversation
maksim-tolo
added
review
Team:Core
Contributor
💔 Build Failed |
Contributor
|
retest |
Contributor
💔 Build Failed |
Contributor
|
Hey @maksim-tolo, looks like CI fails because of linting issue in your PR, could you please check? |
Contributor
💚 Build Succeeded |
tests for angular wrappers under i18n engine
Contributor
💚 Build Succeeded |
rhoboat
reviewed
Jul 4, 2018
| jest.resetAllMocks(); | ||
| }); | ||
|
|
||
| it('provides wrapper under i18n translate function', () => { |
There was a problem hiding this comment.
@archanid Filters in general are functions which format the value. And current filter is a wrapper under i18n core engine translate function. In this test case we check that angular abstraction works.
Could you please share your thoughts maybe regarding more suitable label here?
There was a problem hiding this comment.
Thanks for the clarification! The label works.
yankouskia
requested review from
azasypkin,
epixa and
spalger
and removed request for
azasypkin,
epixa and
spalger
Contributor
💚 Build Succeeded |
Contributor
💔 Build Failed |
maryia-lapata
approved these changes
Jul 19, 2018
Contributor
💚 Build Succeeded |
azasypkin
reviewed
Jul 23, 2018
packages/kbn-i18n/src/core/i18n.js
Outdated
|
|
||
| if (newMessages.locale && newMessages.locale !== locale) { | ||
| throw new Error( | ||
| '[I18n] A `locale` in the messages object is different from one provided as second argument.' |
Contributor
There was a problem hiding this comment.
typo: not a native speaker, but something like from the one provided as a second argument sounds a little bit better, up to you 🤷♂️
Contributor
💔 Build Failed |
|
retest |
Contributor
💔 Build Failed |
|
retest |
Contributor
💔 Build Failed |
Contributor
💚 Build Succeeded |
LeanidShutau
pushed a commit
to LeanidShutau/kibana
that referenced
this pull request
Aug 3, 2018
* Add unit-tests for i18n engine * tests for angular wrappers under i18n engine * split to packages in accordance to specific library * split to packages depending on tech and environment * make env modules names consistent * remove intl polyfilling * move laoder to root, i18n folder to core * Add unit-tests for i18n engine * tests for angular wrappers under i18n engine * rebase on split package, injectIntl component * eslint fixes * use method names for checking, test i18n-values in directive * use real html content while testing directive * add test for angular directive without values
LeanidShutau
added a commit
that referenced
this pull request
Aug 3, 2018
* Add unit-tests for i18n engine * tests for angular wrappers under i18n engine * split to packages in accordance to specific library * split to packages depending on tech and environment * make env modules names consistent * remove intl polyfilling * move laoder to root, i18n folder to core * Add unit-tests for i18n engine * tests for angular wrappers under i18n engine * rebase on split package, injectIntl component * eslint fixes * use method names for checking, test i18n-values in directive * use real html content while testing directive * add test for angular directive without values
Contributor
|
6.x/6.5: 1f7c1bc |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#19727
Blocked by #20513