Skip to content

[Lens] Fix styling popover controls#202865

Merged
mbondyra merged 8 commits intoelastic:mainfrom
Ajay-Satish-01:fix-ui
Dec 12, 2024
Merged

[Lens] Fix styling popover controls#202865
mbondyra merged 8 commits intoelastic:mainfrom
Ajay-Satish-01:fix-ui

Conversation

@Ajay-Satish-01
Copy link
Copy Markdown
Contributor

@Ajay-Satish-01 Ajay-Satish-01 commented Dec 4, 2024 •
edited by kibanamachine
Loading

Summary

Fixes styling popover controls alignment. Fixes #202121

Screenshot 2024-12-03 at 5 30 55 PM

Checklist

  • Any text added follows EUI's writing guidelines, uses sentence case text and includes i18n support
  • Documentation was added for features that require explanation or tutorials
  • Unit or functional tests were updated or added to match the most common scenarios
  • If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the docker list
  • This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
  • Flaky Test Runner was used on any tests changed
  • The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

@Ajay-Satish-01 Ajay-Satish-01 requested a review from a team as a code owner December 4, 2024 01:25
@cla-checker-service
Copy link
Copy Markdown

cla-checker-service bot commented Dec 4, 2024 •
edited
Loading

💚 CLA has been signed

@Ajay-Satish-01 Ajay-Satish-01 changed the title [Lens] Fix styling popover controls [Lens] Fix styling popover controls #202121 Dec 4, 2024
@Ajay-Satish-01
Copy link
Copy Markdown
Contributor Author

Ajay-Satish-01 commented Dec 4, 2024

I have raised the PR. Please check and let me know if things are fine.

@mbondyra mbondyra added Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// release_note:skip Skip the PR/issue when compiling release notes Feature:Lens backport:prev-minor labels Dec 5, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 5, 2024

Pinging @elastic/kibana-visualizations (Team:Visualizations)

Ajay-Satish-01 and others added 4 commits December 5, 2024 04:23
@Ajay-Satish-01 @mbondyra
Replace inline css with fullWidth prop
9ac0540 
Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
@Ajay-Satish-01 @mbondyra
Replace inline css with fullWidth prop
5647793 
Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
@mbondyra
Update missing_values_option.tsx
b63c816 
just some whitespaces
@mbondyra
Update missing_values_option.tsx
86668aa
mbondyra
mbondyra approved these changes Dec 5, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@mbondyra mbondyra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🙆🏼‍♀️

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 5, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #15 / MaintenanceWindowsMock hides MaintenanceWindowCallout if the category ID is not supported

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
lens 1.5MB 1.5MB +26.0B

History

@nickofthyme nickofthyme changed the title [Lens] Fix styling popover controls #202121 [Lens] Fix styling popover controls Dec 10, 2024
@mbondyra
Copy link
Copy Markdown
Contributor

mbondyra commented Dec 11, 2024

@elasticmachine merge upstream

@mbondyra
Copy link
Copy Markdown
Contributor

mbondyra commented Dec 11, 2024

run docs-build

@mbondyra
Copy link
Copy Markdown
Contributor

mbondyra commented Dec 11, 2024

buildkite test this

@mbondyra mbondyra merged commit 1f2a670 into elastic:main Dec 12, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 12, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12293243143

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Dec 12, 2024
@Ajay-Satish-01 @mbondyra @elasticmachine
[Lens] Fix styling popover controls (elastic#202865)
96b27e5 
## Summary

Fixes styling popover controls alignment. Fixes elastic#202121

<img width="505" alt="Screenshot 2024-12-03 at 5 30 55 PM"
src="https://github.com/user-attachments/assets/a44c2a85-7bac-497c-8354-acab6e48ba38">

### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit 1f2a670)
@kibanamachine kibanamachine mentioned this pull request Dec 12, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 12, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Dec 12, 2024
Merged
kibanamachine added a commit that referenced this pull request Dec 12, 2024
@kibanamachine @Ajay-Satish-01
[8.x] [Lens] Fix styling popover controls (#202865) (#203972)
3d31144 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Lens] Fix styling popover controls
(#202865)](#202865)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Ajay
Satish","email":"71289526+Ajay-Satish-01@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-12-12T09:13:13Z","message":"[Lens]
Fix styling popover controls (#202865)\n\n## Summary\r\n\r\nFixes
styling popover controls alignment. Fixes #202121\r\n\r\n<img
width=\"505\" alt=\"Screenshot 2024-12-03 at 5 30
55 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a44c2a85-7bac-497c-8354-acab6e48ba38\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"1f2a6701157c2c7a696f58166deb59f028647200","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Visualizations","release_note:skip","Feature:Lens","💝community","v9.0.0","backport:prev-minor"],"title":"[Lens]
Fix styling popover
controls","number":202865,"url":"https://github.com/elastic/kibana/pull/202865","mergeCommit":{"message":"[Lens]
Fix styling popover controls (#202865)\n\n## Summary\r\n\r\nFixes
styling popover controls alignment. Fixes #202121\r\n\r\n<img
width=\"505\" alt=\"Screenshot 2024-12-03 at 5 30
55 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a44c2a85-7bac-497c-8354-acab6e48ba38\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"1f2a6701157c2c7a696f58166deb59f028647200"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202865","number":202865,"mergeCommit":{"message":"[Lens]
Fix styling popover controls (#202865)\n\n## Summary\r\n\r\nFixes
styling popover controls alignment. Fixes #202121\r\n\r\n<img
width=\"505\" alt=\"Screenshot 2024-12-03 at 5 30
55 PM\"\r\nsrc=\"https://github.com/user-attachments/assets/a44c2a85-7bac-497c-8354-acab6e48ba38\">\r\n\r\n\r\n###
Checklist\r\n\r\n- [ ] Any text added follows [EUI's
writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing),
uses\r\nsentence case text and includes
[i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n-
[
]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas
added for features that require explanation or tutorials\r\n- [ ] [Unit
or
functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere
updated or added to match the most common scenarios\r\n- [ ] If a plugin
configuration key changed, check if it needs to be\r\nallowlisted in the
cloud and added to the
[docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n-
[ ] This was checked for breaking HTTP API changes, and any
breaking\r\nchanges have been approved by the breaking-change committee.
The\r\n`release_note:breaking` label should be applied in these
situations.\r\n- [ ] [Flaky
Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1)
was\r\nused on any tests changed\r\n- [ ] The PR description includes
the appropriate Release Notes section,\r\nand the correct
`release_note:*` label is applied per
the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by:
Marta Bondyra
<4283304+mbondyra@users.noreply.github.com>\r\nCo-authored-by: Elastic
Machine
<elasticmachine@users.noreply.github.com>","sha":"1f2a6701157c2c7a696f58166deb59f028647200"}}]}]
BACKPORT-->

Co-authored-by: Ajay Satish <71289526+Ajay-Satish-01@users.noreply.github.com>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@Ajay-Satish-01 @mbondyra
@elasticmachine @CAWilson94
[Lens] Fix styling popover controls (elastic#202865)
a42d992 
## Summary

Fixes styling popover controls alignment. Fixes elastic#202121

<img width="505" alt="Screenshot 2024-12-03 at 5 30 55 PM"
src="https://github.com/user-attachments/assets/a44c2a85-7bac-497c-8354-acab6e48ba38">


### Checklist

- [ ] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] If a plugin configuration key changed, check if it needs to be
allowlisted in the cloud and added to the [docker
list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)
- [ ] This was checked for breaking HTTP API changes, and any breaking
changes have been approved by the breaking-change committee. The
`release_note:breaking` label should be applied in these situations.
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed
- [ ] The PR description includes the appropriate Release Notes section,
and the correct `release_note:*` label is applied per the
[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

---------

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mbondyra mbondyra mbondyra approved these changes

Assignees

No one assigned

Labels

💝community Feature:Lens release_note:skip Skip the PR/issue when compiling release notes Team:Visualizations Team label for Lens, elastic-charts, Graph, legacy editors (TSVB, Visualize, Timelion) t// v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Lens] Styling popover controls are not aligned correctly

4 participants

@Ajay-Satish-01 @elasticmachine @mbondyra @kibanamachine