Skip to content

[8.x] [Unified Data Table] Stop passing data grid density as `key` (#202390) #202563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibanamachine merged 1 commit into from
Dec 2, 2024
Merged

[8.x] [Unified Data Table] Stop passing data grid density as `key` (#202390) #202563

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions packages/kbn-unified-data-table/src/components/data_table.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1155,8 +1155,6 @@ export const UnifiedDataTable = ({
/>
) : (
<EuiDataGridMemoized
// Using this as the `key` is a workaround for https://github.com/elastic/eui/issues/7962. This forces a re-render if the density is changed.
key={dataGridDensity}
id={dataGridId}
aria-describedby={randomId}
aria-labelledby={ariaLabelledBy}
Expand Down
5 changes: 1 addition & 4 deletions test/functional/apps/discover/group2_data_grid3/_data_grid_density.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,17 +52,14 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) {
await dataGrid.changeDensityValue('Normal');

// toggle the popover
// Right now changing the density closes the popover (see packages/kbn-unified-data-table/src/components/data_table.tsx:1144)
// When that workaround is removed we will need to uncomment this next line
// await dataGrid.clickGridSettings();
await dataGrid.clickGridSettings();
await dataGrid.clickGridSettings();
expect(await dataGrid.getCurrentDensityValue()).to.be('Normal');
});

it('should persist the density selection after reloading the page', async () => {
await dataGrid.clickGridSettings();
await dataGrid.changeDensityValue('Expanded');
await dataGrid.clickGridSettings();
expect(await dataGrid.getCurrentDensityValue()).to.be('Expanded');

await browser.refresh();
Expand Down