[8.x] [SIEM Rule Migration] Minor prompt improvements (#201941)#202383
Merged
semd merged 1 commit intoelastic:8.xfrom Nov 30, 2024
Merged
[8.x] [SIEM Rule Migration] Minor prompt improvements (#201941)#202383semd merged 1 commit intoelastic:8.xfrom
semd merged 1 commit intoelastic:8.xfrom
Conversation
## Summary Adding some minor improvements and modifies the format on some of the prompts used in the siem_migration process, a few specifics below: 1. Moved prebuilt rules matching to JSON output parsing, as its less prone for issues on some models. 2. Moved some of the formatting of the prompts to focus on xml-like tags, as it often gives good results on multiple models. Also context that is relevant to perform an action is moved to system, while context related to the question (and to the response) is kept in the human prompt. 3. Moved process_query to ChatPromptTemplate, moved the collection of ResourceContext outside of the prompt because of this. (cherry picked from commit eb87889) # Conflicts: # x-pack/plugins/security_solution/server/lib/siem_migrations/rules/task/agent/nodes/match_prebuilt_rule/match_prebuilt_rule.ts
e40pud
approved these changes
Nov 30, 2024
Contributor
💚 Build Succeeded
Metrics [docs]
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation