[eem] _search sort_by and display_name#202361
Merged
klacabane merged 12 commits intoelastic:mainfrom Dec 2, 2024
Merged
Conversation
klacabane
added
release_note:skip
Contributor
|
Pinging @elastic/obs-entities (Team:obs-entities) |
botelastic
bot
added
the
ci:project-deploy-observability
Contributor
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
miltonhultgren
approved these changes
Dec 2, 2024
Contributor
⏳ Build in-progress
History
cc @klacabane |
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/12127237515 |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Dec 2, 2024
- allow optional `entity_source.display_name` setting.
`entity.display_name` will always be set on the entities, falling back
to `entity.id` if provided field is not set
- allow `sort_by` parameter to `_search` API
- removed the `metadata.` prefix in the query aggregation. metadata will
now be set at the root of the document (eg for metadata `host.name`
entity = `{ entity.id: 'foo', host.name: 'bar' }`
- timestamp_field is now optional
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 697af57)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Dec 2, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[eem] _search sort_by and display_name (#202361)](#202361) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Kevin Lacabane","email":"kevin.lacabane@elastic.co"},"sourceCommit":{"committedDate":"2024-12-02T20:15:57Z","message":"[eem] _search sort_by and display_name (#202361)\n\n- allow optional `entity_source.display_name` setting.\r\n`entity.display_name` will always be set on the entities, falling back\r\nto `entity.id` if provided field is not set\r\n- allow `sort_by` parameter to `_search` API\r\n- removed the `metadata.` prefix in the query aggregation. metadata will\r\nnow be set at the root of the document (eg for metadata `host.name`\r\nentity = `{ entity.id: 'foo', host.name: 'bar' }`\r\n- timestamp_field is now optional\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"697af576d8aae87c53a2f60646b6657be9b914ad","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-entities"],"title":"[eem] _search sort_by and display_name","number":202361,"url":"https://github.com/elastic/kibana/pull/202361","mergeCommit":{"message":"[eem] _search sort_by and display_name (#202361)\n\n- allow optional `entity_source.display_name` setting.\r\n`entity.display_name` will always be set on the entities, falling back\r\nto `entity.id` if provided field is not set\r\n- allow `sort_by` parameter to `_search` API\r\n- removed the `metadata.` prefix in the query aggregation. metadata will\r\nnow be set at the root of the document (eg for metadata `host.name`\r\nentity = `{ entity.id: 'foo', host.name: 'bar' }`\r\n- timestamp_field is now optional\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"697af576d8aae87c53a2f60646b6657be9b914ad"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/202361","number":202361,"mergeCommit":{"message":"[eem] _search sort_by and display_name (#202361)\n\n- allow optional `entity_source.display_name` setting.\r\n`entity.display_name` will always be set on the entities, falling back\r\nto `entity.id` if provided field is not set\r\n- allow `sort_by` parameter to `_search` API\r\n- removed the `metadata.` prefix in the query aggregation. metadata will\r\nnow be set at the root of the document (eg for metadata `host.name`\r\nentity = `{ entity.id: 'foo', host.name: 'bar' }`\r\n- timestamp_field is now optional\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"697af576d8aae87c53a2f60646b6657be9b914ad"}}]}] BACKPORT--> Co-authored-by: Kevin Lacabane <kevin.lacabane@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
- allow optional `entity_source.display_name` setting.
`entity.display_name` will always be set on the entities, falling back
to `entity.id` if provided field is not set
- allow `sort_by` parameter to `_search` API
- removed the `metadata.` prefix in the query aggregation. metadata will
now be set at the root of the document (eg for metadata `host.name`
entity = `{ entity.id: 'foo', host.name: 'bar' }`
- timestamp_field is now optional
---------
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
entity_source.display_namesetting.entity.display_namewill always be set on the entities, falling back toentity.idif provided field is not setsort_byparameter to_searchAPImetadata.prefix in the query aggregation. metadata will now be set at the root of the document (eg for metadatahost.nameentity ={ entity.id: 'foo', host.name: 'bar' }