Skip to content

[Infra] Unskip infra serverless tests #202146

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
crespocarlos merged 3 commits into from
Nov 29, 2024
Merged

[Infra] Unskip infra serverless tests #202146

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
77157e0
Unskip infra serverless tests
crespocarlos Nov 28, 2024
048707d
update codeowners
crespocarlos Nov 29, 2024
a6f1f30
Merge branch 'main' into 191809-unskip-serverless-tests
elasticmachine Nov 29, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1288,6 +1288,7 @@ packages/kbn-monaco/src/esql @elastic/kibana-esql
/x-pack/plugins/observability_solution/infra/server/services @elastic/obs-ux-infra_services-team
/x-pack/plugins/observability_solution/infra/server/usage @elastic/obs-ux-infra_services-team
/x-pack/plugins/observability_solution/infra/server/utils @elastic/obs-ux-infra_services-team
/x-pack/test_serverless/functional/test_suites/observability/infra @elastic/obs-ux-infra_services-team
/x-pack/test/api_integration/services/infraops_source_configuration.ts @elastic/obs-ux-infra_services-team @elastic/obs-ux-logs-team # Assigned per https://github.com/elastic/kibana/pull/34916

## Logs UI code exceptions -> @elastic/obs-ux-logs-team
Expand Down
38 changes: 0 additions & 38 deletions x-pack/test_serverless/functional/test_suites/observability/infra/header_menu.ts
View file
Open in desktop

This file was deleted.

32 changes: 10 additions & 22 deletions x-pack/test_serverless/functional/test_suites/observability/infra/hosts_page.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,28 +40,22 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
(await pageObjects.infraHostsView.isKPIChartsLoaded())
);

// failing feature flag test, see https://github.com/elastic/kibana/issues/191810
describe.skip('Hosts Page', function () {
describe('Hosts Page', function () {
before(async () => {
await Promise.all([
esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs'),
]);
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
await pageObjects.svlCommonPage.loginAsViewer();
await browser.setWindowSize(1600, 1200);

await pageObjects.common.navigateToApp(HOSTS_VIEW_PATH);
await pageObjects.header.waitUntilLoadingHasFinished();

await browser.setWindowSize(1600, 1400);
});

after(async () => {
await Promise.all([
esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs'),
]);
await esArchiver.unload('x-pack/test/functional/es_archives/infra/metrics_and_logs');
});

describe('#Single Host Flyout', () => {
before(async () => {
await pageObjects.common.navigateToApp(HOSTS_VIEW_PATH);
await pageObjects.header.waitUntilLoadingHasFinished();
});

describe('Tabs', () => {
before(async () => {
await pageObjects.timePicker.setAbsoluteRange(
Expand Down Expand Up @@ -100,10 +94,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
it('should show alerts', async () => {
await pageObjects.header.waitUntilLoadingHasFinished();
await pageObjects.assetDetails.overviewAlertsTitleExists();
const CreateRuleButtonExist = await testSubjects.exists(
'infraAssetDetailsCreateAlertsRuleButton'
);
expect(CreateRuleButtonExist).to.be(true);
await pageObjects.assetDetails.overviewOpenAlertsFlyoutExist();
});
});

Expand All @@ -123,7 +114,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
});

it('should show processes title', async () => {
await await testSubjects.existOrFail('infraAssetDetailsTopProcessesTitle');
await testSubjects.existOrFail('infraAssetDetailsTopProcessesTitle');
});
});

Expand Down Expand Up @@ -175,7 +166,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('Metrics Tab', () => {
before(async () => {
await browser.scrollTop();
await pageObjects.infraHostsView.visitMetricsTab();
});

Expand All @@ -191,7 +181,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('Logs Tab', () => {
before(async () => {
await browser.scrollTop();
await pageObjects.infraHostsView.visitLogsTab();
});

Expand All @@ -206,7 +195,6 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {

describe('Alerts Tab', () => {
before(async () => {
await browser.scrollTop();
await pageObjects.infraHostsView.visitAlertTab();
});

Expand Down
1 change: 0 additions & 1 deletion x-pack/test_serverless/functional/test_suites/observability/infra/index.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@ import { FtrProviderContext } from '../../../ftr_provider_context';

export default function ({ loadTestFile }: FtrProviderContext) {
describe('Observability Infra', function () {
loadTestFile(require.resolve('./header_menu'));
loadTestFile(require.resolve('./navigation'));
loadTestFile(require.resolve('./node_details'));
loadTestFile(require.resolve('./hosts_page'));
Expand Down
10 changes: 3 additions & 7 deletions x-pack/test_serverless/functional/test_suites/observability/infra/node_details.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
'svlCommonPage',
]);

// failing feature flag test, see https://github.com/elastic/kibana/issues/191809
describe.skip('Node Details', () => {
describe('Node Details', () => {
describe('#With Asset Details', () => {
before(async () => {
await esArchiver.load('x-pack/test/functional/es_archives/infra/metrics_and_logs');
Expand All @@ -50,7 +49,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
describe('Osquery Tab', () => {
it('should not render in serverless', async () => {
const OsqueryExist = await testSubjects.exists('infraAssetDetailsOsqueryTab');
expect(OsqueryExist).to.be(false);
expect(OsqueryExist).to.be(true);
});
});

Expand All @@ -68,10 +67,7 @@ export default ({ getPageObjects, getService }: FtrProviderContext) => {
it('should show alerts', async () => {
await pageObjects.header.waitUntilLoadingHasFinished();
await pageObjects.assetDetails.overviewAlertsTitleExists();
const CreateRuleButtonExist = await testSubjects.exists(
'infraAssetDetailsCreateAlertsRuleButton'
);
expect(CreateRuleButtonExist).to.be(true);
await pageObjects.assetDetails.overviewOpenAlertsFlyoutExist();
});

[
Expand Down