-
Notifications
You must be signed in to change notification settings - Fork 8.5k
[Discover] Add context awareness telemetry tests for Observability profiles #201310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
davismcphee
merged 9 commits into
elastic:main
from
davismcphee:o11y-profiles-telemetry
Nov 29, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
50f5f66
Add context awareness telemetry tests for Observability profiles
davismcphee 5bc5373
Fix failing tests
davismcphee 69ebd46
Merge branch 'main' into o11y-profiles-telemetry
davismcphee c81afdb
Merge branch 'main' into o11y-profiles-telemetry
davismcphee 67a5954
Add dedicated telemetry config that is skipped in MKI
davismcphee 38b9306
Scope services to just compatible telemetry config
davismcphee 0585a25
Drop kibana_ebt_server
davismcphee 2c5c953
Merge branch 'main' into o11y-profiles-telemetry
davismcphee a71f777
Merge branch 'main' into o11y-profiles-telemetry
davismcphee File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -11,15 +11,17 @@ import { pageObjects } from './page_objects'; | |
| import { services } from './services'; | ||
| import type { CreateTestConfigOptions } from '../shared/types'; | ||
|
|
||
| export function createTestConfig(options: CreateTestConfigOptions) { | ||
| export function createTestConfig<TServices extends {} = typeof services>( | ||
| options: CreateTestConfigOptions<TServices> | ||
| ) { | ||
| return async ({ readConfigFile }: FtrConfigProviderContext) => { | ||
| const svlSharedConfig = await readConfigFile(require.resolve('../shared/config.base.ts')); | ||
|
|
||
| return { | ||
| ...svlSharedConfig.getAll(), | ||
|
|
||
| pageObjects, | ||
| services, | ||
| services: { ...services, ...options.services }, | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. good solution, we shouldn't expose those |
||
| esTestCluster: { | ||
| ...svlSharedConfig.get('esTestCluster'), | ||
| serverArgs: [ | ||
|
|
||
47 changes: 47 additions & 0 deletions
47
x-pack/test_serverless/functional/test_suites/observability/config.telemetry.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,47 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { resolve } from 'path'; | ||
| import type { GenericFtrProviderContext } from '@kbn/test'; | ||
| import { KibanaEBTUIProvider } from '@kbn/test-suites-src/analytics/services/kibana_ebt'; | ||
| import { services as inheritedServices } from '../../services'; | ||
| import { pageObjects } from '../../page_objects'; | ||
| import { createTestConfig } from '../../config.base'; | ||
|
|
||
| type ObservabilityTelemetryServices = typeof inheritedServices & { | ||
| kibana_ebt_ui: typeof KibanaEBTUIProvider; | ||
| }; | ||
|
|
||
| const services: ObservabilityTelemetryServices = { | ||
| ...inheritedServices, | ||
| kibana_ebt_ui: KibanaEBTUIProvider, | ||
| }; | ||
|
|
||
| export type ObservabilityTelemetryFtrProviderContext = GenericFtrProviderContext< | ||
| ObservabilityTelemetryServices, | ||
| typeof pageObjects | ||
| >; | ||
|
|
||
| export default createTestConfig({ | ||
| serverlessProject: 'oblt', | ||
| testFiles: [require.resolve('./index.telemetry.ts')], | ||
| junit: { | ||
| reportName: 'Serverless Observability Telemetry Functional Tests', | ||
| }, | ||
| suiteTags: { exclude: ['skipSvlOblt'] }, | ||
| services, | ||
|
|
||
| // include settings from project controller | ||
| // https://github.com/elastic/project-controller/blob/main/internal/project/observability/config/elasticsearch.yml | ||
| esServerArgs: ['xpack.ml.dfa.enabled=false'], | ||
| kbnServerArgs: [ | ||
| `--plugin-path=${resolve( | ||
| __dirname, | ||
| '../../../../../test/analytics/plugins/analytics_ftr_helpers' | ||
| )}`, | ||
| ], | ||
| }); |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.