[Obs AI Assistant] Borealis theme integration by viduni94 · Pull Request #200814 · elastic/kibana

viduni94 · 2024-11-19T20:24:54Z

Summary

Integrates changes from the Borealis theme to the components owned by obs-ai-assistant, obs-knowledge teams and for files related to kbn-ai-assistant.

Checklist

The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

viduni94 · 2024-11-19T20:37:26Z

Hi @elastic/eui-team
I have a question w.r.t replacing the colors used for darkShade and darkestShade.
I want to update the below references to these colors since they are marked as deprecated.

kibana/x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/nav_control/index.tsx

Line 120 in 8e7799a

fill: ${theme.colors.darkestShade};

kibana/x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/changes/change_list.tsx

Line 81 in 8e7799a

color: theme.colors.darkShade,

However, I'm not sure about the approach I should follow for this.
For example, the hex color for darkestShade in the light theme is #2B394F which maps to blueGrey120 --> shade120 (in semantic colors)
However, I can't find a token in the light theme semantic colors for shade120 to replace darkestShade.

Would you be able to clarify how I should replace shade related variables?

mgadewoll · 2024-11-20T14:37:48Z

Hi @elastic/eui-team I have a question w.r.t replacing the colors used for darkShade and darkestShade. I want to update the below references to these colors since they are marked as deprecated.

kibana/x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/nav_control/index.tsx

Line 120 in 8e7799a

fill: ${theme.colors.darkestShade};

kibana/x-pack/plugins/observability_solution/observability_ai_assistant_app/public/components/changes/change_list.tsx

Line 81 in 8e7799a

color: theme.colors.darkShade,

However, I'm not sure about the approach I should follow for this. For example, the hex color for darkestShade in the light theme is #2B394F which maps to blueGrey120 --> shade120 (in semantic colors) However, I can't find a token in the light theme semantic colors for shade120 to replace darkestShade.

Would you be able to clarify how I should replace shade related variables?

@viduni94 Thanks for asking about it!
These legacy shade tokens (lightestShade, darkestShade etc) are mark as deprecated (they are not used in the new theme) but not required to be removed just yet. They have been mapped for now on EUI side. There will be a separate update round for those tokens once there is a clear way forward on how to move off them.

That's why they were not mentioned directly as changes in this document and we noted:

A practical example of this can be seen by looking at our shade colors. The naming of these tokens is based on their appearance -- dark. light, darkest, etc. Over time, we will deprecate these tokens in favor of tokens that are based on usage -- "border", "background", etc. This will be a key concept that allows us to iterate and evolve the Kibana UI over time -- cleanly and easily.

...ervability_solution/observability_ai_assistant/public/components/chat/chat_item_controls.tsx

mgadewoll

Changes LGTM from EUI side 🦄

elasticmachine · 2024-11-20T17:01:39Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

github-actions · 2024-11-20T17:02:05Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

viduni94 · 2024-11-20T17:09:25Z

The changes from my end are complete for all files owned by obs-ai-assistant and obs-knowledge.

However, I noticed one issue with the Obs AI Assistant UI which is related to files in x-pack/packages/kbn-ai-assistant
This is owned by search-kibana team, but thought of making a note here for visibility as we use the components in kbn-ai-assistant.

In Amsterdam, the comment list items have a darker border. The Borealis theme shows it correctly.

Amsterdam:

Borealis:

This issue was mentioned by another team in the eui Slack channel (thread)
I'll check on this again, once the fix is merged.

mgadewoll · 2024-11-20T17:11:00Z

The changes from my end are complete for all files owned by obs-ai-assistant and obs-knowledge.

However, I noticed one issue with the Obs AI Assistant UI which is related to files in x-pack/packages/kbn-ai-assistant This is owned by search-kibana team, but thought of making a note here for visibility as we use the components in kbn-ai-assistant.

In Amsterdam, the comment list items have a darker border. The Borealis theme shows it correctly.

Amsterdam:

Borealis:

This issue was mentioned by another team in the eui Slack channel (thread) I'll check on this again, once the fix is merged.

@viduni94 We're aware of the issue and already have a fix on EUI side for it.
It will be added on Kibana side with the next Borealis release.

viduni94 · 2024-11-20T17:12:43Z

@viduni94 We're aware of the issue and already have a fix on EUI side for it. It will be added on Kibana side with the next Borealis release.

Thank you @mgadewoll

viduni94 · 2024-11-21T13:24:26Z

/oblt-deploy

patpascal

Hi, @viduni94! Overall, it looks pretty good to me, but I noticed:

AI logo icon

To ensure a correct transition between themes, it's recommended (Slack conversation) to use the euiTheme.colors.title token instead of fill="#343741"
Note: The logo might change to be monochromatic in the future, so if updating it is a considerable effort, we can reevaluate.

Chart

Backgrounds look a bit off, but that's expected currently, as Charts have not been updated yet. No changes are needed!

viduni94 · 2024-11-26T14:21:40Z

Hi, @viduni94! Overall, it looks pretty good to me, but I noticed:

AI logo icon
To ensure a correct transition between themes, it's recommended ([Slack conversation](https://elastic.slack.com/archives/C060SDYTZ96/p1731421921528569?thread_ts=1731316042.876429&cid=C060SDYTZ96)) to use the `euiTheme.colors.title` [token](https://eui.elastic.co/#/theming/colors/values#text-colors) instead of fill="#343741" Note: The logo might change to be monochromatic in the future, so if updating it is a considerable effort, we can reevaluate.

Hi @patpscal
Thank you for the review.

I tried adding euiTheme.colors.title, however, it's marked as deprecated.

Therefore I added euiTheme.colors.textHeading. Would this work?

https://github.com/elastic/kibana/pull/200814/files#diff-99dc84658998ef72039163efdc16b1b4b3f6bff6ce03a1f329caadc16794958cR42

ek-so · 2024-11-26T14:34:42Z

@viduni94 we were planning to use euiTheme.colors.textParagraph for the icons, coz they usually stand close to regular text paragraph, so I imagine it would be more consistent if we use it here as well, wdyt @patpscal? And that said, the difference between heading and paragraph is minimal anyway.

Just a note. That is correct, we have euiTheme.colors.textHeading and euiTheme.colors.textParagaraph now as main tokens to work with text.

patpascal · 2024-11-26T14:45:48Z

@viduni94 we were planning to use euiTheme.colors.textParagraph for the icons, coz they usually stand close to regular text paragraph, so I imagine it would be more consistent if we use it here as well, wdyt @patpscal? And that said, the difference between heading and paragraph is minimal anyway.

Just a note. That is correct, we have euiTheme.colors.textHeading and euiTheme.colors.textParagaraph now as main tokens to work with text.

Sounds good! Let's use euiTheme.colors.textParagaraph

viduni94 · 2024-11-26T15:47:59Z

@viduni94 we were planning to use euiTheme.colors.textParagraph for the icons, coz they usually stand close to regular text paragraph, so I imagine it would be more consistent if we use it here as well, wdyt @patpscal? And that said, the difference between heading and paragraph is minimal anyway.
Just a note. That is correct, we have euiTheme.colors.textHeading and euiTheme.colors.textParagaraph now as main tokens to work with text.

Sounds good! Let's use euiTheme.colors.textParagaraph

I've made the change and updated the deployment.

patpascal

Looks good to me! 🎉

…st yet

…oyed environment

elasticmachine · 2024-11-26T17:05:45Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 6579011
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-200814-657901108eb2

Failed CI Steps

FTR Configs #16

Test Failures

[job] [logs] FTR Configs #16 / management Index patterns on aliases discover verify hits should be able to discover and verify no of hits for alias2

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`observabilityAIAssistantApp`	237.5KB	237.5KB	-71.0B
`searchAssistant`	160.2KB	160.2KB	-3.0B
total			-74.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`observabilityAIAssistant`	47.0KB	47.0KB	-7.0B
`observabilityAIAssistantApp`	8.7KB	8.6KB	-54.0B
`searchAssistant`	4.7KB	4.7KB	-54.0B
total			-115.0B

History

💔 Build #254513 failed f0aef54316c51e8aad08dfe0f8c73237eeb8dd6c
💔 Build #254484 failed 210e608731d39db50f8afd4b2a3a38ecab97ef5f
💔 Build #253739 failed e64a3a6fc629179bcd4fbda498f25b294480e2d3
💚 Build #253326 succeeded 5fb271e8e8247754eb062d60698e2dbf00929572
💛 Build #253264 was flaky 1fc24878b3c09707a617c2bc62cb63b92d4c7336

cc @viduni94

## Summary Integrates changes from the Borealis theme to the components owned by `obs-ai-assistant`, `obs-knowledge` teams and for files related to `kbn-ai-assistant`. ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

viduni94 added release_note:enhancement backport:skip This PR does not require backporting Team:Obs AI Assistant Observability AI Assistant EUI Visual Refresh labels Nov 19, 2024

viduni94 self-assigned this Nov 19, 2024

viduni94 requested a review from a team November 19, 2024 20:25

viduni94 force-pushed the borealis-theme-updates branch from b9a7eb7 to 02fe1ad Compare November 20, 2024 12:48

mgadewoll reviewed Nov 20, 2024

View reviewed changes

...ervability_solution/observability_ai_assistant/public/components/chat/chat_item_controls.tsx Outdated Show resolved Hide resolved

mgadewoll approved these changes Nov 20, 2024

View reviewed changes

viduni94 force-pushed the borealis-theme-updates branch from 7beecbf to 2714969 Compare November 20, 2024 16:34

viduni94 added the v9.0.0 label Nov 20, 2024

viduni94 marked this pull request as ready for review November 20, 2024 17:01

viduni94 requested review from a team as code owners November 20, 2024 17:01

viduni94 force-pushed the borealis-theme-updates branch from 2714969 to c8e5f24 Compare November 20, 2024 17:01

botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 20, 2024

viduni94 requested review from kkurstak and patpascal November 20, 2024 17:03

viduni94 force-pushed the borealis-theme-updates branch from c8e5f24 to 756a735 Compare November 21, 2024 12:26

viduni94 force-pushed the borealis-theme-updates branch from 756a735 to 1fc2487 Compare November 21, 2024 16:08

viduni94 requested a review from a team as a code owner November 21, 2024 18:03

mgadewoll approved these changes Nov 25, 2024

View reviewed changes

patpascal requested changes Nov 26, 2024

View reviewed changes

pgayvallet approved these changes Nov 26, 2024

View reviewed changes

viduni94 force-pushed the borealis-theme-updates branch from e64a3a6 to 4b2247a Compare November 26, 2024 14:00

viduni94 requested a review from patpascal November 26, 2024 14:22

patpascal approved these changes Nov 26, 2024

View reviewed changes

viduni94 and others added 9 commits November 26, 2024 10:57

[Obs AI Assistant] Borealis theme updates (elastic#199715)

ba90934

[Obs AI Assistant] Restore shades as they are not needed to remove ju…

7c6d526

…st yet

[Obs AI Assistant] Update text variables and remove unnecessary styles

3d19d3e

[Obs AI Assistant] Integrate borealis theme updates to kbn-ai-assistant

b99dfe6

[CI] Auto-commit changed files from 'node scripts/notice'

89688ad

[Obs AI Assistant] Hardcode theme switch toggle for design QA on depl…

5f73736

…oyed environment

[Obs AI Assistant] Update one color in the assistant avatar

af7af21

[Obs AI Assistant] Use textParagraph instead of textHeading

0bc9098

[Obs AI Assistant] Remove hardcoded lines

6579011

viduni94 force-pushed the borealis-theme-updates branch from 21f081d to 6579011 Compare November 26, 2024 15:57

viduni94 removed request for a team and kkurstak November 26, 2024 16:01

andrew-goldstein approved these changes Nov 26, 2024

View reviewed changes

sphilipse approved these changes Nov 27, 2024

View reviewed changes

viduni94 added release_note:skip Skip the PR/issue when compiling release notes and removed release_note:enhancement labels Nov 27, 2024

viduni94 merged commit a800360 into elastic:main Nov 27, 2024

MiriamAparicio mentioned this pull request Dec 3, 2024

[Infra] Migrate infra from styled-components to @emotion #202405

Merged

Conversation

viduni94 commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

Uh oh!

viduni94 commented Nov 19, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

mgadewoll commented Nov 20, 2024

Uh oh!

Uh oh!

mgadewoll left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 20, 2024

Uh oh!

github-actions bot commented Nov 20, 2024

🤖 GitHub comments

Uh oh!

viduni94 commented Nov 20, 2024

Uh oh!

mgadewoll commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

viduni94 commented Nov 20, 2024

Uh oh!

viduni94 commented Nov 21, 2024

Uh oh!

patpascal left a comment

Choose a reason for hiding this comment

AI logo icon

Chart

Uh oh!

viduni94 commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

AI logo icon

Uh oh!

ek-so commented Nov 26, 2024

Uh oh!

patpascal commented Nov 26, 2024

Uh oh!

viduni94 commented Nov 26, 2024

Uh oh!

patpascal left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 26, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

Page load bundle

History

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

10 participants

viduni94 commented Nov 19, 2024 •

edited

Loading

viduni94 commented Nov 19, 2024 •

edited

Loading

mgadewoll commented Nov 20, 2024 •

edited

Loading

viduni94 commented Nov 26, 2024 •

edited

Loading

elasticmachine commented Nov 26, 2024 •

edited

Loading