Skip to content

[8.15] [Infra] Use callback for logger.trace calls (#199805) #200682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
kibanamachine wants to merge 1 commit into from
Closed

[8.15] [Infra] Use callback for logger.trace calls (#199805) #200682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions ...servability_solution/infra/server/lib/alerting/inventory_metric_threshold/lib/get_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,9 @@ export const getData = async (
customMetric,
fieldsExisted
);
logger.trace(`Request: ${JSON.stringify(request)}`);
logger.trace(() => `Request: ${JSON.stringify(request)}`);
const body = await esClient.search<undefined, ResponseAggregations>(request);
logger.trace(`Response: ${JSON.stringify(body)}`);
logger.trace(() => `Response: ${JSON.stringify(body)}`);
if (body.aggregations) {
return handleResponse(body.aggregations, previousNodes);
}
Expand Down
4 changes: 2 additions & 2 deletions ...ervability_solution/infra/server/lib/alerting/metric_threshold/lib/check_missing_group.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,9 +57,9 @@ export const checkMissingGroups = async (
];
});

logger.trace(`Request: ${JSON.stringify({ searches })}`);
logger.trace(() => `Request: ${JSON.stringify({ searches })}`);
const response = await esClient.msearch({ searches });
logger.trace(`Response: ${JSON.stringify(response)}`);
logger.trace(() => `Response: ${JSON.stringify(response)}`);

const verifiedMissingGroups = response.responses
.map((resp, index) => {
Expand Down
4 changes: 2 additions & 2 deletions ...plugins/observability_solution/infra/server/lib/alerting/metric_threshold/lib/get_data.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -277,10 +277,10 @@ export const getData = async (
fieldsExisted
),
};
logger.trace(`Request: ${JSON.stringify(request)}`);
logger.trace(() => `Request: ${JSON.stringify(request)}`);
const body = await esClient.search<undefined, ResponseAggregations>(request);
const { aggregations, _shards } = body;
logger.trace(`Response: ${JSON.stringify(body)}`);
logger.trace(() => `Response: ${JSON.stringify(body)}`);
if (aggregations) {
return handleResponse(aggregations, previousResults, _shards.successful);
} else if (_shards.successful) {
Expand Down