[Security Solution] Remove a blog post callout from rule management page#200650
Merged
nikitaindik merged 1 commit intoelastic:8.xfrom Nov 19, 2024
Merged
Conversation
nikitaindik
added
release_note:skip
Contributor
|
Pinging @elastic/security-detections-response (Team:Detections and Resp) |
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-detection-rule-management (Team:Detection Rule Management) |
dplumlee
approved these changes
Nov 18, 2024
Contributor
dplumlee
left a comment
dplumlee
left a comment
There was a problem hiding this comment.
LGTM @nikitaindik, I no longer see the callout when loading the rule management page.
Approving for merging before feature freeze but is there any reason we're keeping the blog_post_detection_engineering_callout folder? Future use?
Contributor
Author
|
Thanks for the quick review, @dplumlee!
Yes, we will likely need to create more banners like this in the future, so we can reuse the component. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #197024
Summary
PR #195943 added a callout banner to the 8.x branch. This banner was intended to be displayed only in ESS v8.16. We are now removing it to ensure it does not appear in v8.17.0.
Screenshots
Before
After
