[Security Solution][Bidirectional Integrations Banner][Crowdstrike][SentinelOne] Banner for bidirectional integrations#200625
Merged
parkiino merged 8 commits intoelastic:mainfrom Nov 19, 2024
Conversation
parkiino
added
release_note:skip
Contributor
|
Pinging @elastic/security-defend-workflows (Team:Defend Workflows) |
botelastic
bot
added
the
Team:Fleet
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
jmikell821
approved these changes
Nov 18, 2024
paul-tavares
requested changes
Nov 18, 2024
Contributor
paul-tavares
left a comment
paul-tavares
left a comment
There was a problem hiding this comment.
There a few issues that I left feedback for.
...s/integrations/sections/epm/screens/detail/components/bidirectional_integrations_callout.tsx
Show resolved
Hide resolved
| const isUnverified = isPackageUnverified(packageInfo, packageVerificationKeyId); | ||
| const isPrerelease = isPackagePrerelease(packageInfo.version); | ||
| const isElasticDefend = packageInfo.name === 'endpoint'; | ||
| const isSentinelOneCloudFunnel = packageInfo.name === 'sentinel_one_cloud_funnel'; |
Contributor
There was a problem hiding this comment.
I don't understand why SentinelOne Cloud Funnel is getting this callout. We have not tested or have claimed to support it for response actions. We only currently support the "normal" SentinelOne integration not this one.
Contributor
Author
There was a problem hiding this comment.
@caitlinbetz should we actually be showing this banner for the regular SentinelOne integration instead of the Cloud Funnel one?
| storage.get('securitySolution.showAvcBanner') ?? true | ||
| ); | ||
| const onBannerDismiss = useCallback(() => { | ||
| const [showBidIntBanner, setShowBidIntBanner] = useState( |
Contributor
There was a problem hiding this comment.
(Optional) I found the name of these variables confusing "..BidInt...". Maybe consider rename it to showResponseSupportBanner
Comment on lines
+312
to
+316
| const onBidIntBannerDismiss = useCallback(() => { | ||
| setShowBidIntBanner(false); | ||
| storage.set('securitySolution.showBidIntBanner', false); | ||
| }, [storage]); | ||
|
|
Contributor
There was a problem hiding this comment.
This does not seem like its implemented correctly. So if the banner is "dismissed" for SentinelOne, a user will never see it for Crowdstrike? Shouldn't the dismissal be for each type of integration?
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Async chunks
Page load bundle
History
|
2 tasks
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11916894410 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 19, 2024
…entinelOne] Banner for bidirectional integrations (elastic#200625) ## Summary - [x] Callouts for bidirectional integrations capabilities on Sentinel One and Crowdstrike integrations. - [x] Unit tests # Screenshots <img width="1685" alt="image" src="https://github.com/user-attachments/assets/f360c391-6046-49a8-b9d4-56a598dc2b99"> <img width="1132" alt="image" src="https://github.com/user-attachments/assets/9a15dc52-172a-4ee9-8e39-831a524e5d0b"> DARK MODE <img width="1127" alt="image" src="https://github.com/user-attachments/assets/9ab39df4-960b-4a56-b9bf-8c2077304039">  (cherry picked from commit 3c32748)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 19, 2024
…ike][SentinelOne] Banner for bidirectional integrations (#200625) (#200768) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Bidirectional Integrations Banner][Crowdstrike][SentinelOne] Banner for bidirectional integrations (#200625)](#200625) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Candace Park","email":"56409205+parkiino@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-19T04:46:25Z","message":"[Security Solution][Bidirectional Integrations Banner][Crowdstrike][SentinelOne] Banner for bidirectional integrations (#200625)\n\n## Summary\r\n\r\n- [x] Callouts for bidirectional integrations capabilities on Sentinel\r\nOne and Crowdstrike integrations.\r\n- [x] Unit tests\r\n\r\n# Screenshots\r\n<img width=\"1685\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f360c391-6046-49a8-b9d4-56a598dc2b99\">\r\n<img width=\"1132\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9a15dc52-172a-4ee9-8e39-831a524e5d0b\">\r\n\r\nDARK MODE\r\n<img width=\"1127\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9ab39df4-960b-4a56-b9bf-8c2077304039\">\r\n\r\n\r\n\r\n","sha":"3c3274829bdcb950ab4aff9abf1d106482de6267","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","Team:Defend Workflows","backport:prev-minor","v8.17.0"],"title":"[Security Solution][Bidirectional Integrations Banner][Crowdstrike][SentinelOne] Banner for bidirectional integrations","number":200625,"url":"https://github.com/elastic/kibana/pull/200625","mergeCommit":{"message":"[Security Solution][Bidirectional Integrations Banner][Crowdstrike][SentinelOne] Banner for bidirectional integrations (#200625)\n\n## Summary\r\n\r\n- [x] Callouts for bidirectional integrations capabilities on Sentinel\r\nOne and Crowdstrike integrations.\r\n- [x] Unit tests\r\n\r\n# Screenshots\r\n<img width=\"1685\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f360c391-6046-49a8-b9d4-56a598dc2b99\">\r\n<img width=\"1132\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9a15dc52-172a-4ee9-8e39-831a524e5d0b\">\r\n\r\nDARK MODE\r\n<img width=\"1127\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9ab39df4-960b-4a56-b9bf-8c2077304039\">\r\n\r\n\r\n\r\n","sha":"3c3274829bdcb950ab4aff9abf1d106482de6267"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200625","number":200625,"mergeCommit":{"message":"[Security Solution][Bidirectional Integrations Banner][Crowdstrike][SentinelOne] Banner for bidirectional integrations (#200625)\n\n## Summary\r\n\r\n- [x] Callouts for bidirectional integrations capabilities on Sentinel\r\nOne and Crowdstrike integrations.\r\n- [x] Unit tests\r\n\r\n# Screenshots\r\n<img width=\"1685\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/f360c391-6046-49a8-b9d4-56a598dc2b99\">\r\n<img width=\"1132\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9a15dc52-172a-4ee9-8e39-831a524e5d0b\">\r\n\r\nDARK MODE\r\n<img width=\"1127\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9ab39df4-960b-4a56-b9bf-8c2077304039\">\r\n\r\n\r\n\r\n","sha":"3c3274829bdcb950ab4aff9abf1d106482de6267"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Candace Park <56409205+parkiino@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…entinelOne] Banner for bidirectional integrations (elastic#200625) ## Summary - [x] Callouts for bidirectional integrations capabilities on Sentinel One and Crowdstrike integrations. - [x] Unit tests # Screenshots <img width="1685" alt="image" src="https://github.com/user-attachments/assets/f360c391-6046-49a8-b9d4-56a598dc2b99"> <img width="1132" alt="image" src="https://github.com/user-attachments/assets/9a15dc52-172a-4ee9-8e39-831a524e5d0b"> DARK MODE <img width="1127" alt="image" src="https://github.com/user-attachments/assets/9ab39df4-960b-4a56-b9bf-8c2077304039"> 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Screenshots
DARK MODE
