-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[Spaces] Moved tests to agnostic setup #200606
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
e8088b8
41dfba2
e463d1f
f9d1d70
b2b4847
a20cb07
9d8b9a9
daec53f
111b4b3
9190e14
28ba05a
e6b4563
0db0033
c771a11
0e19cd1
cac3073
5df6357
e9c6a36
b892778
d0bd5d6
99c18fb
24c1548
dda347d
f089b02
008ed23
0e6c69c
6e362b3
c7c91eb
9cd8a5d
8206419
f289e05
670e1d1
703f1e5
094aaee
23bc295
12a11e9
2064f15
2bd07ce
dc6a47c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -128,3 +128,4 @@ system_indices_superuser: | |
| privileges: ['*'] | ||
| resources: ['*'] | ||
| run_as: ['*'] | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -34,5 +34,11 @@ module.exports = { | |
| '@typescript-eslint/no-floating-promises': 'error', | ||
| }, | ||
| }, | ||
| { | ||
| files: ['*spaces_api_integration/common/services/basic_auth_supertest.ts'], | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. agent.auth(this.user.username!, this.user.password!);Needed to suppress the eslint error for this line in our custom test service, the promise is awaited in the tests itself and adding a
|
||
| rules: { | ||
| '@typescript-eslint/no-floating-promises': 'off', | ||
| }, | ||
| }, | ||
| ], | ||
| }; | ||
| Original file line number | Diff line number | Diff line change | ||
|---|---|---|---|---|
|
|
@@ -10,6 +10,8 @@ import path from 'path'; | |||
| import { REPO_ROOT } from '@kbn/repo-info'; | ||||
| import type { FtrConfigProviderContext } from '@kbn/test'; | ||||
|
|
||||
| import { services } from './services'; | ||||
|
|
||||
| interface CreateTestConfigOptions { | ||||
| license: string; | ||||
| disabledPlugins?: string[]; | ||||
|
|
@@ -45,6 +47,8 @@ export function createTestConfig(name: string, options: CreateTestConfigOptions) | |||
| kibanaServer: config.kibana.functional.get('services.kibanaServer'), | ||||
| spaces: config.xpack.api.get('services.spaces'), | ||||
| usageAPI: config.xpack.api.get('services.usageAPI'), | ||||
| roleScopedSupertest: services.roleScopedSupertest, | ||||
| samlAuth: () => {}, | ||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Do we need this here?
Suggested change
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Yes, we use |
||||
| }, | ||||
| junit: { | ||||
| reportName: 'X-Pack Spaces API Integration Tests -- ' + name, | ||||
|
|
||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we discussed it with @azasypkin and @jeramysoucy , that while
basiclicense is stateful-only, these tests cannot be considered deployment-agnostic. wdyt?Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can move them out of the
deployment_agnosticfolder to eliminate confusion, but all those tests still use the same test suite the serverless/trial config doesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
IIRC, we determined in our meeting last week that it did not make sense to try to split these tests out due to how these test suites are structured. Please correct me if I am wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct, I think the comment is only regarding the config location. IMHO makes sense to leave as is since it references the same suite