[Fleet] Fail gracefully on agent count retrieval#200590
Merged
nchaulet merged 4 commits intoelastic:mainfrom Nov 18, 2024
Merged
[Fleet] Fail gracefully on agent count retrieval#200590nchaulet merged 4 commits intoelastic:mainfrom
nchaulet merged 4 commits intoelastic:mainfrom
Conversation
nchaulet
added
release_note:skip
Contributor
|
Pinging @elastic/fleet (Team:Fleet) |
...ic/applications/fleet/sections/settings/components/download_source_flyout/confirm_update.tsx
Outdated
Show resolved
Hide resolved
…gs/components/download_source_flyout/confirm_update.tsx Co-authored-by: Julia Bardi <90178898+juliaElastic@users.noreply.github.com>
criamico
reviewed
Nov 18, 2024
Contributor
criamico
left a comment
criamico
left a comment
There was a problem hiding this comment.
I left some comments about the copy
| <FormattedMessage | ||
| id="xpack.fleet.settings.updateDownloadSourceModal.confirmModalTextWithoutCount" | ||
| data-test-subj="editDownloadSourcesConfirmModal.confirmModalText" | ||
| defaultMessage="This action will update {downloadSourceName} agent binary source. It will update related policies and agents. This action can not be undone. Are you sure you wish to continue?" |
Contributor
There was a problem hiding this comment.
I think that repeating the will update part twice sounds a bit strange here. Could we change to something like this instead?
This action will update {downloadSourceName} agent binary source, its related policies and agents. This action can not be undone. Are you sure you wish to continue?
| ) : ( | ||
| <FormattedMessage | ||
| id="xpack.fleet.settings.deleteDowloadSource.confirmModalTextWithoutCount" | ||
| defaultMessage="This action will delete {downloadSourceName} agent binary source. It will update related policies and agents. This action can not be undone. Are you sure you wish to continue?" |
Contributor
There was a problem hiding this comment.
I'd suggest:
This action will delete {downloadSourceName} agent binary source and it will update its related policies and agents. This action can not be undone. Are you sure you wish to continue?
Member
Author
There was a problem hiding this comment.
Thanks, this sounds better I will made the change
criamico
reviewed
Nov 18, 2024
| <FormattedMessage | ||
| id="xpack.fleet.settings.deleteDowloadSource.confirmModalTextWithoutCount" | ||
| defaultMessage="This action will delete {downloadSourceName} agent binary source. It will update related policies and agents. This action can not be undone. Are you sure you wish to continue?" | ||
| defaultMessage="This action will delete {downloadSourceName} agent binary sourceand it will update its related policies and agents. This action can not be undone. Are you sure you wish to continue?" |
Contributor
There was a problem hiding this comment.
there's a missing space :)
criamico
approved these changes
Nov 18, 2024
Contributor
criamico
left a comment
criamico
left a comment
There was a problem hiding this comment.
Thanks for the changes! LGTM
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11899451975 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
cc @nchaulet |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
(cherry picked from commit e9881a7)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
…0641) # Backport This will backport the following commits from `main` to `8.x`: - [[Fleet] Fail gracefully on agent count retrieval (#200590)](#200590) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Nicolas Chaulet","email":"nicolas.chaulet@elastic.co"},"sourceCommit":{"committedDate":"2024-11-18T19:15:00Z","message":"[Fleet] Fail gracefully on agent count retrieval (#200590)","sha":"e9881a7add765f532ab500b7d74f9c988727d2b0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet] Fail gracefully on agent count retrieval","number":200590,"url":"https://github.com/elastic/kibana/pull/200590","mergeCommit":{"message":"[Fleet] Fail gracefully on agent count retrieval (#200590)","sha":"e9881a7add765f532ab500b7d74f9c988727d2b0"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200590","number":200590,"mergeCommit":{"message":"[Fleet] Fail gracefully on agent count retrieval (#200590)","sha":"e9881a7add765f532ab500b7d74f9c988727d2b0"}}]}] BACKPORT--> Co-authored-by: Nicolas Chaulet <nicolas.chaulet@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolve #192056
When a user do not have the permissions to read agent or agents policies we cannot retrieve the agent count, because of that we were not able to show the confirm modal when updating/delating outputs/binary source. That PR fix that by failing gracefully when we are not able to retrieve that count.
UI Changes