Skip to content

[Inventory] Remove open in Discover button#200574

Merged
jennypavlova merged 4 commits intoelastic:mainfrom
jennypavlova:199964-obsux-inventory-remove-open-in-discover-button
Nov 18, 2024
Merged

[Inventory] Remove open in Discover button#200574
jennypavlova merged 4 commits intoelastic:mainfrom
jennypavlova:199964-obsux-inventory-remove-open-in-discover-button

Conversation

@jennypavlova
Copy link
Member

Closes #199964

This PR removes the open in discover button from the inventory search bar section.

Before After
image image

@jennypavlova jennypavlova added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting v9.0.0 Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.17.0 labels Nov 18, 2024
@jennypavlova jennypavlova self-assigned this Nov 18, 2024
@jennypavlova jennypavlova requested a review from a team November 18, 2024 14:06
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Nov 18, 2024
@github-actions
Copy link
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jennypavlova jennypavlova enabled auto-merge (squash) November 18, 2024 14:15
@elasticmachine
Copy link
Contributor

⏳ Build in-progress

  • Buildkite Build
  • Commit: 9c710ff
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-200574-9c710ffc9ada

History

cc @jennypavlova

@jennypavlova
Copy link
Member Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

jennypavlova added a commit to jennypavlova/kibana that referenced this pull request Nov 19, 2024
Closes elastic#199964

This PR removes the `open in discover` button from the inventory search
bar section.

| Before | After |
| ------- | ----- |
| <img width="1911" alt="image"
src="https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32">
| <img width="1915" alt="image"
src="https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373">
|

(cherry picked from commit 1607803)
jennypavlova added a commit that referenced this pull request Nov 19, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Remove open in Discover button
(#200574)](#200574)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"jennypavlova","email":"dzheni.pavlova@elastic.co"},"sourceCommit":{"committedDate":"2024-11-18T16:27:32Z","message":"[Inventory]
Remove open in Discover button (#200574)\n\nCloses #199964 \r\n\r\nThis
PR removes the `open in discover` button from the inventory
search\r\nbar section.\r\n\r\n| Before | After |\r\n| ------- | -----
|\r\n| <img width=\"1911\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32\">\r\n|
<img width=\"1915\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373\">\r\n|","sha":"1607803f610cbbc97883b78578723fa8400c7b4a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.17.0"],"number":200574,"url":"https://github.com/elastic/kibana/pull/200574","mergeCommit":{"message":"[Inventory]
Remove open in Discover button (#200574)\n\nCloses #199964 \r\n\r\nThis
PR removes the `open in discover` button from the inventory
search\r\nbar section.\r\n\r\n| Before | After |\r\n| ------- | -----
|\r\n| <img width=\"1911\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32\">\r\n|
<img width=\"1915\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373\">\r\n|","sha":"1607803f610cbbc97883b78578723fa8400c7b4a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200574","number":200574,"mergeCommit":{"message":"[Inventory]
Remove open in Discover button (#200574)\n\nCloses #199964 \r\n\r\nThis
PR removes the `open in discover` button from the inventory
search\r\nbar section.\r\n\r\n| Before | After |\r\n| ------- | -----
|\r\n| <img width=\"1911\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32\">\r\n|
<img width=\"1915\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373\">\r\n|","sha":"1607803f610cbbc97883b78578723fa8400c7b4a"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
Closes elastic#199964 

This PR removes the `open in discover` button from the inventory search
bar section.

| Before | After |
| ------- | ----- |
| <img width="1911" alt="image"
src="https://github.com/user-attachments/assets/627ebfa0-77c9-4ff1-8a38-3623bf1b7e32">
| <img width="1915" alt="image"
src="https://github.com/user-attachments/assets/2dace203-7203-4bda-8cee-0186e022e373">
|
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:skip This PR does not require backporting ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services - DEPRECATED DEPRECATED - Use Team:obs-presentation. v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[ObsUx][Inventory] Remove open in discover button

3 participants