[Security Solution] Update alert kpi to exclude closed alerts in document details flyout#200268
Merged
christineweng merged 2 commits intoelastic:mainfrom Nov 18, 2024
Merged
Conversation
christineweng
added
release_note:enhancement
backport
Contributor
|
Pinging @elastic/security-threat-hunting (Team:Threat Hunting) |
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
approved these changes
Nov 14, 2024
Contributor
PhilippeOberti
left a comment
PhilippeOberti
left a comment
There was a problem hiding this comment.
thanks for bringing the consistent behavior between the entity and the alerts details flyout. Desk tested and code LGTM!
christineweng
force-pushed
the
update-flyout-alert-kpi
branch
from
13423c2 to
a1b38ce
Compare
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11899860727 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
…ment details flyout (elastic#200268) ## Summary This PR made some changes to the alert count API in document details flyout. Closed alerts are now removed when showing total count and distributions. Data fetching logic is updated to match the one used in host flyout (elastic#197102). Notable changes: - Closed alerts are now excluded - Number of alerts in alerts flyout should match the ones in host flyout - Clicking the number will open timeline with the specific entity and `NOT kibana.alert.workflow_status: closed` filters - If a host/user does not have active alerts (all closed), no distribution bar is shown https://github.com/user-attachments/assets/3a1d6e36-527e-4b62-816b-e1f4de7314ca ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit a37a02e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
…n document details flyout (#200268) (#200642) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution] Update alert kpi to exclude closed alerts in document details flyout (#200268)](#200268) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"christineweng","email":"18648970+christineweng@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-18T19:42:34Z","message":"[Security Solution] Update alert kpi to exclude closed alerts in document details flyout (#200268)\n\n## Summary\r\n\r\nThis PR made some changes to the alert count API in document details\r\nflyout. Closed alerts are now removed when showing total count and\r\ndistributions. Data fetching logic is updated to match the one used in\r\nhost flyout (https://github.com/elastic/kibana/pull/197102).\r\n\r\nNotable changes:\r\n- Closed alerts are now excluded\r\n- Number of alerts in alerts flyout should match the ones in host flyout\r\n- Clicking the number will open timeline with the specific entity and\r\n`NOT kibana.alert.workflow_status: closed` filters\r\n- If a host/user does not have active alerts (all closed), no\r\ndistribution bar is shown\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3a1d6e36-527e-4b62-816b-e1f4de7314ca\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a37a02efcff84282aafb1b94778fd09f0f2025f0","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement","backport","v9.0.0","Team:Threat Hunting","Team:Threat Hunting:Investigations","v8.17.0"],"title":"[Security Solution] Update alert kpi to exclude closed alerts in document details flyout","number":200268,"url":"https://github.com/elastic/kibana/pull/200268","mergeCommit":{"message":"[Security Solution] Update alert kpi to exclude closed alerts in document details flyout (#200268)\n\n## Summary\r\n\r\nThis PR made some changes to the alert count API in document details\r\nflyout. Closed alerts are now removed when showing total count and\r\ndistributions. Data fetching logic is updated to match the one used in\r\nhost flyout (https://github.com/elastic/kibana/pull/197102).\r\n\r\nNotable changes:\r\n- Closed alerts are now excluded\r\n- Number of alerts in alerts flyout should match the ones in host flyout\r\n- Clicking the number will open timeline with the specific entity and\r\n`NOT kibana.alert.workflow_status: closed` filters\r\n- If a host/user does not have active alerts (all closed), no\r\ndistribution bar is shown\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3a1d6e36-527e-4b62-816b-e1f4de7314ca\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a37a02efcff84282aafb1b94778fd09f0f2025f0"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200268","number":200268,"mergeCommit":{"message":"[Security Solution] Update alert kpi to exclude closed alerts in document details flyout (#200268)\n\n## Summary\r\n\r\nThis PR made some changes to the alert count API in document details\r\nflyout. Closed alerts are now removed when showing total count and\r\ndistributions. Data fetching logic is updated to match the one used in\r\nhost flyout (https://github.com/elastic/kibana/pull/197102).\r\n\r\nNotable changes:\r\n- Closed alerts are now excluded\r\n- Number of alerts in alerts flyout should match the ones in host flyout\r\n- Clicking the number will open timeline with the specific entity and\r\n`NOT kibana.alert.workflow_status: closed` filters\r\n- If a host/user does not have active alerts (all closed), no\r\ndistribution bar is shown\r\n\r\n\r\nhttps://github.com/user-attachments/assets/3a1d6e36-527e-4b62-816b-e1f4de7314ca\r\n\r\n\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"a37a02efcff84282aafb1b94778fd09f0f2025f0"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: christineweng <18648970+christineweng@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
…ment details flyout (elastic#200268) ## Summary This PR made some changes to the alert count API in document details flyout. Closed alerts are now removed when showing total count and distributions. Data fetching logic is updated to match the one used in host flyout (elastic#197102). Notable changes: - Closed alerts are now excluded - Number of alerts in alerts flyout should match the ones in host flyout - Clicking the number will open timeline with the specific entity and `NOT kibana.alert.workflow_status: closed` filters - If a host/user does not have active alerts (all closed), no distribution bar is shown https://github.com/user-attachments/assets/3a1d6e36-527e-4b62-816b-e1f4de7314ca ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR made some changes to the alert count API in document details flyout. Closed alerts are now removed when showing total count and distributions. Data fetching logic is updated to match the one used in host flyout (#197102).
Notable changes:
NOT kibana.alert.workflow_status: closedfiltersScreen.Recording.2024-11-14.at.4.05.08.PM.mov
Checklist