-
Notifications
You must be signed in to change notification settings - Fork 8.6k
[APM] Migrate time_range_metadata test to deployment agnostic #200146
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
2fea0f9
58e6203
d497a5f
05a1eff
ba3681f
6d9e9be
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,15 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
|
|
||
| import { DeploymentAgnosticFtrProviderContext } from '../../../../ftr_provider_context'; | ||
|
|
||
| export default function ({ loadTestFile }: DeploymentAgnosticFtrProviderContext) { | ||
| describe('time_range_metadata', () => { | ||
| loadTestFile(require.resolve('./many_apm_server_versions.spec.ts')); | ||
| loadTestFile(require.resolve('./time_range_metadata.spec.ts')); | ||
| }); | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,276 @@ | ||
| /* | ||
| * Copyright Elasticsearch B.V. and/or licensed to Elasticsearch B.V. under one | ||
| * or more contributor license agreements. Licensed under the Elastic License | ||
| * 2.0; you may not use this file except in compliance with the Elastic License | ||
| * 2.0. | ||
| */ | ||
| import expect from '@kbn/expect'; | ||
| import { apm, timerange } from '@kbn/apm-synthtrace-client'; | ||
| import moment from 'moment'; | ||
| import { ApmSynthtraceEsClient } from '@kbn/apm-synthtrace'; | ||
| import { | ||
| TRANSACTION_DURATION_HISTOGRAM, | ||
| TRANSACTION_DURATION_SUMMARY, | ||
| } from '@kbn/apm-plugin/common/es_fields/apm'; | ||
| import { ApmDocumentType } from '@kbn/apm-plugin/common/document_type'; | ||
| import { RollupInterval } from '@kbn/apm-plugin/common/rollup'; | ||
| import { LatencyAggregationType } from '@kbn/apm-plugin/common/latency_aggregation_types'; | ||
| import { Readable } from 'stream'; | ||
| import type { ApmApiClient } from '../../../../services/apm_api'; | ||
| import type { DeploymentAgnosticFtrProviderContext } from '../../../../ftr_provider_context'; | ||
|
|
||
| export default function ApiTest({ getService }: DeploymentAgnosticFtrProviderContext) { | ||
| const apmApiClient = getService('apmApi'); | ||
| const synthtrace = getService('synthtrace'); | ||
| const es = getService('es'); | ||
|
|
||
| const baseTime = new Date('2023-10-01T00:00:00.000Z').getTime(); | ||
| const startLegacy = moment(baseTime).add(0, 'minutes'); | ||
| const start = moment(baseTime).add(5, 'minutes'); | ||
| const endLegacy = moment(baseTime).add(10, 'minutes'); | ||
| const end = moment(baseTime).add(15, 'minutes'); | ||
|
|
||
| describe('Time range metadata when there are multiple APM Server versions', () => { | ||
| describe('when ingesting traces from APM Server with different versions', () => { | ||
| let apmSynthtraceEsClient: ApmSynthtraceEsClient; | ||
|
|
||
| before(async () => { | ||
| apmSynthtraceEsClient = await synthtrace.createApmSynthtraceEsClient(); | ||
| await generateTraceDataForService({ | ||
| serviceName: 'synth-java-legacy', | ||
| start: startLegacy, | ||
| end: endLegacy, | ||
| isLegacy: true, | ||
| synthtrace: apmSynthtraceEsClient, | ||
| }); | ||
|
|
||
| await generateTraceDataForService({ | ||
| serviceName: 'synth-java', | ||
| start, | ||
| end, | ||
| isLegacy: false, | ||
| synthtrace: apmSynthtraceEsClient, | ||
| }); | ||
| }); | ||
|
|
||
| after(() => { | ||
| return apmSynthtraceEsClient.clean(); | ||
| }); | ||
|
|
||
| it('ingests transaction metrics with transaction.duration.summary', async () => { | ||
| const res = await es.search({ | ||
| index: 'metrics-apm*', | ||
| body: { | ||
| query: { | ||
| bool: { | ||
| filter: [ | ||
| { exists: { field: TRANSACTION_DURATION_HISTOGRAM } }, | ||
| { exists: { field: TRANSACTION_DURATION_SUMMARY } }, | ||
| ], | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| // @ts-expect-error | ||
| expect(res.hits.total.value).to.be(20); | ||
| }); | ||
|
|
||
| it('ingests transaction metrics without transaction.duration.summary', async () => { | ||
| const res = await es.search({ | ||
| index: 'metrics-apm*', | ||
| body: { | ||
| query: { | ||
| bool: { | ||
| filter: [{ exists: { field: TRANSACTION_DURATION_HISTOGRAM } }], | ||
| must_not: [{ exists: { field: TRANSACTION_DURATION_SUMMARY } }], | ||
| }, | ||
| }, | ||
| }, | ||
| }); | ||
|
Comment on lines
+80
to
+90
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here: if it is part of env setup and not the actual APM functionality test I suggest moving both calls to
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. same here |
||
|
|
||
| // @ts-expect-error | ||
| expect(res.hits.total.value).to.be(10); | ||
| }); | ||
|
|
||
| it('has transaction.duration.summary field for every document type', async () => { | ||
| const response = await apmApiClient.readUser({ | ||
| endpoint: 'GET /internal/apm/time_range_metadata', | ||
| params: { | ||
| query: { | ||
| start: endLegacy.toISOString(), | ||
| end: end.toISOString(), | ||
| enableContinuousRollups: true, | ||
| enableServiceTransactionMetrics: true, | ||
| useSpanName: false, | ||
| kuery: '', | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const allHasSummaryField = response.body.sources | ||
| .filter( | ||
| (source) => | ||
| source.documentType !== ApmDocumentType.TransactionEvent && | ||
| source.rollupInterval !== RollupInterval.SixtyMinutes // there is not enough data for 60 minutes | ||
| ) | ||
| .every((source) => { | ||
| return source.hasDurationSummaryField; | ||
| }); | ||
|
|
||
| expect(allHasSummaryField).to.eql(true); | ||
| }); | ||
|
|
||
| it('does not support transaction.duration.summary when the field is not supported by all APM server versions', async () => { | ||
| const response = await apmApiClient.readUser({ | ||
| endpoint: 'GET /internal/apm/time_range_metadata', | ||
| params: { | ||
| query: { | ||
| start: startLegacy.toISOString(), | ||
| end: endLegacy.toISOString(), | ||
| enableContinuousRollups: true, | ||
| enableServiceTransactionMetrics: true, | ||
| useSpanName: false, | ||
| kuery: '', | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const allHasSummaryField = response.body.sources.every((source) => { | ||
| return source.hasDurationSummaryField; | ||
| }); | ||
|
|
||
| expect(allHasSummaryField).to.eql(false); | ||
| }); | ||
|
|
||
| it('does not support transaction.duration.summary for transactionMetric 1m when not all documents within the range support it ', async () => { | ||
| const response = await apmApiClient.readUser({ | ||
| endpoint: 'GET /internal/apm/time_range_metadata', | ||
| params: { | ||
| query: { | ||
| start: startLegacy.toISOString(), | ||
| end: end.toISOString(), | ||
| enableContinuousRollups: true, | ||
| enableServiceTransactionMetrics: true, | ||
| useSpanName: false, | ||
| kuery: '', | ||
| }, | ||
| }, | ||
| }); | ||
|
|
||
| const hasDurationSummaryField = response.body.sources.find( | ||
| (source) => | ||
| source.documentType === ApmDocumentType.TransactionMetric && | ||
| source.rollupInterval === RollupInterval.OneMinute // there is not enough data for 60 minutes in the timerange defined for the tests | ||
| )?.hasDurationSummaryField; | ||
|
|
||
| expect(hasDurationSummaryField).to.eql(false); | ||
| }); | ||
|
|
||
| it('does not have latency data for synth-java-legacy', async () => { | ||
| const res = await getLatencyChartForService({ | ||
| serviceName: 'synth-java-legacy', | ||
| start, | ||
| end: endLegacy, | ||
| apmApiClient, | ||
| useDurationSummary: true, | ||
| }); | ||
|
|
||
| expect(res.body.currentPeriod.latencyTimeseries.map(({ y }) => y)).to.eql([ | ||
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| null, | ||
| ]); | ||
| }); | ||
|
|
||
| it('has latency data for synth-java service', async () => { | ||
| const res = await getLatencyChartForService({ | ||
| serviceName: 'synth-java', | ||
| start, | ||
| end: endLegacy, | ||
| apmApiClient, | ||
| useDurationSummary: true, | ||
| }); | ||
|
|
||
| expect(res.body.currentPeriod.latencyTimeseries.map(({ y }) => y)).to.eql([ | ||
| 1000000, 1000000, 1000000, 1000000, 1000000, 1000000, | ||
| ]); | ||
| }); | ||
| }); | ||
| }); | ||
| } | ||
|
|
||
| // This will retrieve latency data expecting the `transaction.duration.summary` field to be present | ||
| function getLatencyChartForService({ | ||
| serviceName, | ||
| start, | ||
| end, | ||
| apmApiClient, | ||
| useDurationSummary, | ||
| }: { | ||
| serviceName: string; | ||
| start: moment.Moment; | ||
| end: moment.Moment; | ||
| apmApiClient: ApmApiClient; | ||
| useDurationSummary: boolean; | ||
| }) { | ||
| return apmApiClient.readUser({ | ||
| endpoint: `GET /internal/apm/services/{serviceName}/transactions/charts/latency`, | ||
| params: { | ||
| path: { serviceName }, | ||
| query: { | ||
| start: start.toISOString(), | ||
| end: end.toISOString(), | ||
| environment: 'production', | ||
| latencyAggregationType: LatencyAggregationType.avg, | ||
| transactionType: 'request', | ||
| kuery: '', | ||
| documentType: ApmDocumentType.TransactionMetric, | ||
| rollupInterval: RollupInterval.OneMinute, | ||
| bucketSizeInSeconds: 60, | ||
| useDurationSummary, | ||
| }, | ||
| }, | ||
| }); | ||
| } | ||
|
|
||
| function generateTraceDataForService({ | ||
| serviceName, | ||
| start, | ||
| end, | ||
| isLegacy, | ||
| synthtrace, | ||
| }: { | ||
| serviceName: string; | ||
| start: moment.Moment; | ||
| end: moment.Moment; | ||
| isLegacy?: boolean; | ||
| synthtrace: ApmSynthtraceEsClient; | ||
| }) { | ||
| const instance = apm | ||
| .service({ | ||
| name: serviceName, | ||
| environment: 'production', | ||
| agentName: 'java', | ||
| }) | ||
| .instance(`instance`); | ||
|
|
||
| const events = timerange(start, end) | ||
| .ratePerMinute(6) | ||
| .generator((timestamp) => | ||
| instance | ||
| .transaction({ transactionName: 'GET /order/{id}' }) | ||
| .timestamp(timestamp) | ||
| .duration(1000) | ||
| .success() | ||
| ); | ||
|
|
||
| const apmPipeline = (base: Readable) => { | ||
| return synthtrace.getDefaultPipeline({ versionOverride: '8.5.0' })(base); | ||
| }; | ||
|
|
||
| return synthtrace.index(events, isLegacy ? apmPipeline : undefined); | ||
| } | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI: currently we init ES client with
operatoruser as we use it to cleanup MKI projects. There is no way to change authentication foresservice, so if your test target validation from end-user perspective you need to make a change and probably use a new ES client instance with API key authentication (I didn't see it in tests before, but I assume it should work)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for sharing that. This validation here is just ensuring
eshas ingested the necessary data to proceed with the tests