Skip to content

[Discover] mailto links in data view urls#200070

Merged
ghudgins merged 1 commit intoelastic:mainfrom
ghudgins:179773/mailto-papercut
Nov 14, 2024
Merged

[Discover] mailto links in data view urls#200070
ghudgins merged 1 commit intoelastic:mainfrom
ghudgins:179773/mailto-papercut

Conversation

@ghudgins
Copy link
Copy Markdown
Contributor

@ghudgins ghudgins commented Nov 13, 2024 •
edited
Loading

Summary

Adds mailto: as an allowed URL Url formatters in data views.

Resolves papercut: #179773

Example:

image

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@ghudgins ghudgins requested a review from a team as a code owner November 13, 2024 18:48
@ghudgins ghudgins added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Nov 13, 2024
@ghudgins ghudgins force-pushed the 179773/mailto-papercut branch from 3d84303 to 93c1844 Compare November 13, 2024 19:06
@ghudgins ghudgins changed the title [Dashboard] mailto links from url drilldowns [Dashboard][Discover] mailto links from url drilldowns & data views Nov 13, 2024
@ghudgins ghudgins changed the title [Dashboard][Discover] mailto links from url drilldowns & data views [Discover] mailto links in data view urls Nov 13, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 13, 2024

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
fieldFormats 63.1KB 63.1KB +10.0B

@ghudgins ghudgins enabled auto-merge (squash) November 13, 2024 21:56
@kertal kertal added the Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// label Nov 14, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 14, 2024

Pinging @elastic/kibana-data-discovery (Team:DataDiscovery)

akowalska622
akowalska622 approved these changes Nov 14, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@akowalska622 akowalska622 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, great to see corresponding test included! 🎉

@ghudgins ghudgins merged commit d7a913f into elastic:main Nov 14, 2024
@ghudgins ghudgins deleted the 179773/mailto-papercut branch November 14, 2024 14:17
@ghudgins ghudgins mentioned this pull request Nov 14, 2024
Closed
@kertal
Copy link
Copy Markdown
Member

kertal commented Nov 14, 2024

@ghudgins you just want this for 9.0?

@ghudgins
Copy link
Copy Markdown
Contributor Author

ghudgins commented Nov 14, 2024

ah, didn't realize skipping backporting would only do 9.0. yes, would be nice to have in 8.17 if possible. can wait otherwise

@ghudgins ghudgins mentioned this pull request Nov 14, 2024
Merged
@ghudgins
Copy link
Copy Markdown
Contributor Author

ghudgins commented Nov 14, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

ghudgins added a commit to ghudgins/kibana that referenced this pull request Nov 14, 2024
@ghudgins
[Discover] mailto links in data view urls (elastic#200070)
a0ab04a 
Adds `mailto:` as an allowed URL Url formatters in data views.

(cherry picked from commit d7a913f)
@kibanamachine kibanamachine mentioned this pull request Nov 18, 2024
Merged
11 tasks
ghudgins added a commit that referenced this pull request Nov 18, 2024
@ghudgins @kertal
[8.x] [Discover] mailto links in data view urls (#200070) (#200220)
5cae0bf 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Discover] mailto links in data view urls
(#200070)](#200070)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Graham
Hudgins","email":"graham@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T13:30:10Z","message":"[Discover]
mailto links in data view urls (#200070)\n\nAdds `mailto:` as an allowed
URL Url formatters in data
views.","sha":"d7a913f183cfe35efe7f42bb2d46990abc07296d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","backport:skip","v9.0.0","Team:DataDiscovery"],"number":200070,"url":"https://github.com/elastic/kibana/pull/200070","mergeCommit":{"message":"[Discover]
mailto links in data view urls (#200070)\n\nAdds `mailto:` as an allowed
URL Url formatters in data
views.","sha":"d7a913f183cfe35efe7f42bb2d46990abc07296d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/200070","number":200070,"mergeCommit":{"message":"[Discover]
mailto links in data view urls (#200070)\n\nAdds `mailto:` as an allowed
URL Url formatters in data
views.","sha":"d7a913f183cfe35efe7f42bb2d46990abc07296d"}}]}]
BACKPORT-->

Co-authored-by: Matthias Wilhelm <matthias.wilhelm@elastic.co>
wayneseymour pushed a commit to wayneseymour/kibana that referenced this pull request Nov 18, 2024
@ghudgins @wayneseymour
[Discover] mailto links in data view urls (elastic#200070)
62e9fe7 
Adds `mailto:` as an allowed URL Url formatters in data views.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@ghudgins @CAWilson94
[Discover] mailto links in data view urls (elastic#200070)
c00afe0 
Adds `mailto:` as an allowed URL Url formatters in data views.
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@ghudgins @CAWilson94
[Discover] mailto links in data view urls (elastic#200070)
4d44854 
Adds `mailto:` as an allowed URL Url formatters in data views.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@akowalska622 akowalska622 akowalska622 approved these changes

Assignees

@ghudgins ghudgins

Labels

backport:skip This PR does not require backporting release_note:skip Skip the PR/issue when compiling release notes Team:DataDiscovery Discover, search (data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. t// v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@ghudgins @elasticmachine @kertal @akowalska622 @kibanamachine