[Securitysolution] Add Risk score missing privileges callout to enablement flyout#199804
Merged
machadoum merged 5 commits intoelastic:mainfrom Nov 14, 2024
Merged
[Securitysolution] Add Risk score missing privileges callout to enablement flyout#199804machadoum merged 5 commits intoelastic:mainfrom
machadoum merged 5 commits intoelastic:mainfrom
Conversation
machadoum
added
Team: SecuritySolution
Contributor
|
Pinging @elastic/security-solution (Team: SecuritySolution) |
Contributor
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
hop-dev
approved these changes
Nov 13, 2024
Contributor
hop-dev
left a comment
hop-dev
left a comment
There was a problem hiding this comment.
Tested locally, the UI is looking a bit busy when thre user doesnt have any privileges but I dont think we can get around that.
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @machadoum |
Contributor
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11833605420 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 14, 2024
…ement flyout (elastic#199804) ## Summary The entity analytics enablement model doesn't show the missing privileges warning for the Entity Risk score. To fix it, I added to the model the same callout we display on the risk engine page. ### What is not included * Improvement to the risk engine callout * Fix risk engine callout bugs elastic/security-team#11138 ### How to test it * Create a user with no privileges except to the security solution app and the `logs*` index * Login and open the entity analytics page with the non-privileged user * Click enable and check if the model displays the missing privileges callout for the risk engine ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 54c6144)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 14, 2024
… enablement flyout (#199804) (#200123) # Backport This will backport the following commits from `main` to `8.x`: - [[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)](#199804) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T08:40:27Z","message":"[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)\n\n## Summary\r\n\r\nThe entity analytics enablement model doesn't show the missing\r\nprivileges warning for the Entity Risk score.\r\n\r\nTo fix it, I added to the model the same callout we display on the risk\r\nengine page.\r\n\r\n### What is not included\r\n* Improvement to the risk engine callout\r\n* Fix risk engine callout bugs\r\nhttps://github.com/elastic/security-team/issues/11138\r\n\r\n### How to test it\r\n* Create a user with no privileges except to the security solution app\r\nand the `logs*` index\r\n* Login and open the entity analytics page with the non-privileged user\r\n* Click enable and check if the model displays the missing privileges\r\ncallout for the risk engine\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54c6144bbc9e041dad5c2fd9f296ea7d838cc614","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","backport:version","v8.17.0","v8.16.1"],"title":"[Securitysolution] Add Risk score missing privileges callout to enablement flyout","number":199804,"url":"https://github.com/elastic/kibana/pull/199804","mergeCommit":{"message":"[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)\n\n## Summary\r\n\r\nThe entity analytics enablement model doesn't show the missing\r\nprivileges warning for the Entity Risk score.\r\n\r\nTo fix it, I added to the model the same callout we display on the risk\r\nengine page.\r\n\r\n### What is not included\r\n* Improvement to the risk engine callout\r\n* Fix risk engine callout bugs\r\nhttps://github.com/elastic/security-team/issues/11138\r\n\r\n### How to test it\r\n* Create a user with no privileges except to the security solution app\r\nand the `logs*` index\r\n* Login and open the entity analytics page with the non-privileged user\r\n* Click enable and check if the model displays the missing privileges\r\ncallout for the risk engine\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54c6144bbc9e041dad5c2fd9f296ea7d838cc614"}},"sourceBranch":"main","suggestedTargetBranches":["8.x","8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199804","number":199804,"mergeCommit":{"message":"[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)\n\n## Summary\r\n\r\nThe entity analytics enablement model doesn't show the missing\r\nprivileges warning for the Entity Risk score.\r\n\r\nTo fix it, I added to the model the same callout we display on the risk\r\nengine page.\r\n\r\n### What is not included\r\n* Improvement to the risk engine callout\r\n* Fix risk engine callout bugs\r\nhttps://github.com/elastic/security-team/issues/11138\r\n\r\n### How to test it\r\n* Create a user with no privileges except to the security solution app\r\nand the `logs*` index\r\n* Login and open the entity analytics page with the non-privileged user\r\n* Click enable and check if the model displays the missing privileges\r\ncallout for the risk engine\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54c6144bbc9e041dad5c2fd9f296ea7d838cc614"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>
machadoum
added a commit
to machadoum/kibana
that referenced
this pull request
Nov 18, 2024
…ement flyout (elastic#199804) ## Summary The entity analytics enablement model doesn't show the missing privileges warning for the Entity Risk score. To fix it, I added to the model the same callout we display on the risk engine page. ### What is not included * Improvement to the risk engine callout * Fix risk engine callout bugs elastic/security-team#11138 ### How to test it * Create a user with no privileges except to the security solution app and the `logs*` index * Login and open the entity analytics page with the non-privileged user * Click enable and check if the model displays the missing privileges callout for the risk engine ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios (cherry picked from commit 54c6144) # Conflicts: # x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.test.tsx # x-pack/plugins/security_solution/public/entity_analytics/components/entity_store/components/enablement_modal.tsx
Member
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…ement flyout (elastic#199804) ## Summary The entity analytics enablement model doesn't show the missing privileges warning for the Entity Risk score. To fix it, I added to the model the same callout we display on the risk engine page. ### What is not included * Improvement to the risk engine callout * Fix risk engine callout bugs elastic/security-team#11138 ### How to test it * Create a user with no privileges except to the security solution app and the `logs*` index * Login and open the entity analytics page with the non-privileged user * Click enable and check if the model displays the missing privileges callout for the risk engine ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
machadoum
added a commit
that referenced
this pull request
Nov 18, 2024
…o enablement flyout (#199804) (#200506) # Backport This will backport the following commits from `main` to `8.16`: - [[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)](#199804) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Pablo Machado","email":"pablo.nevesmachado@elastic.co"},"sourceCommit":{"committedDate":"2024-11-14T08:40:27Z","message":"[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)\n\n## Summary\r\n\r\nThe entity analytics enablement model doesn't show the missing\r\nprivileges warning for the Entity Risk score.\r\n\r\nTo fix it, I added to the model the same callout we display on the risk\r\nengine page.\r\n\r\n### What is not included\r\n* Improvement to the risk engine callout\r\n* Fix risk engine callout bugs\r\nhttps://github.com/elastic/security-team/issues/11138\r\n\r\n### How to test it\r\n* Create a user with no privileges except to the security solution app\r\nand the `logs*` index\r\n* Login and open the entity analytics page with the non-privileged user\r\n* Click enable and check if the model displays the missing privileges\r\ncallout for the risk engine\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54c6144bbc9e041dad5c2fd9f296ea7d838cc614","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team: SecuritySolution","Theme: entity_analytics","Feature:Entity Analytics","Team:Entity Analytics","backport:version","v8.17.0","v8.16.1"],"number":199804,"url":"https://github.com/elastic/kibana/pull/199804","mergeCommit":{"message":"[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)\n\n## Summary\r\n\r\nThe entity analytics enablement model doesn't show the missing\r\nprivileges warning for the Entity Risk score.\r\n\r\nTo fix it, I added to the model the same callout we display on the risk\r\nengine page.\r\n\r\n### What is not included\r\n* Improvement to the risk engine callout\r\n* Fix risk engine callout bugs\r\nhttps://github.com/elastic/security-team/issues/11138\r\n\r\n### How to test it\r\n* Create a user with no privileges except to the security solution app\r\nand the `logs*` index\r\n* Login and open the entity analytics page with the non-privileged user\r\n* Click enable and check if the model displays the missing privileges\r\ncallout for the risk engine\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54c6144bbc9e041dad5c2fd9f296ea7d838cc614"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199804","number":199804,"mergeCommit":{"message":"[Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804)\n\n## Summary\r\n\r\nThe entity analytics enablement model doesn't show the missing\r\nprivileges warning for the Entity Risk score.\r\n\r\nTo fix it, I added to the model the same callout we display on the risk\r\nengine page.\r\n\r\n### What is not included\r\n* Improvement to the risk engine callout\r\n* Fix risk engine callout bugs\r\nhttps://github.com/elastic/security-team/issues/11138\r\n\r\n### How to test it\r\n* Create a user with no privileges except to the security solution app\r\nand the `logs*` index\r\n* Login and open the entity analytics page with the non-privileged user\r\n* Click enable and check if the model displays the missing privileges\r\ncallout for the risk engine\r\n\r\n### Checklist\r\n\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios","sha":"54c6144bbc9e041dad5c2fd9f296ea7d838cc614"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/200123","number":200123,"state":"MERGED","mergeCommit":{"sha":"6e7d4362ac3e661f061c852c587ba95ebbc565b2","message":"[8.x] [Securitysolution] Add Risk score missing privileges callout to enablement flyout (#199804) (#200123)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Securitysolution] Add Risk score missing privileges callout to\nenablement flyout\n(#199804)](https://github.com/elastic/kibana/pull/199804)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Pablo\nMachado\",\"email\":\"pablo.nevesmachado@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-11-14T08:40:27Z\",\"message\":\"[Securitysolution]\nAdd Risk score missing privileges callout to enablement flyout\n(#199804)\\n\\n## Summary\\r\\n\\r\\nThe entity analytics enablement model\ndoesn't show the missing\\r\\nprivileges warning for the Entity Risk\nscore.\\r\\n\\r\\nTo fix it, I added to the model the same callout we\ndisplay on the risk\\r\\nengine page.\\r\\n\\r\\n### What is not included\\r\\n*\nImprovement to the risk engine callout\\r\\n* Fix risk engine callout\nbugs\\r\\nhttps://github.com/elastic/security-team/issues/11138\\r\\n\\r\\n###\nHow to test it\\r\\n* Create a user with no privileges except to the\nsecurity solution app\\r\\nand the `logs*` index\\r\\n* Login and open the\nentity analytics page with the non-privileged user\\r\\n* Click enable and\ncheck if the model displays the missing privileges\\r\\ncallout for the\nrisk engine\\r\\n\\r\\n### Checklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"54c6144bbc9e041dad5c2fd9f296ea7d838cc614\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"Team:\nSecuritySolution\",\"Theme: entity_analytics\",\"Feature:Entity\nAnalytics\",\"Team:Entity\nAnalytics\",\"backport:version\",\"v8.17.0\",\"v8.16.1\"],\"title\":\"[Securitysolution]\nAdd Risk score missing privileges callout to enablement\nflyout\",\"number\":199804,\"url\":\"https://github.com/elastic/kibana/pull/199804\",\"mergeCommit\":{\"message\":\"[Securitysolution]\nAdd Risk score missing privileges callout to enablement flyout\n(#199804)\\n\\n## Summary\\r\\n\\r\\nThe entity analytics enablement model\ndoesn't show the missing\\r\\nprivileges warning for the Entity Risk\nscore.\\r\\n\\r\\nTo fix it, I added to the model the same callout we\ndisplay on the risk\\r\\nengine page.\\r\\n\\r\\n### What is not included\\r\\n*\nImprovement to the risk engine callout\\r\\n* Fix risk engine callout\nbugs\\r\\nhttps://github.com/elastic/security-team/issues/11138\\r\\n\\r\\n###\nHow to test it\\r\\n* Create a user with no privileges except to the\nsecurity solution app\\r\\nand the `logs*` index\\r\\n* Login and open the\nentity analytics page with the non-privileged user\\r\\n* Click enable and\ncheck if the model displays the missing privileges\\r\\ncallout for the\nrisk engine\\r\\n\\r\\n### Checklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"54c6144bbc9e041dad5c2fd9f296ea7d838cc614\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.x\",\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/199804\",\"number\":199804,\"mergeCommit\":{\"message\":\"[Securitysolution]\nAdd Risk score missing privileges callout to enablement flyout\n(#199804)\\n\\n## Summary\\r\\n\\r\\nThe entity analytics enablement model\ndoesn't show the missing\\r\\nprivileges warning for the Entity Risk\nscore.\\r\\n\\r\\nTo fix it, I added to the model the same callout we\ndisplay on the risk\\r\\nengine page.\\r\\n\\r\\n### What is not included\\r\\n*\nImprovement to the risk engine callout\\r\\n* Fix risk engine callout\nbugs\\r\\nhttps://github.com/elastic/security-team/issues/11138\\r\\n\\r\\n###\nHow to test it\\r\\n* Create a user with no privileges except to the\nsecurity solution app\\r\\nand the `logs*` index\\r\\n* Login and open the\nentity analytics page with the non-privileged user\\r\\n* Click enable and\ncheck if the model displays the missing privileges\\r\\ncallout for the\nrisk engine\\r\\n\\r\\n### Checklist\\r\\n\\r\\n- [x] [Unit or\nfunctional\\r\\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\\r\\nwere\nupdated or added to match the most common\nscenarios\",\"sha\":\"54c6144bbc9e041dad5c2fd9f296ea7d838cc614\"}},{\"branch\":\"8.x\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v8.17.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.16\",\"label\":\"v8.16.1\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Pablo Machado <pablo.nevesmachado@elastic.co>"}},{"branch":"8.16","label":"v8.16.1","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 18, 2024
…ement flyout (elastic#199804) ## Summary The entity analytics enablement model doesn't show the missing privileges warning for the Entity Risk score. To fix it, I added to the model the same callout we display on the risk engine page. ### What is not included * Improvement to the risk engine callout * Fix risk engine callout bugs elastic/security-team#11138 ### How to test it * Create a user with no privileges except to the security solution app and the `logs*` index * Login and open the entity analytics page with the non-privileged user * Click enable and check if the model displays the missing privileges callout for the risk engine ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The entity analytics enablement model doesn't show the missing privileges warning for the Entity Risk score.
To fix it, I added to the model the same callout we display on the risk engine page.
What is not included
How to test it
logs*indexChecklist