[Ownership] Assign test files to platform security team#199795
[Ownership] Assign test files to platform security team#199795wayneseymour merged 16 commits intomainfrom
Conversation
wayneseymour
added
release_note:skip
jeramysoucy
left a comment
jeramysoucy
left a comment
There was a problem hiding this comment.
Mostly ok with these. Just going to contest a few of them.
.github/CODEOWNERS
Outdated
| /test/server_integration/services/supertest.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 | ||
| /test/server_integration/http/ssl @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 | ||
| /test/server_integration/config.base.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 | ||
| /test/server_integration/__fixtures__ @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/53810 |
There was a problem hiding this comment.
Looks like most of these were introduced by @elastic/kibana-core in #19261. That said, there is certainly some overlap with our team. I think we'd be ok will owing or having joint ownership of some of these (ssl folders & fixtures folder to be specific), but we should check with core first.
There was a problem hiding this comment.
@elastic/kibana-core can someone weigh in here pretty please?
There was a problem hiding this comment.
Asked in slack
There was a problem hiding this comment.
yeah I think on the whole security would be a better reviewer if we do ever change anything SSL related so it'd make sense to me for them to own it.
Core could be a co-owner of /test/server_integration/config.base.js and I think it makes the most sense for us to own test/server_integration/http/ssl_redirect/index.ts
I think security should also own the other ssl* folders like ssl_with_p12 and ssl_with_p12_intermediate
There was a problem hiding this comment.
I think security should also own the other ssl* folders like ssl_with_p12 and ssl_with_p12_intermediate
++
|
@elasticmachine merge upstream |
…into assign-platform-security
jeramysoucy
left a comment
jeramysoucy
left a comment
There was a problem hiding this comment.
Thanks for your patience! Two more requested changes, but otherwise I think we're good.
.github/CODEOWNERS
Outdated
|
|
||
| # Kibana Platform Security | ||
| # security | ||
| /test/api_integration/apis/general/*.js @elastic/kibana-security # Assigned per https://github.com/elastic/kibana/pull/199767#discussion_r1840492130 |
There was a problem hiding this comment.
I check with the team, and we believe this one belongs to @elastic/kibana-core
Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
…into assign-platform-security
💚 Build Succeeded
Metrics [docs]
History
|
## Summary Assign test files to platform security team Contributes to: elastic#192979 --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
## Summary Assign test files to platform security team Contributes to: elastic#192979 --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> Co-authored-by: Jeramy Soucy <jeramy.soucy@elastic.co>
5 participants
Summary
Assign test files to platform security team
Contributes to: #192979