[Entity Analytics] API changes for right placement of deleting the old component template by abhishekbhatia1710 · Pull Request #199734 · elastic/kibana

abhishekbhatia1710 · 2024-11-12T09:00:40Z

Summary

Delete the old component template after the index template has referenced to the new component template
Test cases for the same flow

# Let's assume this is 8.15.3
# Create the component template when Risk Score engine is initialised
# Create the index template which references the created component template

PUT /_component_template/.risk-score-mappings
{
  "template": {
    "settings": {
      "number_of_shards": 1
    },
    "mappings": {
      "properties": {
        "timestamp": {
          "type": "date"
        },
        "user": {
          "properties": {
            "id": {
              "type": "keyword"
            },
            "name": {
              "type": "text"
            }
          }
        }
      }
    }
  },
  "version": 1
}

PUT /_index_template/.risk-score.risk-score-default-index-template
{
  "index_patterns": [".risk-score.risk-score-default-index-template"],
  "template": {
    "settings": {
      "number_of_replicas": 1
    }
  },
  "composed_of": [".risk-score-mappings"],
  "priority": 100,
  "version": 1,
  "_meta": {
    "description": "Index template for indices with the pattern my_index-*"
  }
}

# The deployment is updated to 8.16
# User tries to enable the Entity store which init's the Risk Score engine (again!!) 
# Fails, but creates the component template and cannot update the index template to reference the new component template due to the error

PUT /_component_template/.risk-score-mappings-default
{
  "template": {
    "settings": {
      "number_of_shards": 1
    },
    "mappings": {
      "properties": {
        "timestamp": {
          "type": "date"
        },
        "user": {
          "properties": {
            "id": {
              "type": "keyword"
            },
            "name": {
              "type": "text"
            }
          }
        }
      }
    }
  },
  "version": 1
}

GET /_component_template?filter_path=component_templates.name&name=.risk-score-mappings*


DELETE /_component_template/.risk-score-mappings

# Fails 

# changed flow
PUT /_index_template/.risk-score.risk-score-default-index-template
{
  "index_patterns": [".risk-score.risk-score-default-index-template"],
  "template": {
    "settings": {
      "number_of_replicas": 1
    }
  },
  "composed_of": [".risk-score-mappings-default"],
  "priority": 100,
  "version": 1,
  "_meta": {
    "description": "Index template for indices with the pattern my_index-*"
  }
}

DELETE /_component_template/.risk-score-mappings

# Succeeds

#########

Checklist

Delete any items that are not applicable to this PR.

Unit or functional tests were updated or added to match the most common scenarios
Flaky Test Runner was used on any tests changed

For maintainers

This was checked for breaking API changes and was labeled appropriately
This will appear in the Release Notes and follow the guidelines

elasticmachine · 2024-11-12T09:00:42Z

Pinging @elastic/security-entity-analytics (Team:Entity Analytics)

abhishekbhatia1710 · 2024-11-12T09:07:23Z

Question:

Should we really modify the UI modal to avoid calling the init Risk Engine API if it's already initialised?

In my opinion, the init Risk Score Engine API updates the component and index templates as needed, ensuring they remain updated with the correct space name in any flow (upgrade or standard)

@jaredburgettelastic @hop-dev

...test_suites/entity_analytics/risk_engine/trial_license_complete_tier/init_and_status_apis.ts

machadoum · 2024-11-14T09:43:59Z

@abhishekbhatia1710 This PR looks good to me. But let's address your suggestion.

Should we really modify the UI modal to avoid calling the init Risk Engine API if it's already initialised?

I agree 100% with this. But I thought we already had this check in place.
@tiansivive Is moving the enablement to BE. So we should make sure it is disabled before calling init.

...k/plugins/security_solution/server/lib/entity_analytics/risk_score/risk_score_data_client.ts

…e deletion of component template a little above than before

machadoum

The code LGTM!

I don't have time today to desk test it.

Are you going to address this comment before merging the PR?
#199734 (comment)

abhishekbhatia1710 · 2024-11-18T13:48:15Z

The code LGTM!
I don't have time today to desk test it.
Are you going to address this comment before merging the PR?
#199734 (comment)

No, this scenario is already handled. Joe mentioned it in his comment (https://elastic.slack.com/archives/C05V9NE6X4K/p1731615750750869). The toggle button is disabled if the risk engine is already installed, preventing the user from enabling it through the UI.

kibanamachine · 2024-11-18T15:07:31Z

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11895247426

elasticmachine · 2024-11-18T15:08:10Z

💚 Build Succeeded

Buildkite Build
Commit: 778782d

Metrics [docs]

✅ unchanged

History

💛 Build #250198 was flaky 913f92c

cc @abhishekbhatia1710

kibanamachine · 2024-11-18T15:12:47Z

💔 All backports failed

Status	Branch	Result
❌	8.16	Backport failed because of merge conflicts
❌	8.x	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 199734

Questions ?

Please refer to the Backport tool documentation

abhishekbhatia1710 · 2024-11-18T15:38:08Z

💔 Some backports could not be created

Status	Branch	Result
❌	8.x	An unhandled error occurred. Please see the logs for details
✅	8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 199734

Questions ?

Please refer to the Backport tool documentation

…d component template (elastic#199734) ## Summary - Delete the old component template after the index template has referenced to the new component template - Test cases for the same flow ```JSON # Let's assume this is 8.15.3 # Create the component template when Risk Score engine is initialised # Create the index template which references the created component template PUT /_component_template/.risk-score-mappings { "template": { "settings": { "number_of_shards": 1 }, "mappings": { "properties": { "timestamp": { "type": "date" }, "user": { "properties": { "id": { "type": "keyword" }, "name": { "type": "text" } } } } } }, "version": 1 } PUT /_index_template/.risk-score.risk-score-default-index-template { "index_patterns": [".risk-score.risk-score-default-index-template"], "template": { "settings": { "number_of_replicas": 1 } }, "composed_of": [".risk-score-mappings"], "priority": 100, "version": 1, "_meta": { "description": "Index template for indices with the pattern my_index-*" } } # The deployment is updated to 8.16 # User tries to enable the Entity store which init's the Risk Score engine (again!!) # Fails, but creates the component template and cannot update the index template to reference the new component template due to the error PUT /_component_template/.risk-score-mappings-default { "template": { "settings": { "number_of_shards": 1 }, "mappings": { "properties": { "timestamp": { "type": "date" }, "user": { "properties": { "id": { "type": "keyword" }, "name": { "type": "text" } } } } } }, "version": 1 } GET /_component_template?filter_path=component_templates.name&name=.risk-score-mappings* DELETE /_component_template/.risk-score-mappings # Fails # changed flow PUT /_index_template/.risk-score.risk-score-default-index-template { "index_patterns": [".risk-score.risk-score-default-index-template"], "template": { "settings": { "number_of_replicas": 1 } }, "composed_of": [".risk-score-mappings-default"], "priority": 100, "version": 1, "_meta": { "description": "Index template for indices with the pattern my_index-*" } } DELETE /_component_template/.risk-score-mappings # Succeeds ######### ``` ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

… the old component template (#199734) (#200591) # Backport This will backport the following commits from `main` to `8.16`: - [[Entity Analytics] API changes for right placement of deleting the old component template (#199734)](#199734)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)

abhishekbhatia1710 · 2024-11-19T07:12:19Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…d component template (elastic#199734) ## Summary - Delete the old component template after the index template has referenced to the new component template - Test cases for the same flow ```JSON # Let's assume this is 8.15.3 # Create the component template when Risk Score engine is initialised # Create the index template which references the created component template PUT /_component_template/.risk-score-mappings { "template": { "settings": { "number_of_shards": 1 }, "mappings": { "properties": { "timestamp": { "type": "date" }, "user": { "properties": { "id": { "type": "keyword" }, "name": { "type": "text" } } } } } }, "version": 1 } PUT /_index_template/.risk-score.risk-score-default-index-template { "index_patterns": [".risk-score.risk-score-default-index-template"], "template": { "settings": { "number_of_replicas": 1 } }, "composed_of": [".risk-score-mappings"], "priority": 100, "version": 1, "_meta": { "description": "Index template for indices with the pattern my_index-*" } } # The deployment is updated to 8.16 # User tries to enable the Entity store which init's the Risk Score engine (again!!) # Fails, but creates the component template and cannot update the index template to reference the new component template due to the error PUT /_component_template/.risk-score-mappings-default { "template": { "settings": { "number_of_shards": 1 }, "mappings": { "properties": { "timestamp": { "type": "date" }, "user": { "properties": { "id": { "type": "keyword" }, "name": { "type": "text" } } } } } }, "version": 1 } GET /_component_template?filter_path=component_templates.name&name=.risk-score-mappings* DELETE /_component_template/.risk-score-mappings # Fails # changed flow PUT /_index_template/.risk-score.risk-score-default-index-template { "index_patterns": [".risk-score.risk-score-default-index-template"], "template": { "settings": { "number_of_replicas": 1 } }, "composed_of": [".risk-score-mappings-default"], "priority": 100, "version": 1, "_meta": { "description": "Index template for indices with the pattern my_index-*" } } DELETE /_component_template/.risk-score-mappings # Succeeds ######### ``` ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 771c139) # Conflicts: # x-pack/plugins/security_solution/server/lib/entity_analytics/risk_score/risk_score_data_client.ts # x-pack/test/security_solution_api_integration/test_suites/entity_analytics/risk_engine/trial_license_complete_tier/init_and_status_apis.ts

muskangulati-qasource · 2024-11-20T10:40:26Z

Hi @abhishekbhatia1710 ,

We have tested this ticket on the latest 8.16.1 BC2 and below are our observations for the same.

Please find below the testing details:

Build details

VERSION: 8.16.1
BUILD: 79724
COMMIT: c8b46e87c4d61de4fe046ce5ea0a0b68aad5acf9

Screen Recordings

Entity risk score and entity store are successfully enabled without any errors

1.mp4

Entity store is enabled from the dashboards without any errors

2.mp4

The 'enable' button is enabled even when nothing is selected to be enabled

3.mp4

Please let us know if anything is missing from our end.

cc: @MadameSheema
Thanks!!

abhishekbhatia1710 · 2024-11-20T10:50:33Z

Thanks, @muskangulati-qasource for testing this feature out and it seems to be fine.

As discussed in our Slack thread, this appears to follow the "standard" flow where the build is freshly created with version 8.16.1.

Another scenario to consider is when a user upgrades to 8.16.1 from any of the earlier 8.15.x versions.

It would be a good idea to test that flow as well. Thanks!

muskangulati-qasource · 2024-11-20T11:37:48Z

Hi @abhishekbhatia1710,

Thank you for sharing the details. Please find below the testing details for upgrade testing performed:

Build details

8.15.3:

VERSION: 8.15.3
BUILD: 76711
COMMIT: 3933429968aafb1ba31319fc38649d0f974044bf

8.16.1:

VERSION: 8.16.1
BUILD: 79724
COMMIT: c8b46e87c4d61de4fe046ce5ea0a0b68aad5acf9

Screenshots and Recordings for observations

8.15.3:
Upgrade performed:
8.16.1:
Entity risk score and entity store are successfully enabled without any errors

1.mp4

Entity store is enabled from the dashboards without any errors

2.mp4

The 'enable' button is enabled even when nothing is selected to be enabled

3.mp4

Thank you!

abhishekbhatia1710 · 2024-11-20T14:00:17Z

Awesome @muskangulati-qasource , thanks a lot for testing the upgrade flow as well.

All looks to be working as expected!

kibanamachine · 2024-11-25T07:48:41Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2024-11-26T07:48:53Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

kibanamachine · 2024-11-27T08:48:48Z

Looks like this PR has backport PRs but they still haven't been merged. Please merge them ASAP to keep the branches relatively in sync.

…the old component template (#199734) (#200673) # Backport This will backport the following commits from `main` to `8.x`: - [[Entity Analytics] API changes for right placement of deleting the old component template (#199734)](#199734)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) \n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n"}}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

…d component template (elastic#199734) ## Summary - Delete the old component template after the index template has referenced to the new component template - Test cases for the same flow ```JSON # Let's assume this is 8.15.3 # Create the component template when Risk Score engine is initialised # Create the index template which references the created component template PUT /_component_template/.risk-score-mappings { "template": { "settings": { "number_of_shards": 1 }, "mappings": { "properties": { "timestamp": { "type": "date" }, "user": { "properties": { "id": { "type": "keyword" }, "name": { "type": "text" } } } } } }, "version": 1 } PUT /_index_template/.risk-score.risk-score-default-index-template { "index_patterns": [".risk-score.risk-score-default-index-template"], "template": { "settings": { "number_of_replicas": 1 } }, "composed_of": [".risk-score-mappings"], "priority": 100, "version": 1, "_meta": { "description": "Index template for indices with the pattern my_index-*" } } # The deployment is updated to 8.16 # User tries to enable the Entity store which init's the Risk Score engine (again!!) # Fails, but creates the component template and cannot update the index template to reference the new component template due to the error PUT /_component_template/.risk-score-mappings-default { "template": { "settings": { "number_of_shards": 1 }, "mappings": { "properties": { "timestamp": { "type": "date" }, "user": { "properties": { "id": { "type": "keyword" }, "name": { "type": "text" } } } } } }, "version": 1 } GET /_component_template?filter_path=component_templates.name&name=.risk-score-mappings* DELETE /_component_template/.risk-score-mappings # Fails # changed flow PUT /_index_template/.risk-score.risk-score-default-index-template { "index_patterns": [".risk-score.risk-score-default-index-template"], "template": { "settings": { "number_of_replicas": 1 } }, "composed_of": [".risk-score-mappings-default"], "priority": 100, "version": 1, "_meta": { "description": "Index template for indices with the pattern my_index-*" } } DELETE /_component_template/.risk-score-mappings # Succeeds ######### ``` ### Checklist Delete any items that are not applicable to this PR. - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### For maintainers - [ ] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) - [ ] This will appear in the **Release Notes** and follow the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

abhishekbhatia1710 · 2025-02-25T14:27:57Z

💚 All backports created successfully

Status	Branch	Result
✅	8.17

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

… the old component template (#199734) (#212378) # Backport This will backport the following commits from `main` to `8.17`: - [[Entity Analytics] API changes for right placement of deleting the old component template (#199734)](https://github.com/elastic/kibana/pull/199734)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) \n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\\n\\n### Questions ?\\nPlease refer to the\n[Backport\ntool\\ndocumentation](https://github.com/sqren/backport)\\n\\n\"}}]}]\nBACKPORT-->\n\n---------\n\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>"}},{"branch":"8.16","label":"v8.16.1","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/200591","number":200591,"state":"MERGED","mergeCommit":{"sha":"06999139d210464c236a3784c58b7e5dcbd64ce3","message":"[8.16] [Entity Analytics] API changes for right placement of deleting the old component template (#199734) (#200591)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[Entity Analytics] API changes for right placement of deleting the\nold component template\n(#199734)](https://github.com/elastic/kibana/pull/199734)\n\n\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n"}},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT-->

…deleting the old component template (elastic#199734) (elastic#212378)" This reverts commit 01a430a.

API changes for right placement of deleting the old component template

913f92c

abhishekbhatia1710 added bug Fixes for quality problems that affect the customer experience Team:Entity Analytics Security Entity Analytics Team backport:version Backport to applied version labels v8.16.1 labels Nov 12, 2024

abhishekbhatia1710 self-assigned this Nov 12, 2024

abhishekbhatia1710 requested a review from a team as a code owner November 12, 2024 09:00

abhishekbhatia1710 requested a review from machadoum November 12, 2024 09:00

abhishekbhatia1710 changed the title ~~API changes for right placement of deleting the old component template~~ [Entity Analytics] API changes for right placement of deleting the old component template Nov 12, 2024

hop-dev reviewed Nov 12, 2024

View reviewed changes

...test_suites/entity_analytics/risk_engine/trial_license_complete_tier/init_and_status_apis.ts Show resolved Hide resolved

abhishekbhatia1710 added the release_note:fix label Nov 12, 2024

jaredburgettelastic added v9.0.0 v8.17.0 labels Nov 12, 2024

machadoum reviewed Nov 14, 2024

View reviewed changes

...k/plugins/security_solution/server/lib/entity_analytics/risk_score/risk_score_data_client.ts Outdated Show resolved Hide resolved

abhishekbhatia1710 and others added 3 commits November 18, 2024 18:35

Creating a new function for component template changes and placing th…

f1c0d99

…e deletion of component template a little above than before

Addressing review comments

0721d9f

Merge branch 'main' into ea-11124-Fix-for-risk-score-initialisation

778782d

abhishekbhatia1710 requested review from hop-dev and machadoum November 18, 2024 13:17

machadoum approved these changes Nov 18, 2024

View reviewed changes

hop-dev approved these changes Nov 18, 2024

View reviewed changes

abhishekbhatia1710 enabled auto-merge (squash) November 18, 2024 14:19

abhishekbhatia1710 merged commit 771c139 into elastic:main Nov 18, 2024

abhishekbhatia1710 mentioned this pull request Nov 18, 2024

[8.16] [Entity Analytics] API changes for right placement of deleting the old component template (#199734) #200591

Merged

kibanamachine mentioned this pull request Nov 18, 2024

fix dashboard grid item performs 2 DOM queries every render #199390

Merged

abhishekbhatia1710 mentioned this pull request Nov 19, 2024

[8.x] [Entity Analytics] API changes for right placement of deleting the old component template (#199734) #200673

Merged

kibanamachine mentioned this pull request Nov 19, 2024

[Security Solution] add defend insights elastic assistant tool #198676

Merged

2 tasks

muskangulati-qasource added the QA:Validated Issue has been validated by QA label Nov 21, 2024

kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 25, 2024

kibanamachine added v8.18.0 and removed backport missing Added to PRs automatically when the are determined to be missing a backport. labels Nov 27, 2024

This was referenced Feb 25, 2025

[Security Solution] [Bug] Unable to enable Enable entity store and risk score after upgrade in the second space #212331

Closed

[8.17] [Entity Analytics] API changes for right placement of deleting the old component template (#199734) #212378

Merged

kibanamachine added the v8.17.3 label Feb 26, 2025

machadoum added a commit to machadoum/kibana that referenced this pull request Feb 28, 2025

Revert "[8.17] [Entity Analytics] API changes for right placement of …

d3e2b4b

…deleting the old component template (elastic#199734) (elastic#212378)" This reverts commit 01a430a.

Conversation

abhishekbhatia1710 commented Nov 12, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Checklist

For maintainers

Uh oh!

elasticmachine commented Nov 12, 2024

Uh oh!

abhishekbhatia1710 commented Nov 12, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

machadoum commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

machadoum left a comment

Choose a reason for hiding this comment

Uh oh!

abhishekbhatia1710 commented Nov 18, 2024

Uh oh!

kibanamachine commented Nov 18, 2024

Uh oh!

elasticmachine commented Nov 18, 2024

💚 Build Succeeded

Metrics [docs]

History

Uh oh!

kibanamachine commented Nov 18, 2024

💔 All backports failed

Manual backport

Questions ?

Uh oh!

abhishekbhatia1710 commented Nov 18, 2024

💔 Some backports could not be created

Manual backport

Questions ?

Uh oh!

abhishekbhatia1710 commented Nov 19, 2024

💚 All backports created successfully

Questions ?

Uh oh!

muskangulati-qasource commented Nov 20, 2024

Uh oh!

abhishekbhatia1710 commented Nov 20, 2024

Uh oh!

muskangulati-qasource commented Nov 20, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

abhishekbhatia1710 commented Nov 20, 2024

Uh oh!

kibanamachine commented Nov 25, 2024

Uh oh!

kibanamachine commented Nov 26, 2024

Uh oh!

kibanamachine commented Nov 27, 2024

Uh oh!

abhishekbhatia1710 commented Feb 25, 2025

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

abhishekbhatia1710 commented Nov 12, 2024 •

edited by kibanamachine

Loading

abhishekbhatia1710 commented Nov 12, 2024 •

edited

Loading

machadoum commented Nov 14, 2024 •

edited

Loading

muskangulati-qasource commented Nov 20, 2024 •

edited

Loading