Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Adds tech preview label in the docs #199730

Merged
merged 4 commits into from
Nov 14, 2024

Conversation

stratoula
Copy link
Contributor

@stratoula stratoula commented Nov 12, 2024

Summary

Adds a tech preview label in the docs. The information comes from the ES (changed the script accordingly)

image

@ryankeairns
Copy link
Contributor

Looks good ... also considering the limitations with regards to placement.

The size felt a bit large relative to the section title. In my opinion, it may feel a bit more associated to the title if we make it size s. Then, to not lose visual 'punch', we can use the subdued color instead.

The end result being...

@stratoula
Copy link
Contributor Author

Thanx @ryankeairns done, looks much much better 👏

@stratoula stratoula added release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:version Backport to applied version labels v8.17.0 Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana labels Nov 13, 2024
@stratoula stratoula marked this pull request as ready for review November 13, 2024 07:27
@stratoula stratoula requested review from a team as code owners November 13, 2024 07:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #1 / Indicator match execution logic API @ess @serverless Indicator match type rules, alert suppression Code execution path: events count is greater than threats count deduplicates new alerts if they were previously created without suppression

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
esql 180.4KB 182.1KB +1.7KB
lens 1.5MB 1.5MB +102.0B
unifiedSearch 353.1KB 354.9KB +1.7KB
total +3.6KB

History

@stratoula stratoula merged commit 34c47c8 into elastic:main Nov 14, 2024
34 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11832574825

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 14, 2024
## Summary

Adds a tech preview label in the docs. The information comes from the ES
(changed the script accordingly)

<img width="590" alt="image"
src="https://github.com/user-attachments/assets/0b73b4de-425d-4bbd-b896-92f42faba40d">

(cherry picked from commit 34c47c8)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 14, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ES|QL] Adds tech preview label in the docs
(#199730)](#199730)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Stratoula
Kalafateli","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-14T07:24:42Z","message":"[ES|QL]
Adds tech preview label in the docs (#199730)\n\n## Summary\r\n\r\nAdds
a tech preview label in the docs. The information comes from the
ES\r\n(changed the script accordingly)\r\n\r\n<img width=\"590\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0b73b4de-425d-4bbd-b896-92f42faba40d\">","sha":"34c47c8df1ac97197c5077fb1cf130241b9c79db","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Feature:ES|QL","Team:ESQL","backport:version","v8.17.0"],"title":"[ES|QL]
Adds tech preview label in the
docs","number":199730,"url":"https://github.com/elastic/kibana/pull/199730","mergeCommit":{"message":"[ES|QL]
Adds tech preview label in the docs (#199730)\n\n## Summary\r\n\r\nAdds
a tech preview label in the docs. The information comes from the
ES\r\n(changed the script accordingly)\r\n\r\n<img width=\"590\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0b73b4de-425d-4bbd-b896-92f42faba40d\">","sha":"34c47c8df1ac97197c5077fb1cf130241b9c79db"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199730","number":199730,"mergeCommit":{"message":"[ES|QL]
Adds tech preview label in the docs (#199730)\n\n## Summary\r\n\r\nAdds
a tech preview label in the docs. The information comes from the
ES\r\n(changed the script accordingly)\r\n\r\n<img width=\"590\"
alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/0b73b4de-425d-4bbd-b896-92f42faba40d\">","sha":"34c47c8df1ac97197c5077fb1cf130241b9c79db"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Stratoula Kalafateli <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes Team:ESQL ES|QL related features in Kibana v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants