[ML] Remove data frame analytics scss files#199572
Merged
alvarezmelissa87 merged 8 commits intoelastic:mainfrom Nov 18, 2024
Merged
[ML] Remove data frame analytics scss files#199572alvarezmelissa87 merged 8 commits intoelastic:mainfrom
alvarezmelissa87 merged 8 commits intoelastic:mainfrom
Conversation
alvarezmelissa87
added
:ml
release_note:skip
Contributor
|
Pinging @elastic/ml-ui (:ml) |
alvarezmelissa87
added
Feature:Data Frame Analytics
peteharverson
changed the title
| <span | ||
| data-test-subj="mlJobMapLegend__sourceNode" | ||
| css={{ | ||
| height: `${euiSizeM}`, |
Member
There was a problem hiding this comment.
most of these overrides have mostly the same content. They could be pulled out into an object with all the common props and reused.
e.g.something like
const cssOverrideBase = {
height: `${euiSizeM}`,
width: `${euiSizeM}`,
backgroundColor: `${euiColorGhost}`,
border: `${euiBorderWidthThick} solid ${theme.euiColorVis2}`,
display: 'inline-block',
}
then used like this:
css={{
...cssOverrideBase
transform: 'rotate(45deg)',
}}
also, it's not necessary to wrap single values in template literals
| }> = ({ overallDetails }) => ( | ||
| <EuiFlexGroup alignItems="center" wrap data-test-subj={overallDetails.dataTestSubj}> | ||
| {overallDetails.items.map((item) => { | ||
| const key = `${item.title}`; |
Member
There was a problem hiding this comment.
The template literal isn't needed
|
|
||
| const cssOverride = css({ | ||
| '.euiTable': { | ||
| backgroundColor: 'transparent', |
Member
There was a problem hiding this comment.
By overriding this in the actual component, it means it's transparent for both places where it's used.
IMO in the AD jobs list it should be white and not transparent .
vs
Also it appears the padding has changed. Not a huge problem, I'm not sure which looks better.
Contributor
Author
There was a problem hiding this comment.
Yeah, apparently there's no direct way to set the background for the entire EuiInMemoryTable (just the rows) so was experimenting with the best way to apply it the way we want in each location.
Agree that it's probably best to move the styling back so it only applies where intended. Updated in b8c999e
alvarezmelissa87
changed the title
alvarezmelissa87
changed the title
Contributor
Author
|
@elasticmachine merge upstream |
alvarezmelissa87
changed the title
andreadelrio
requested changes
Nov 12, 2024
| <Fragment> | ||
| <EuiCard | ||
| className="dfAnalyticsCreationWizard__card" | ||
| css={{ width: '300px' }} |
Contributor
There was a problem hiding this comment.
Use an EUI size variable to calculate this.
| <Fragment> | ||
| <EuiCard | ||
| className="dfAnalyticsCreationWizard__card" | ||
| css={{ width: '300px' }} |
Contributor
There was a problem hiding this comment.
Use an EUI size variable to calculate this.
Contributor
Author
There was a problem hiding this comment.
Thanks for taking a look, @andreadelrio 🙏
I'm not sure that would be the best solution here. The size variables I don't think are intended for this as even for the largest we'd have to multiply and do something like size.xl * 6.25, which doesn't seem ideal, especially considering we use set variables for larger values in other places throughout. 🤔 This would then be affected if/when the size variable changes, which I don't think we'd want. I think for larger set widths it's okay to keep it as is.
Could you explain why it would be a better practice to use the variable?
Contributor
There was a problem hiding this comment.
@alvarezmelissa87 In general we recommend not using any hardcoded values even for larger values. The idea is precisely that if the EUI variable were to changes (which is highly unlikely) all the layouts and containers in Kibana change their size according to the new value defined in the design system.
Here are some examples of this practice in our codebase. See:
Contributor
Author
There was a problem hiding this comment.
@andreadelrio - Thanks for the response - updated to use eui size variable in 9ffc9a0
71 tasks
peteharverson
approved these changes
Nov 13, 2024
Contributor
peteharverson
left a comment
peteharverson
left a comment
There was a problem hiding this comment.
Tested (light and dark theme) and didn't spot any regressions. LGTM
Contributor
Author
|
@elasticmachine merge upstream |
andreadelrio
approved these changes
Nov 14, 2024
Contributor
andreadelrio
left a comment
andreadelrio
left a comment
There was a problem hiding this comment.
Style code changes LGTM.
Contributor
Author
|
/ci |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Module Count
Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11899368023 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 18, 2024
## Summary Related meta issue: elastic#140695 DFA map legend changes: <img width="1160" alt="image" src="https://github.com/user-attachments/assets/9858e83f-8cf5-4b1c-97d3-2726808eaedc"> Job messages changes: <img width="1033" alt="image" src="https://github.com/user-attachments/assets/fff3cdb0-efad-4cfd-bc18-bf60deffad26"> job messages in AD: <img width="1231" alt="image" src="https://github.com/user-attachments/assets/4f880be2-1be6-4315-a086-45920c3cb35e"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com> (cherry picked from commit 2c0825f)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 18, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[ML] Remove data frame analytics scss files (#199572)](#199572) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Melissa Alvarez","email":"melissa.alvarez@elastic.co"},"sourceCommit":{"committedDate":"2024-11-18T19:09:31Z","message":"[ML] Remove data frame analytics scss files (#199572)\n\n## Summary\r\n\r\nRelated meta issue: https://github.com/elastic/kibana/issues/140695\r\n\r\nDFA map legend changes:\r\n\r\n<img width=\"1160\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9858e83f-8cf5-4b1c-97d3-2726808eaedc\">\r\n\r\nJob messages changes:\r\n\r\n<img width=\"1033\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fff3cdb0-efad-4cfd-bc18-bf60deffad26\">\r\n\r\njob messages in AD:\r\n\r\n<img width=\"1231\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4f880be2-1be6-4315-a086-45920c3cb35e\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"2c0825f6b13d761b25c2c2978f9f7964d1b95a6b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":[":ml","release_note:skip","Feature:Data Frame Analytics","v9.0.0","backport:version","v8.17.0"],"title":"[ML] Remove data frame analytics scss files","number":199572,"url":"https://github.com/elastic/kibana/pull/199572","mergeCommit":{"message":"[ML] Remove data frame analytics scss files (#199572)\n\n## Summary\r\n\r\nRelated meta issue: https://github.com/elastic/kibana/issues/140695\r\n\r\nDFA map legend changes:\r\n\r\n<img width=\"1160\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9858e83f-8cf5-4b1c-97d3-2726808eaedc\">\r\n\r\nJob messages changes:\r\n\r\n<img width=\"1033\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fff3cdb0-efad-4cfd-bc18-bf60deffad26\">\r\n\r\njob messages in AD:\r\n\r\n<img width=\"1231\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4f880be2-1be6-4315-a086-45920c3cb35e\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"2c0825f6b13d761b25c2c2978f9f7964d1b95a6b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199572","number":199572,"mergeCommit":{"message":"[ML] Remove data frame analytics scss files (#199572)\n\n## Summary\r\n\r\nRelated meta issue: https://github.com/elastic/kibana/issues/140695\r\n\r\nDFA map legend changes:\r\n\r\n<img width=\"1160\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/9858e83f-8cf5-4b1c-97d3-2726808eaedc\">\r\n\r\nJob messages changes:\r\n\r\n<img width=\"1033\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/fff3cdb0-efad-4cfd-bc18-bf60deffad26\">\r\n\r\njob messages in AD:\r\n\r\n<img width=\"1231\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/4f880be2-1be6-4315-a086-45920c3cb35e\">\r\n\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [ ] Any text added follows [EUI's writing\r\nguidelines](https://elastic.github.io/eui/#/guidelines/writing), uses\r\nsentence case text and includes [i18n\r\nsupport](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)\r\n- [ ]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [ ] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n- [ ] Any UI touched in this PR is usable by keyboard only (learn more\r\nabout [keyboard accessibility](https://webaim.org/techniques/keyboard/))\r\n- [ ] Any UI touched in this PR does not create any new axe failures\r\n(run axe in browser:\r\n[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),\r\n[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))\r\n- [ ] If a plugin configuration key changed, check if it needs to be\r\nallowlisted in the cloud and added to the [docker\r\nlist](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker)\r\n- [ ] This renders correctly on smaller devices using a responsive\r\nlayout. (You can test this [in your\r\nbrowser](https://www.browserstack.com/guide/responsive-testing-on-local-server))\r\n- [ ] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n---------\r\n\r\nCo-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>","sha":"2c0825f6b13d761b25c2c2978f9f7964d1b95a6b"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Melissa Alvarez <melissa.alvarez@elastic.co>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Dec 12, 2024
## Summary Related meta issue: elastic#140695 DFA map legend changes: <img width="1160" alt="image" src="https://github.com/user-attachments/assets/9858e83f-8cf5-4b1c-97d3-2726808eaedc"> Job messages changes: <img width="1033" alt="image" src="https://github.com/user-attachments/assets/fff3cdb0-efad-4cfd-bc18-bf60deffad26"> job messages in AD: <img width="1231" alt="image" src="https://github.com/user-attachments/assets/4f880be2-1be6-4315-a086-45920c3cb35e"> ### Checklist Delete any items that are not applicable to this PR. - [ ] Any text added follows [EUI's writing guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses sentence case text and includes [i18n support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md) - [ ] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [ ] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed - [ ] Any UI touched in this PR is usable by keyboard only (learn more about [keyboard accessibility](https://webaim.org/techniques/keyboard/)) - [ ] Any UI touched in this PR does not create any new axe failures (run axe in browser: [FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/), [Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US)) - [ ] If a plugin configuration key changed, check if it needs to be allowlisted in the cloud and added to the [docker list](https://github.com/elastic/kibana/blob/main/src/dev/build/tasks/os_packages/docker_generator/resources/base/bin/kibana-docker) - [ ] This renders correctly on smaller devices using a responsive layout. (You can test this [in your browser](https://www.browserstack.com/guide/responsive-testing-on-local-server)) - [ ] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) --------- Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Related meta issue: #140695
DFA map legend changes:
Job messages changes:
job messages in AD:
Checklist
Delete any items that are not applicable to this PR.