Sustainable Kibana Architecture: Remove dependencies between plugins that are related by _App Links_ by gsoldevila · Pull Request #199492 · elastic/kibana

gsoldevila · 2024-11-08T14:45:36Z

Summary

This PR introduces a Core API to check whether a given application has been registered.
Plugins can use this for their App Links, without having to depend on the referenced plugin(s) anymore.

This way, we can get rid of some inter-solution dependencies, and categorise plugins more appropriately.

gsoldevila · 2024-11-08T14:51:04Z

...tion/observability_ai_assistant_management/public/routes/components/search_connector_tab.tsx

Am I wrong or this URL was broken?

++ I think you've got the right appId https://github.com/elastic/kibana/blob/main/packages/deeplinks/search/constants.ts#L10

This was briefly broken last week in the O11y Solution nav because enterprise search was disabled, but we fixed that and the link worked when I checked. But you're right that the appId should be enterpriseSearch so that is very confusing 🤔

I confirm this is fixed externally to this PR too (noticed when rebasing).

rudolf · 2024-11-08T15:29:21Z

...tion/observability_ai_assistant_management/public/routes/components/search_connector_tab.tsx

++ I think you've got the right appId https://github.com/elastic/kibana/blob/main/packages/deeplinks/search/constants.ts#L10

rudolf · 2024-11-08T15:34:53Z

packages/core/application/core-application-browser/src/contracts.ts

nit: it might be useful to mention in the tsdocs of navigateToApp something like:

If a plugin is disabled any applications it registers won't be available either. Before rendering a UI element that a user could use to navigate to another application, first check if the destination application is actually available using the isAppRegistered API.

elasticmachine · 2024-11-09T14:44:03Z

Pinging @elastic/kibana-core (Team:Core)

elasticmachine · 2024-11-09T14:56:12Z

Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant)

github-actions · 2024-11-09T14:56:20Z

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

/oblt-deploy : Deploy a Kibana instance using the Observability test environments.
run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

adcoelho

response-ops ok 👍

jughosta

Changes in Data Discovery mocks LGTM

gsoldevila · 2024-11-11T16:21:29Z

x-pack/plugins/enterprise_search/kibana.jsonc

Here I believe I went too far, I made enterpriseSearch part of "Search" solution only.

This will make observability-ai-assistant-management menu entry totally useless when we have independent solution builds.

However, if we rollback the changes, we have a domino effect that forces us to expose searchPlayground as platform/shared too.

@sphilipse WDYT?

Yeah, I think we need to make this platform/shared for now. Exposing playground as platform/shared is fine for now IMO. We have open tickets to separate this stuff and implement better RBAC which will eventually fix all of these problems. (we need to do that for our ent-search deprecation anyway)

This will make observability-ai-assistant-management menu entry totally useless when we have independent solution builds.

Sorry, what does this mean?

The observability-ai-assistant-management has a link to the searchPlayground.
This creates a dependency O11y=>Search that we are solving my making searchPlayground platform/shared for now.

I rollbacked the change at the root of this discussion in 0aa726b

@dgieselaar could you PTAL? TIA

As discussed, we can keep the conflicting search plugins as search/private for now.
These plugins need to be refactored and external dependencies issues addressed before solution-specific builds.

x-pack/plugins/serverless_search/public/navigation_tree.ts

kpollich

Fleet change 🚀

…fix'

elasticmachine · 2024-11-14T10:23:33Z

💔 Build Failed

Buildkite Build
Commit: a3583f5
Storybooks Preview
Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-199492-a3583f56e148

Failed CI Steps

Post-Build

Metrics [docs]

‼️ ERROR: no builds found for mergeBase sha [f4af267]

History

💔 Build #250897 failed 11102ed
💚 Build #250210 succeeded eba5431
💔 Build #250186 failed dbc531bd335d8a28c42c2db38e3d8616f6839cf3
💔 Build #249877 failed 29177a918d7ef398c27dc89a7b4d78e0d9a27dbb
💔 Build #249806 failed cb54b2cf1b592ee18780bf1381ff3e88e07992e2

cc @gsoldevila

kibanamachine · 2024-11-14T11:49:39Z

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11836591000

…that are related by _App Links_ (elastic#199492) ## Summary This PR introduces a Core API to check whether a given application has been registered. Plugins can use this for their _App Links_, without having to depend on the referenced plugin(s) anymore. This way, we can get rid of some inter-solution dependencies, and categorise plugins more appropriately. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit ad56ec5)

kibanamachine · 2024-11-14T11:54:21Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

…ugins that are related by _App Links_ (#199492) (#200159) # Backport This will backport the following commits from `main` to `8.x`: - [Sustainable Kibana Architecture: Remove dependencies between plugins that are related by _App Links_ (#199492)](#199492)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Gerard Soldevila <gerard.soldevila@elastic.co>

…that are related by _App Links_ (elastic#199492) ## Summary This PR introduces a Core API to check whether a given application has been registered. Plugins can use this for their _App Links_, without having to depend on the referenced plugin(s) anymore. This way, we can get rid of some inter-solution dependencies, and categorise plugins more appropriately. --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

gsoldevila added Team:Core Platform Core services: plugins, logging, config, saved objects, http, ES client, i18n, etc t// release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Nov 8, 2024

gsoldevila self-assigned this Nov 8, 2024

gsoldevila commented Nov 8, 2024

View reviewed changes

rudolf approved these changes Nov 8, 2024

View reviewed changes

gsoldevila force-pushed the kbn-team-1079-links-to-apps-are-not-deps branch from 0e6742f to 9ef9cfa Compare November 9, 2024 14:43

gsoldevila marked this pull request as ready for review November 9, 2024 14:44

gsoldevila requested review from a team as code owners November 9, 2024 14:44

botelastic bot added ci:project-deploy-observability Create an Observability project Team:Obs AI Assistant Observability AI Assistant labels Nov 9, 2024

gsoldevila force-pushed the kbn-team-1079-links-to-apps-are-not-deps branch from 1771ae8 to 6c57443 Compare November 9, 2024 19:44

gsoldevila requested a review from a team as a code owner November 9, 2024 19:44

gsoldevila force-pushed the kbn-team-1079-links-to-apps-are-not-deps branch from 6c57443 to cb54b2c Compare November 10, 2024 07:56

gsoldevila requested a review from a team as a code owner November 10, 2024 07:56

adcoelho approved these changes Nov 10, 2024

View reviewed changes

jughosta approved these changes Nov 11, 2024

View reviewed changes

gsoldevila force-pushed the kbn-team-1079-links-to-apps-are-not-deps branch from cb54b2c to 29177a9 Compare November 11, 2024 10:03

gsoldevila requested a review from a team as a code owner November 11, 2024 10:03

rudolf approved these changes Nov 11, 2024

View reviewed changes

gsoldevila commented Nov 11, 2024

View reviewed changes

sphilipse reviewed Nov 11, 2024

View reviewed changes

x-pack/plugins/serverless_search/public/navigation_tree.ts Outdated Show resolved Hide resolved

kpollich approved these changes Nov 11, 2024

View reviewed changes

gsoldevila added 2 commits November 12, 2024 09:29

Make enterprise-search part of search solution

e562900

Improve navigateToApp description

cae7a9e

kibanamachine and others added 3 commits November 12, 2024 09:29

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

2f1ec8f

…fix'

Add unit tests for isAppRegistered

535a789

Fix type check issues

f8ac56d

gsoldevila force-pushed the kbn-team-1079-links-to-apps-are-not-deps branch from 29177a9 to dbc531b Compare November 12, 2024 08:29

gsoldevila requested review from dgieselaar and sphilipse November 12, 2024 08:39

gsoldevila changed the title ~~Sustainable Kibana Architecture: Make enterprise-search part of Search solution~~ Sustainable Kibana Architecture: Remove dependencies between plugins that are related by _App Links_ Nov 12, 2024

gsoldevila added 2 commits November 12, 2024 10:22

Keep enterprise_search and search_playground as platform for now

6e1cd1f

Fix outdated test

eba5431

gsoldevila force-pushed the kbn-team-1079-links-to-apps-are-not-deps branch from dbc531b to eba5431 Compare November 12, 2024 09:22

sphilipse approved these changes Nov 12, 2024

View reviewed changes

Keep conflicting search plugins as search/private for now

11102ed

dgieselaar approved these changes Nov 13, 2024

View reviewed changes

gsoldevila enabled auto-merge (squash) November 13, 2024 15:09

Merge branch 'main' into kbn-team-1079-links-to-apps-are-not-deps

a3583f5

gsoldevila merged commit ad56ec5 into elastic:main Nov 14, 2024

kibanamachine added the v9.0.0 label Nov 14, 2024

kibanamachine mentioned this pull request Nov 14, 2024

[8.x] Sustainable Kibana Architecture: Remove dependencies between plugins that are related by _App Links_ (#199492) #200159

Merged

kibanamachine mentioned this pull request Nov 14, 2024

[APM] Migrate service tests to deployment agnostic #199812

Merged

4 tasks

kibanamachine added the v8.17.0 label Nov 14, 2024

Conversation

gsoldevila commented Nov 8, 2024 • edited by kibanamachine Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 9, 2024

Uh oh!

elasticmachine commented Nov 9, 2024

Uh oh!

github-actions bot commented Nov 9, 2024

🤖 GitHub comments

Uh oh!

adcoelho left a comment

Choose a reason for hiding this comment

Uh oh!

jughosta left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

kpollich left a comment

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 14, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

💔 Build Failed

Failed CI Steps

Metrics [docs]

History

Uh oh!

kibanamachine commented Nov 14, 2024

Uh oh!

kibanamachine commented Nov 14, 2024

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

gsoldevila commented Nov 8, 2024 •

edited by kibanamachine

Loading

elasticmachine commented Nov 14, 2024 •

edited

Loading