Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] fix create package policy test #199477

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

juliaElastic
Copy link
Contributor

@juliaElastic juliaElastic commented Nov 8, 2024

Summary

Enabling flaky create package policy test, fixing failures

Closes #196463
Closes #196464
Closes #196465
Closes #196466
Closes #196467
Closes #196468
Closes #196469

@juliaElastic juliaElastic added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Nov 8, 2024
@juliaElastic juliaElastic self-assigned this Nov 8, 2024
@juliaElastic juliaElastic requested a review from a team as a code owner November 8, 2024 13:40
@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Nov 8, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

@juliaElastic
Copy link
Contributor Author

There were some test failures since the test was skipped, fixed those.
However I still can't reproduce the flakyness locally, tried running in a loop.

Copy link
Member

@nchaulet nchaulet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @juliaElastic

@juliaElastic juliaElastic merged commit 3dfe062 into elastic:main Nov 8, 2024
29 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11745309128

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Nov 8, 2024
## Summary

Enabling flaky create package policy test, fixing failures

Closes elastic#196463
Closes elastic#196464
Closes elastic#196465
Closes elastic#196466
Closes elastic#196467
Closes elastic#196468
Closes elastic#196469

(cherry picked from commit 3dfe062)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Nov 11, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Fleet] fix create package policy test
(#199477)](#199477)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Julia
Bardi","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-11-08T15:53:36Z","message":"[Fleet]
fix create package policy test (#199477)\n\n## Summary\r\n\r\nEnabling
flaky create package policy test, fixing failures\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196463\r\nCloses
https://github.com/elastic/kibana/issues/196464\r\nCloses
https://github.com/elastic/kibana/issues/196465\r\nCloses
https://github.com/elastic/kibana/issues/196466\r\nCloses
https://github.com/elastic/kibana/issues/196467\r\nCloses
https://github.com/elastic/kibana/issues/196468\r\nCloses
https://github.com/elastic/kibana/issues/196469","sha":"3dfe062cae698cfbf202b812acd96d2176866cce","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:Fleet","v9.0.0","backport:prev-minor"],"title":"[Fleet]
fix create package policy
test","number":199477,"url":"https://github.com/elastic/kibana/pull/199477","mergeCommit":{"message":"[Fleet]
fix create package policy test (#199477)\n\n## Summary\r\n\r\nEnabling
flaky create package policy test, fixing failures\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196463\r\nCloses
https://github.com/elastic/kibana/issues/196464\r\nCloses
https://github.com/elastic/kibana/issues/196465\r\nCloses
https://github.com/elastic/kibana/issues/196466\r\nCloses
https://github.com/elastic/kibana/issues/196467\r\nCloses
https://github.com/elastic/kibana/issues/196468\r\nCloses
https://github.com/elastic/kibana/issues/196469","sha":"3dfe062cae698cfbf202b812acd96d2176866cce"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199477","number":199477,"mergeCommit":{"message":"[Fleet]
fix create package policy test (#199477)\n\n## Summary\r\n\r\nEnabling
flaky create package policy test, fixing failures\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196463\r\nCloses
https://github.com/elastic/kibana/issues/196464\r\nCloses
https://github.com/elastic/kibana/issues/196465\r\nCloses
https://github.com/elastic/kibana/issues/196466\r\nCloses
https://github.com/elastic/kibana/issues/196467\r\nCloses
https://github.com/elastic/kibana/issues/196468\r\nCloses
https://github.com/elastic/kibana/issues/196469","sha":"3dfe062cae698cfbf202b812acd96d2176866cce"}}]}]
BACKPORT-->

---------

Co-authored-by: Julia Bardi <[email protected]>
Co-authored-by: Julia Bardi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Fleet Team label for Observability Data Collection Fleet team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Failing test: Jest Tests.x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout - When on the package policy create page Submit page On save navigate should navigate to agent policy if no route state is set Failing test: Jest Tests.x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout - When on the package policy create page Submit page On save navigate should navigate to save navigate app if set Failing test: Jest Tests.x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout - When on the package policy create page Submit page On save navigate should navigate to save navigate path with query param if set Failing test: Jest Tests.x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout - When on the package policy create page Submit page On save navigate should navigate to save navigate path if set Failing test: Jest Tests.x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout - When on the package policy create page And Route state is provided via Fleet HashRouter and the cancel Link or Button is clicked should use custom "cancel" URL
4 participants