[Reporting] update puppeteer to version 23.7.0#199304
Merged
sebelga merged 4 commits intoelastic:mainfrom Nov 7, 2024
Merged
Conversation
sebelga
added
release_note:skip
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
Contributor
Author
|
/ci |
tsullivan
approved these changes
Nov 7, 2024
Member
tsullivan
left a comment
tsullivan
left a comment
There was a problem hiding this comment.
LGTM
Tested Linux in Docker
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
cc @sebelga |
Contributor
|
Pinging @elastic/appex-sharedux (Team:SharedUX) |
Contributor
|
Starting backport for target branches: 7.17, 8.15, 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11728488859 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
(cherry picked from commit 1761047)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
Member
|
@sebelga hopefully the merge conflicts in backporting are only due to the yarn.lock changes 🤞🏻 |
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Reporting] update puppeteer to version 23.7.0 (#199304)](#199304) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sébastien Loix","email":"sebastien.loix@elastic.co"},"sourceCommit":{"committedDate":"2024-11-07T17:49:12Z","message":"[Reporting] update puppeteer to version 23.7.0 (#199304)","sha":"1761047b27515c4348b742d9c45892b78ab51b49","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:SharedUX","backport:prev-major","backport:version","v7.17.26"],"title":"[Reporting] update puppeteer to version 23.7.0","number":199304,"url":"https://github.com/elastic/kibana/pull/199304","mergeCommit":{"message":"[Reporting] update puppeteer to version 23.7.0 (#199304)","sha":"1761047b27515c4348b742d9c45892b78ab51b49"}},"sourceBranch":"main","suggestedTargetBranches":["7.17"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199304","number":199304,"mergeCommit":{"message":"[Reporting] update puppeteer to version 23.7.0 (#199304)","sha":"1761047b27515c4348b742d9c45892b78ab51b49"}},{"branch":"7.17","label":"v7.17.26","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Sébastien Loix <sebastien.loix@elastic.co>
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Nov 8, 2024
(cherry picked from commit 1761047) # Conflicts: # yarn.lock
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Nov 8, 2024
(cherry picked from commit 1761047) # Conflicts: # package.json # yarn.lock
Contributor
Author
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
sebelga
added a commit
to sebelga/kibana
that referenced
this pull request
Nov 8, 2024
(cherry picked from commit 1761047) # Conflicts: # package.json # yarn.lock
Contributor
Author
Yes it was mainly that, and some changes to |
sebelga
added a commit
that referenced
this pull request
Nov 8, 2024
) # Backport This will backport the following commits from `main` to `8.16`: - [[Reporting] update puppeteer to version 23.7.0 (#199304)](#199304) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
sebelga
added a commit
that referenced
this pull request
Nov 8, 2024
) # Backport This will backport the following commits from `main` to `8.15`: - [[Reporting] update puppeteer to version 23.7.0 (#199304)](#199304) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
sebelga
added a commit
that referenced
this pull request
Nov 8, 2024
) # Backport This will backport the following commits from `main` to `7.17`: - [[Reporting] update puppeteer to version 23.7.0 (#199304)](#199304) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Update for puppeteer, the following changeset updates puppeteer to version
23.7.0.The chromium version required for this version of puppeteer is
130.0.6723.91from revision1356013, as such the chromium binary included for windows and darwin platforms either match or were the closest revision to the expectation. The linux headless binary was built from commit53ac076783696778ecc8f360ea31765c29c240adof the same revision.pdfmakeI also updated the version of
pdfmaketo the latest0.2.15Manual tests
I successfully managed to create pdf report on my Mac machine and on Linux (following the instructions here)
Fixes #194494