Skip to content

Comments

[8.x] Remove deprecated usages of `EuiFormRow`'s `display="columnCompressedSwitch"` prop (#198709)#199210

Merged
kibanamachine merged 1 commit intoelastic:8.xfrom
kibanamachine:backport/8.x/pr-198709
Nov 6, 2024
Merged

Conversation

@kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…Switch"` prop (elastic#198709)

## Summary

This prop option has been deprecated as of
elastic/eui#7968. `display="columnCompressed"`
now automatically accounts for EuiSwitches (via `:has` CSS) and the
extra prop option is no longer needed.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [x] Any UI touched in this PR does not create any new axe failures
(run axe in browser:
[FF](https://addons.mozilla.org/en-US/firefox/addon/axe-devtools/),
[Chrome](https://chrome.google.com/webstore/detail/axe-web-accessibility-tes/lhdoppojpmngadmnindnejefpokejbdd?hl=en-US))
- [x] This renders correctly on smaller devices using a responsive
layout. (You can test this [in your
browser](https://www.browserstack.com/guide/responsive-testing-on-local-server))

---------

Co-authored-by: Marta Bondyra <4283304+mbondyra@users.noreply.github.com>
(cherry picked from commit 83a9acd)
@kibanamachine kibanamachine merged commit c1b598f into elastic:8.x Nov 6, 2024
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
canvas 1.1MB 1.1MB -6.0B
dataVisualizer 616.0KB 616.0KB -6.0B
eventAnnotationListing 227.7KB 227.7KB -6.0B
fileUpload 951.8KB 951.7KB -6.0B
lens 1.5MB 1.5MB -184.0B
maps 3.0MB 3.0MB -78.0B
securitySolution 21.0MB 21.0MB -18.0B
total -304.0B

cc @cee-chen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport This PR is a backport of another PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants