[unified_doc_viewer / unified_search] clean up SASS compilation warnings#198876
Merged
tsullivan merged 3 commits intoelastic:mainfrom Nov 5, 2024
Merged
[unified_doc_viewer / unified_search] clean up SASS compilation warnings#198876tsullivan merged 3 commits intoelastic:mainfrom
tsullivan merged 3 commits intoelastic:mainfrom
Conversation
tsullivan
added
backport:prev-minor
release_note:skip
Contributor
💔 Build Failed
Failed CI StepsTest Failures
Metrics [docs]
History |
ryankeairns
approved these changes
Nov 5, 2024
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11691724302 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 5, 2024
…ngs (elastic#198876) ## Summary This PR cleans up two noisy warnings seen when building Kibana: ``` [2024-11-04 21:26:37] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:26:37] │ warn worker stderr Recommendation: math.div($euiSizeXS, 2) or calc($euiSizeXS / 2) [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:26:37] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:26:37] │ warn worker stderr ╷ [2024-11-04 21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0 $euiSizeXS; [2024-11-04 21:26:37] │ warn worker stderr │ ^^^^^^^^^^^^^^ [2024-11-04 21:26:37] │ warn worker stderr ╵ [2024-11-04 21:26:37] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss 94:14 root stylesheet [2024-11-04 21:26:37] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. [2024-11-04 21:35:27] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr Recommendation: math.div($euiSizeM, 2) or calc($euiSizeM / 2) [2024-11-04 21:35:27] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div [2024-11-04 21:35:27] │ warn worker stderr [2024-11-04 21:35:27] │ warn worker stderr ╷ [2024-11-04 21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM / 2; [2024-11-04 21:35:27] │ warn worker stderr │ ^^^^^^^^^^^^^ [2024-11-04 21:35:27] │ warn worker stderr ╵ [2024-11-04 21:35:27] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss 11:18 root stylesheet ``` (cherry picked from commit 7a3a2b3)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 5, 2024
… warnings (#198876) (#199052) # Backport This will backport the following commits from `main` to `8.x`: - [[unified_doc_viewer / unified_search] clean up SASS compilation warnings (#198876)](#198876) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-05T20:08:05Z","message":"[unified_doc_viewer / unified_search] clean up SASS compilation warnings (#198876)\n\n## Summary\r\n\r\nThis PR cleans up two noisy warnings seen when building Kibana:\r\n```\r\n[2024-11-04 21:26:37] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr Recommendation: math.div($euiSizeXS, 2) or calc($euiSizeXS / 2)\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr ╷\r\n[2024-11-04 21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0 $euiSizeXS;\r\n[2024-11-04 21:26:37] │ warn worker stderr │ ^^^^^^^^^^^^^^\r\n[2024-11-04 21:26:37] │ warn worker stderr ╵\r\n[2024-11-04 21:26:37] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss 94:14 root stylesheet\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr Recommendation: math.div($euiSizeM, 2) or calc($euiSizeM / 2)\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr ╷\r\n[2024-11-04 21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM / 2;\r\n[2024-11-04 21:35:27] │ warn worker stderr │ ^^^^^^^^^^^^^\r\n[2024-11-04 21:35:27] │ warn worker stderr ╵\r\n[2024-11-04 21:35:27] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss 11:18 root stylesheet\r\n```","sha":"7a3a2b3cb8525acca46481508663d6fd98c5b27b","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[unified_doc_viewer / unified_search] clean up SASS compilation warnings","number":198876,"url":"https://github.com/elastic/kibana/pull/198876","mergeCommit":{"message":"[unified_doc_viewer / unified_search] clean up SASS compilation warnings (#198876)\n\n## Summary\r\n\r\nThis PR cleans up two noisy warnings seen when building Kibana:\r\n```\r\n[2024-11-04 21:26:37] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr Recommendation: math.div($euiSizeXS, 2) or calc($euiSizeXS / 2)\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr ╷\r\n[2024-11-04 21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0 $euiSizeXS;\r\n[2024-11-04 21:26:37] │ warn worker stderr │ ^^^^^^^^^^^^^^\r\n[2024-11-04 21:26:37] │ warn worker stderr ╵\r\n[2024-11-04 21:26:37] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss 94:14 root stylesheet\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr Recommendation: math.div($euiSizeM, 2) or calc($euiSizeM / 2)\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr ╷\r\n[2024-11-04 21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM / 2;\r\n[2024-11-04 21:35:27] │ warn worker stderr │ ^^^^^^^^^^^^^\r\n[2024-11-04 21:35:27] │ warn worker stderr ╵\r\n[2024-11-04 21:35:27] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss 11:18 root stylesheet\r\n```","sha":"7a3a2b3cb8525acca46481508663d6fd98c5b27b"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198876","number":198876,"mergeCommit":{"message":"[unified_doc_viewer / unified_search] clean up SASS compilation warnings (#198876)\n\n## Summary\r\n\r\nThis PR cleans up two noisy warnings seen when building Kibana:\r\n```\r\n[2024-11-04 21:26:37] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr Recommendation: math.div($euiSizeXS, 2) or calc($euiSizeXS / 2)\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:26:37] │ warn worker stderr ╷\r\n[2024-11-04 21:26:37] │ warn worker stderr 94 │ padding: $euiSizeXS / 2 0 0 $euiSizeXS;\r\n[2024-11-04 21:26:37] │ warn worker stderr │ ^^^^^^^^^^^^^^\r\n[2024-11-04 21:26:37] │ warn worker stderr ╵\r\n[2024-11-04 21:26:37] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_doc_viewer/public/components/doc_viewer_table/table.scss 94:14 root stylesheet\r\n[2024-11-04 21:26:37] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr DEPRECATION WARNING: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr Recommendation: math.div($euiSizeM, 2) or calc($euiSizeM / 2)\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr More info and automated migrator: https://sass-lang.com/d/slash-div\r\n[2024-11-04 21:35:27] │ warn worker stderr \r\n[2024-11-04 21:35:27] │ warn worker stderr ╷\r\n[2024-11-04 21:35:27] │ warn worker stderr 11 │ padding-block: $euiSizeM / 2;\r\n[2024-11-04 21:35:27] │ warn worker stderr │ ^^^^^^^^^^^^^\r\n[2024-11-04 21:35:27] │ warn worker stderr ╵\r\n[2024-11-04 21:35:27] │ warn worker stderr file:///home/tim/kibana/src/plugins/unified_search/public/filter_bar/filter_item/filter_item.scss 11:18 root stylesheet\r\n```","sha":"7a3a2b3cb8525acca46481508663d6fd98c5b27b"}}]}] BACKPORT--> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
tsullivan
added a commit
that referenced
this pull request
Nov 6, 2024
) ## Summary Follows #198876. I found one more instance of SASS code that created compilation warnings.
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 6, 2024
…tic#199176) ## Summary Follows elastic#198876. I found one more instance of SASS code that created compilation warnings. (cherry picked from commit 437ca8b)
kibanamachine
added a commit
that referenced
this pull request
Nov 6, 2024
…#199176) (#199212) # Backport This will backport the following commits from `main` to `8.x`: - [[unified-data-table] clean up another SASS compilation warnings (#199176)](#199176) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tim Sullivan","email":"tsullivan@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-06T18:22:32Z","message":"[unified-data-table] clean up another SASS compilation warnings (#199176)\n\n## Summary\r\n\r\nFollows #198876. I found one more\r\ninstance of SASS code that created compilation warnings.","sha":"437ca8bd31d896c666d15b0ccd03d1fb2f0aee9d","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor"],"title":"[unified-data-table] clean up another SASS compilation warnings","number":199176,"url":"https://github.com/elastic/kibana/pull/199176","mergeCommit":{"message":"[unified-data-table] clean up another SASS compilation warnings (#199176)\n\n## Summary\r\n\r\nFollows #198876. I found one more\r\ninstance of SASS code that created compilation warnings.","sha":"437ca8bd31d896c666d15b0ccd03d1fb2f0aee9d"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199176","number":199176,"mergeCommit":{"message":"[unified-data-table] clean up another SASS compilation warnings (#199176)\n\n## Summary\r\n\r\nFollows #198876. I found one more\r\ninstance of SASS code that created compilation warnings.","sha":"437ca8bd31d896c666d15b0ccd03d1fb2f0aee9d"}}]}] BACKPORT--> Co-authored-by: Tim Sullivan <tsullivan@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR cleans up two noisy warnings seen when building Kibana: