-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Obs AI Assistant] Add timestamp to title when the conversation is generated by the rule connector #198791
Conversation
Pinging @elastic/obs-ai-assistant (Team:Obs AI Assistant) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
0225b84
to
042f20b
Compare
@viduni94 is this from repeated runs on the same alert? The title is still generated by the LLM, I assume. Is it an option to perhaps increase the temperature instead? |
@dgieselaar I can try adjusting the temperature for more dynamic titles.. however, I didn't find a way to update the temperature only for a certain function call. If I update the temperature in here, it will update the temperature for all messages.. Let me know if you have any suggestions. |
@viduni94 Yeah we should be able to add a top-level |
b0aeed3
to
4897fab
Compare
Hey @dgieselaar Do you recommend having a higher temperature over adding the timestamp? |
@viduni94 I see, that doesn't help a lot. One thing I'm unsure about is whether we'll be able to show those long titles, IIRC in the unification working group I saw designs where the title is cut off. Another option we have is showing the timestamp or some relative diff (like "30 minutes ago") above the title. Also curious what others feel is a good option |
💚 Build Succeeded
Metrics [docs]
History
cc @viduni94 |
@dgieselaar If we are adding the timestamp on top of the conversation, this would also be removed as part of the unification is it? As it's not there in the mocks. Or should we request the design team for a mock with timestamps? I'll post on our team channel and see whether anyone has any ideas. |
Not a big fan of increasing temperature. Slightly different but very similar titles are not going to help imo. I don't know what the best option is but I think a reasonable bandaid is adding a timestamp. I'm also not sure how big this problem is so I wonder how much we need to invest in solving it. |
... we also have this issue that aims to improve the list of conversations by categorising by time. I think that may also help in this case. |
Thank you @sorenlouv |
@viduni94 @sorenlouv @dgieselaar Conversations generated from alerting may end up with the same title for the same alert type which makes very complicated to find them afterwards. As @sorenlouv mentioned, adding the timestamp is a reasonable bandaid for the current UI while we agree on and implement a UX for the unified assistant. FYI @teknogeek0 |
Thank you @emma-raffenne |
TBH, I think it's a little weird, I'm sure there's a better solution (and also curious if this is actually an issue or mostly something that just comes out of the way we have evaluated this connector, which is to repeatedly trigger it over a short time frame). It's a small change, so we can just get it in, but as a matter of principle it would also be good to reflect on whether this is a sunk cost fallacy thing, or if we're really adding value. We are adding 150 lines of code. |
After a discussion with the team, it was decided to not proceed with this solution. Instead, the timestamp should be placed on the UI in a better way. |
Closes #185022
Summary
Problem
When the Obs AI Assistant is set as the action via the Rule Connector, the conversations generated for the alert has the same title. Therefore, it's hard to distinguish between the different conversations generated by the rule connector.
Solution
Append a timestamp to the title generated for conversations generated by the rule connector.
Few notes about the implementation:
isPublic
variable that already existed as a chat complete property was used to determine whether the conversation was generated by the rule connector (if a new variable such asisGeneratedByRuleConnector
is preferred instead of re-usingisPublic
, let me know, I can update the code).Nov 4, 2024, 08:28:56.817 (UTC-5)
Screenshots
Checklist