[Streams] Introducing the new Streams plugin by simianhacker · Pull Request #198713 · elastic/kibana

simianhacker · 2024-11-01T18:02:45Z

Summary

This PR introduces the new experimental "Streams" plugin into the Kibana project. The Streams project aims to simplify workflows around dealing with messy logs in Elasticsearch. Our current offering is either extremely opinionated with integrations or leaves the user alone with the high flexibility of Elasticsearch concepts like index templates, component templates and so on, which make it challenging to configure everything correctly for good performance and controlling search speed and cost.

Scope of PR

Provides an API for the user to "enable" the streams framework which creates the "root" entity logs with all the backing Elasticsearch assets
Provides an API for the user to "fork" a stream
Provides an API for the user to "read" a stream and all of it's Elasticsearch assets.
Provides an API for the user to upsert a stream (and implicitly child streams that are mentioned)
- Part of this API is placing grok and disscect processing steps as well as fields to the mapping
Implements the Stream Naming Schema (SNS) which uses dots to express the index patterns and stream IDs. Example: logs.nginx.errors
The APIs will fully manage the index_template, component_template, and ingest_pipelines.

Out of scope

Integration tests (coming in a follow-up)

Reviewer Notes

I haven't implemented tests beyond a unit test for converting the filter conditions to Painless. I wanted to get a PR up so we can start iterating on the interface and functionality before we invest in testing.
You might need to add server.versioned.versionResolution: oldest to your config/kibana.dev.yaml to play with the requests below in the Kibana "Dev console".

Example API Calls

Enable the root stream (and set the mapping for the internal .streams index)

POST kbn:/api/streams/_enable

Read the root entity "logs"

GET kbn:/api/streams/logs

Fork the "root" entity "logs" and create "logs.nginx" based on a condition

POST kbn:/api/streams/logs/_fork
{
  "stream": {
    "id": "logs.nginx",
    "children": [],
    "processing": [],
    "fields": [],
  },
  "condition": {
    "field": "log.logger",
    "operator": "eq",
    "value": "nginx_proxy"
  }
}

Fork the entity "logs.nginx" and create "logs.nginx.errors" based on a condition

POST kbn:/api/streams/logs.nginx/_fork
{
  "stream": {
    "id": "logs.nginx.error",
    "children": [],
   "processing": [],
   "fields": [],
  },
  "condition": {
    "or": [
      { "field": "log.level", "operator": "eq", "value": "error" },
      { "field": "log.level", "operator": "eq", "value": "ERROR" }
    ]
  }
}

Set some processing on a stream and map the generated field

PUT kbn:/api/streams/logs.nginx
{
    "children": [],
    "processing": [
       { "config": { "type": "grok", "patterns": ["^%{IP:ip} – –"], "field": "message" } }
    ],
    "fields": [
       { "name": "ip", "type": "ip" }
    ],
  }
}

Field definitions are checked for both descendants and ancestors for incompatibilities to ensure they stay additive.

If children are defined in the PUT /api/streams/<name> API, sub-streams are created implicitly. If a stream is PUT, it's added to the parent as well with a condition that is never true (can be edited subsequently).

POST /api/streams/_resync can be used to re-sync all streams from their meta data in case the Elasticsearch objects got messed up by some external change - not sure whether we want to keep that.

Follow-ups

API integration tests
Check read permissions on data streams to determine whether a user is allowed to read certain streams

… fork conditions

flash1293 · 2024-11-04T17:22:44Z

Great start!

@dgieselaar as discussed I think we should add the following things during the week and aim to get it merged by Friday:

Store all the information about a stream in the .streams document as a source of truth
Keep the routing conditions in the parent stream, not in the child
Do not return the underlying ES objects when reading a stream, but the source of truth from the .streams document

Everything else can probably happen on a separate PR (that we ideally have in by Friday as well):

Basic UI skeleton
Read all streams for listing
Idempotent "PUT" api for editing

flash1293 · 2024-11-05T10:40:41Z

Next stepsd:

Create app plugin for the UI in a separate stacked PR
Do the API changes on this PR

elasticmachine · 2024-11-12T08:21:53Z

Pinging @elastic/unified-observability (Team:Observability)

flash1293 · 2024-11-12T08:22:37Z

@dgieselaar For your changes on the UI side, should we backport this to 8.x to avoid conflicts? Or is it OK to only keep on main?

dgieselaar · 2024-11-12T08:27:04Z

@flash1293 I will create a separate PR for the changes that impact other plugins, and I'll backport that to 8.x, but the streams app plugin only needs to go into 9.x

…ocs'

…fix'

…into init-streams-plugin

jloleysens

New plugin LGTM, reviewed new server APIs.

jloleysens · 2024-11-12T10:35:18Z

x-pack/plugins/streams/server/routes/streams/delete.ts

+  options: {
+    access: 'public',
+    security: {


Availability is not documented yet, but in this case we can set this (and other APIs) to experimental

Suggested change

options: {

access: 'public',

security: {

options: {

access: 'public',

availability: {

stability: 'experimental'

},

security: {

Thanks, set to experimental

…fix'

flash1293 · 2024-11-12T13:49:54Z

Buildkite is having an outage, holding back with trying to get green CI on this for now

jbudz

packages/kbn-optimizer/limits.yml

simianhacker · 2024-11-12T20:42:10Z

x-pack/plugins/streams/server/lib/streams/stream_crud.ts

+      query: {
+        bool: {
+          filter: {
+            prefix: {


…elaar

…elaar since we don't have an official team for this plugin yet.

…ugin

elasticmachine · 2024-11-12T23:01:07Z

💚 Build Succeeded

Buildkite Build
Commit: fc031f8

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`streams`	-	4	+4

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id	before	after	diff
`streams`	-	12	+12

Any counts in public APIs

Total count of every any typed public API. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats any for more detailed information.

id	before	after	diff
`streams`	-	7	+7

Public APIs missing exports

Total count of every type that is part of your API that should be exported but is not. This will cause broken links in the API documentation system. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats exports for more detailed information.

id	before	after	diff
`streams`	-	2	+2

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id	before	after	diff
`streams`	-	1.6KB	+1.6KB

Unknown metric groups

API count

id	before	after	diff
`streams`	-	12	+12

ESLint disabled line counts

id	before	after	diff
`streams`	-	4	+4

Total ESLint disabled count

id	before	after	diff
`streams`	-	4	+4

History

## Summary This PR introduces the new experimental "Streams" plugin into the Kibana project. The Streams project aims to simplify workflows around dealing with messy logs in Elasticsearch. Our current offering is either extremely opinionated with integrations or leaves the user alone with the high flexibility of Elasticsearch concepts like index templates, component templates and so on, which make it challenging to configure everything correctly for good performance and controlling search speed and cost. ### Scope of PR - Provides an API for the user to "enable" the streams framework which creates the "root" entity `logs` with all the backing Elasticsearch assets - Provides an API for the user to "fork" a stream - Provides an API for the user to "read" a stream and all of it's Elasticsearch assets. - Provides an API for the user to upsert a stream (and implicitly child streams that are mentioned) - Part of this API is placing grok and disscect processing steps as well as fields to the mapping - Implements the Stream Naming Schema (SNS) which uses dots to express the index patterns and stream IDs. Example: `logs.nginx.errors` - The APIs will fully manage the `index_template`, `component_template`, and `ingest_pipelines`. ### Out of scope - Integration tests (coming in a follow-up) ### Reviewer Notes - I haven't implemented tests beyond a unit test for converting the filter conditions to Painless. I wanted to get a PR up so we can start iterating on the interface and functionality before we invest in testing. - You might need to add `server.versioned.versionResolution: oldest` to your `config/kibana.dev.yaml` to play with the requests below in the Kibana "Dev console". ### Example API Calls Enable the root stream (and set the mapping for the internal `.streams` index) ``` POST kbn:/api/streams/_enable ``` Read the root entity "logs" ``` GET kbn:/api/streams/logs ``` Fork the "root" entity "logs" and create "logs.nginx" based on a condition ``` POST kbn:/api/streams/logs/_fork { "stream": { "id": "logs.nginx", "children": [], "processing": [], "fields": [], }, "condition": { "field": "log.logger", "operator": "eq", "value": "nginx_proxy" } } ``` Fork the entity "logs.nginx" and create "logs.nginx.errors" based on a condition ``` POST kbn:/api/streams/logs.nginx/_fork { "stream": { "id": "logs.nginx.error", "children": [], "processing": [], "fields": [], }, "condition": { "or": [ { "field": "log.level", "operator": "eq", "value": "error" }, { "field": "log.level", "operator": "eq", "value": "ERROR" } ] } } ``` Set some processing on a stream and map the generated field ``` PUT kbn:/api/streams/logs.nginx { "children": [], "processing": [ { "config": { "type": "grok", "patterns": ["^%{IP:ip} – –"], "field": "message" } } ], "fields": [ { "name": "ip", "type": "ip" } ], } } ``` Field definitions are checked for both descendants and ancestors for incompatibilities to ensure they stay additive. If children are defined in the `PUT /api/streams/<name>` API, sub-streams are created implicitly. If a stream is `PUT`, it's added to the parent as well with a condition that is never true (can be edited subsequently). `POST /api/streams/_resync` can be used to re-sync all streams from their meta data in case the Elasticsearch objects got messed up by some external change - not sure whether we want to keep that. Follow-ups * API integration tests * Check read permissions on data streams to determine whether a user is allowed to read certain streams --------- Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Creates the Streams app plugin, which renders UI for managing streams (see #198713). Additional changes in this PR: - The menus were updated to conditionally add a link to the Streams app. The Streams plugin itself returns a status$ observable which signals if Streams have been enabled. This value is used to conditionally render the link in the various flavors of menus. - There's a small change in the ES types to allow for ordered params in ES|QL (vs named params) - `@kbn/server-route-repository` was updated to be able to override `access` (instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default. - `@kbn/typed-react-router-config` now also exports a `useBreadcrumbs`. This was copied over from the APM implementation. - the signature of the `esql` method in `ObservabilityElasticsearchClient` was updated to separate processing options from options that are sent over to the _query endpoint. --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

dgieselaar · 2024-11-26T08:11:28Z

💚 All backports created successfully

Status	Branch	Result
✅	8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

## Summary This PR introduces the new experimental "Streams" plugin into the Kibana project. The Streams project aims to simplify workflows around dealing with messy logs in Elasticsearch. Our current offering is either extremely opinionated with integrations or leaves the user alone with the high flexibility of Elasticsearch concepts like index templates, component templates and so on, which make it challenging to configure everything correctly for good performance and controlling search speed and cost. ### Scope of PR - Provides an API for the user to "enable" the streams framework which creates the "root" entity `logs` with all the backing Elasticsearch assets - Provides an API for the user to "fork" a stream - Provides an API for the user to "read" a stream and all of it's Elasticsearch assets. - Provides an API for the user to upsert a stream (and implicitly child streams that are mentioned) - Part of this API is placing grok and disscect processing steps as well as fields to the mapping - Implements the Stream Naming Schema (SNS) which uses dots to express the index patterns and stream IDs. Example: `logs.nginx.errors` - The APIs will fully manage the `index_template`, `component_template`, and `ingest_pipelines`. ### Out of scope - Integration tests (coming in a follow-up) ### Reviewer Notes - I haven't implemented tests beyond a unit test for converting the filter conditions to Painless. I wanted to get a PR up so we can start iterating on the interface and functionality before we invest in testing. - You might need to add `server.versioned.versionResolution: oldest` to your `config/kibana.dev.yaml` to play with the requests below in the Kibana "Dev console". ### Example API Calls Enable the root stream (and set the mapping for the internal `.streams` index) ``` POST kbn:/api/streams/_enable ``` Read the root entity "logs" ``` GET kbn:/api/streams/logs ``` Fork the "root" entity "logs" and create "logs.nginx" based on a condition ``` POST kbn:/api/streams/logs/_fork { "stream": { "id": "logs.nginx", "children": [], "processing": [], "fields": [], }, "condition": { "field": "log.logger", "operator": "eq", "value": "nginx_proxy" } } ``` Fork the entity "logs.nginx" and create "logs.nginx.errors" based on a condition ``` POST kbn:/api/streams/logs.nginx/_fork { "stream": { "id": "logs.nginx.error", "children": [], "processing": [], "fields": [], }, "condition": { "or": [ { "field": "log.level", "operator": "eq", "value": "error" }, { "field": "log.level", "operator": "eq", "value": "ERROR" } ] } } ``` Set some processing on a stream and map the generated field ``` PUT kbn:/api/streams/logs.nginx { "children": [], "processing": [ { "config": { "type": "grok", "patterns": ["^%{IP:ip} – –"], "field": "message" } } ], "fields": [ { "name": "ip", "type": "ip" } ], } } ``` Field definitions are checked for both descendants and ancestors for incompatibilities to ensure they stay additive. If children are defined in the `PUT /api/streams/<name>` API, sub-streams are created implicitly. If a stream is `PUT`, it's added to the parent as well with a condition that is never true (can be edited subsequently). `POST /api/streams/_resync` can be used to re-sync all streams from their meta data in case the Elasticsearch objects got messed up by some external change - not sure whether we want to keep that. Follow-ups * API integration tests * Check read permissions on data streams to determine whether a user is allowed to read certain streams --------- Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit b86dc81) # Conflicts: # .github/CODEOWNERS

# Backport This will backport the following commits from `main` to `8.x`: - [[Streams] Introducing the new Streams plugin (#198713)](#198713)  ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport)  Co-authored-by: Chris Cowan <chris@elastic.co>

Creates the Streams app plugin, which renders UI for managing streams (see elastic#198713). Additional changes in this PR: - The menus were updated to conditionally add a link to the Streams app. The Streams plugin itself returns a status$ observable which signals if Streams have been enabled. This value is used to conditionally render the link in the various flavors of menus. - There's a small change in the ES types to allow for ordered params in ES|QL (vs named params) - `@kbn/server-route-repository` was updated to be able to override `access` (instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default. - `@kbn/typed-react-router-config` now also exports a `useBreadcrumbs`. This was copied over from the APM implementation. - the signature of the `esql` method in `ObservabilityElasticsearchClient` was updated to separate processing options from options that are sent over to the _query endpoint. --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

Creates the Streams app plugin, which renders UI for managing streams (see elastic#198713). Additional changes in this PR: - The menus were updated to conditionally add a link to the Streams app. The Streams plugin itself returns a status$ observable which signals if Streams have been enabled. This value is used to conditionally render the link in the various flavors of menus. - There's a small change in the ES types to allow for ordered params in ES|QL (vs named params) - `@kbn/server-route-repository` was updated to be able to override `access` (instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default. - `@kbn/typed-react-router-config` now also exports a `useBreadcrumbs`. This was copied over from the APM implementation. - the signature of the `esql` method in `ObservabilityElasticsearchClient` was updated to separate processing options from options that are sent over to the _query endpoint. --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 63da770) # Conflicts: # .github/CODEOWNERS

Creates the Streams app plugin, which renders UI for managing streams (see elastic#198713). Additional changes in this PR: - The menus were updated to conditionally add a link to the Streams app. The Streams plugin itself returns a status$ observable which signals if Streams have been enabled. This value is used to conditionally render the link in the various flavors of menus. - There's a small change in the ES types to allow for ordered params in ES|QL (vs named params) - `@kbn/server-route-repository` was updated to be able to override `access` (instead of only inferring it from the endpoint name). Additionally, we now allow all route options by default. - `@kbn/typed-react-router-config` now also exports a `useBreadcrumbs`. This was copied over from the APM implementation. - the signature of the `esql` method in `ObservabilityElasticsearchClient` was updated to separate processing options from options that are sent over to the _query endpoint. --------- Co-authored-by: Chris Cowan <chris@elastic.co> Co-authored-by: Joe Reuter <johannes.reuter@elastic.co> Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>

simianhacker added 3 commits November 1, 2024 11:22

Initial setup for streams plugin

5fe1078

migrating to the streams naming schema; adding an abstraction for the…

6f940eb

… fork conditions

ensure forked streams are marked root:false

9b33808

simianhacker added Team:Observability Team label for Observability Team (for things that are handled across all of observability) v9.0.0 labels Nov 1, 2024

flash1293 added 8 commits November 8, 2024 17:41

stream management

d99a3ff

add delete and listing endpoint

0e89345

cleanup

9dd5fde

add resync endpoint

7400a3b

more fixes

9d37219

more adjustments

d622fa1

some more fixes

fbc6c2a

Merge remote-tracking branch 'upstream/main' into init-streams-plugin

45787d0

flash1293 marked this pull request as ready for review November 12, 2024 08:21

flash1293 requested a review from a team as a code owner November 12, 2024 08:21

flash1293 added release_note:skip Skip the PR/issue when compiling release notes backport:skip This PR does not require backporting labels Nov 12, 2024

kibanamachine and others added 4 commits November 12, 2024 08:32

[CI] Auto-commit changed files from 'node scripts/build_plugin_list_d…

e810f53

…ocs'

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

e93ac17

…fix'

add limits

cf9f349

Merge branch 'init-streams-plugin' of github.com:simianhacker/kibana …

0d676ed

…into init-streams-plugin

flash1293 requested a review from a team as a code owner November 12, 2024 09:38

jloleysens approved these changes Nov 12, 2024

View reviewed changes

flash1293 added 2 commits November 12, 2024 12:36

fix permissions

34f3c44

remove feature completely

0b7de24

flash1293 and others added 4 commits November 12, 2024 12:59

cleanup

76ed81d

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

2427d2e

…fix'

Merge branch 'main' into init-streams-plugin

2ad08f4

Merge branch 'main' into init-streams-plugin

c8d99ed

jbudz approved these changes Nov 12, 2024

View reviewed changes

simianhacker commented Nov 12, 2024

View reviewed changes

x-pack/plugins/streams/server/lib/streams/stream_crud.ts

query: {

bool: {

filter: {

prefix: {

Copy link
Copy Markdown

Member Author

simianhacker Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

simianhacker added 2 commits November 12, 2024 14:14

Updating the owners and CODEOWNERS to @simianhacker @flash1293 @dgies…

a60a165

…elaar since we don't have an official team for this plugin yet.

Merge branch 'main' of github.com:elastic/kibana into init-streams-pl…

fc031f8

…ugin

flash1293 merged commit b86dc81 into elastic:main Nov 13, 2024

dgieselaar mentioned this pull request Nov 14, 2024

[Streams] App plugin #200060

Merged

dgieselaar mentioned this pull request Nov 26, 2024

[8.x] [Streams] Introducing the new Streams plugin (#198713) #201723

Merged

kibanamachine mentioned this pull request Nov 26, 2024

Update OpenAPI Spec (main) #201609

Merged

1 task

Conversation

simianhacker commented Nov 1, 2024 • edited by flash1293 Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Scope of PR

Out of scope

Reviewer Notes

Example API Calls

Uh oh!

flash1293 commented Nov 4, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

flash1293 commented Nov 5, 2024

Uh oh!

elasticmachine commented Nov 12, 2024

Uh oh!

flash1293 commented Nov 12, 2024

Uh oh!

dgieselaar commented Nov 12, 2024

Uh oh!

jloleysens left a comment

Choose a reason for hiding this comment

Uh oh!

jloleysens Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

flash1293 Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

flash1293 commented Nov 12, 2024

Uh oh!

jbudz left a comment

Choose a reason for hiding this comment

Uh oh!

simianhacker Nov 12, 2024

Choose a reason for hiding this comment

Uh oh!

elasticmachine commented Nov 12, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Public APIs missing comments

Any counts in public APIs

Public APIs missing exports

Page load bundle

API count

ESLint disabled line counts

Total ESLint disabled count

History

Uh oh!

dgieselaar commented Nov 26, 2024

💚 All backports created successfully

Questions ?

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

simianhacker commented Nov 1, 2024 •

edited by flash1293

Loading

flash1293 commented Nov 4, 2024 •

edited

Loading