Skip to content

Fix chromium png bitblt error and reinstate tests#19871

Closed
stacey-gammon wants to merge 8 commits intoelastic:masterfrom
stacey-gammon:2018-06-13-chromium-png-bug-tests
Closed

Fix chromium png bitblt error and reinstate tests#19871
stacey-gammon wants to merge 8 commits intoelastic:masterfrom
stacey-gammon:2018-06-13-chromium-png-bug-tests

Conversation

@stacey-gammon
Copy link

@stacey-gammon stacey-gammon commented Jun 13, 2018

  • Reinstate tests
  • Add debug logic

tries to fix #19563

@stacey-gammon stacey-gammon added :Sharing zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead labels Jun 13, 2018
@stacey-gammon
Copy link
Author

Passed

jenkins, test this

@stacey-gammon
Copy link
Author

Passed again

Jenkins, test this

@stacey-gammon
Copy link
Author

retest

@stacey-gammon
Copy link
Author

stacey-gammon commented Jun 15, 2018

Error output:

22:32:07        │ proc  [kibana]   ops   [22:32:07.536]  memory: 182.2MB uptime: 0:02:33 load: [1.26 1.68 1.49] delay: 0.443
22:32:07        │ proc  [kibana]   log   [22:32:07.538] [debug][kibana-monitoring][monitoring-ui] Received Kibana Ops event data
22:32:07        │ proc  [kibana]   log   [22:32:07.538] [debug][reporting][screenshots] taking screenshots
22:32:07        │ proc  [kibana]   log   [22:32:07.539] [debug][chromium-driver-factory][reporting] screenshotStitcher with zoom of 2 and max of 1950
22:32:07        │ proc  [kibana]   log   [22:32:07.540] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 0 and y 0
22:32:07        │ proc  [kibana]   log   [22:32:07.541] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 975 and y 0
22:32:07        │ proc  [kibana]   log   [22:32:07.902] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":0,"y":0,"width":975,"height":404}
22:32:07        │ proc  [kibana]   log   [22:32:07.904] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":0,"y":0,"width":975,"height":404}
22:32:07        │ proc  [kibana]   log   [22:32:07.955] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":975,"y":0,"width":85,"height":404}
22:32:07        │ proc  [kibana]   log   [22:32:07.956] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":975,"y":0,"width":85,"height":404}
22:32:07        │ proc  [kibana]   log   [22:32:07.980] [debug][chromium-driver-factory][reporting] Output dimensions is {"x":0,"y":0,"width":2120,"height":808}
22:32:07        │ proc  [kibana]   log   [22:32:07.981] [debug][chromium-driver-factory][reporting] Input png w: 170 and h: 404
22:32:07        │ proc  [kibana]   log   [22:32:07.981] [debug][chromium-driver-factory][reporting] Creating output png with {"x":1950,"y":0,"width":170,"height":808}
22:32:08        │ proc  [kibana]   log   [22:32:08.005] [debug][esqueue][reporting][worker] jif4a9k30bj60f6a39dm8yve - Failure occurred on job jif4czoq0bj60f6a39gir99s: Error: bitblt reading outside image

Passing output:

20:10:20        │ proc  [kibana]   log   [20:10:20.123] [debug][reporting][screenshots] timeRange from 2018-06-14T19:55:11Z to 2018-06-14T20:10:11Z
20:10:20        │ proc  [kibana]   log   [20:10:20.177] [debug][reporting][screenshots] taking screenshots
20:10:20        │ proc  [kibana]   log   [20:10:20.178] [debug][chromium-driver-factory][reporting] screenshotStitcher with zoom of 2 and max of 1950
20:10:20        │ proc  [kibana]   log   [20:10:20.179] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 0 and y 0
20:10:20        │ proc  [kibana]   log   [20:10:20.179] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 975 and y 0
20:10:20        │ proc  [kibana]   log   [20:10:20.483] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":0,"y":0,"width":975,"height":399}
20:10:20        │ proc  [kibana]   log   [20:10:20.484] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":0,"y":0,"width":975,"height":399}
20:10:20        │ proc  [kibana]   log   [20:10:20.550] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":975,"y":0,"width":85,"height":399}
20:10:20        │ proc  [kibana]   log   [20:10:20.550] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":975,"y":0,"width":85,"height":399}
20:10:20        │ proc  [kibana]   log   [20:10:20.582] [debug][chromium-driver-factory][reporting] Output dimensions is {"x":0,"y":0,"width":2120,"height":798}
20:10:20        │ proc  [kibana]   log   [20:10:20.582] [debug][chromium-driver-factory][reporting] Input png w: 170 and h: 798
20:10:20        │ proc  [kibana]   log   [20:10:20.582] [debug][chromium-driver-factory][reporting] Creating output png with {"x":1950,"y":0,"width":170,"height":798}
20:10:20        │ proc  [kibana]   log   [20:10:20.722] [debug][chromium-driver-factory][reporting] Output dimensions is {"x":0,"y":0,"width":2120,"height":798}
20:10:20        │ proc  [kibana]   log   [20:10:20.722] [debug][chromium-driver-factory][reporting] Input png w: 1950 and h: 798
20:10:20        │ proc  [kibana]   log   [20:10:20.722] [debug][chromium-driver-factory][reporting] Creating output png with {"x":0,"y":0,"width":1950,"height":798}
20:10:21        │ proc  [kibana]   log   [20:10:21.074] [debug][reporting][screenshots] screenshot took 895ms
20:10:21        │ proc  [kibana]   log   [20:10:21.406] [debug][esqueue][reporting][worker] jiez7zqz07zg6c2c2bgdjb2d - Completed job jiezaoqh07zg6c2c2bbbd5cc

@stacey-gammon stacey-gammon force-pushed the 2018-06-13-chromium-png-bug-tests branch from bee388d to 001deb4 Compare June 15, 2018 13:35
@stacey-gammon
Copy link
Author

passed

jenkins, test this

1 similar comment
@stacey-gammon
Copy link
Author

passed

jenkins, test this

@stacey-gammon stacey-gammon force-pushed the 2018-06-13-chromium-png-bug-tests branch from 0ab17b3 to ea85ece Compare June 18, 2018 20:03
@stacey-gammon
Copy link
Author

Failed on what looks like an unrelated error:

 "dashboard app using legacy data dashboard listing page delete default confirm action is cancel"
20:41:33          │        Error: expected true to equal false
20:41:33          │         at Assertion.assert (node_modules/expect.j

retest

@stacey-gammon
Copy link
Author

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon stacey-gammon force-pushed the 2018-06-13-chromium-png-bug-tests branch from ea85ece to 7e0b3c2 Compare June 19, 2018 13:41
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Author

stacey-gammon commented Jun 19, 2018

hit the failure:

14:42:35        │ proc  [kibana]   log   [14:42:35.730] [debug][reporting][screenshots] taking screenshots
14:42:35        │ proc  [kibana]   log   [14:42:35.730] [debug][chromium-driver-factory][reporting] elementPosition is not null, boundingClientRect is {"top":0,"left":0,"width":1060,"height":404}
14:42:35        │ proc  [kibana]   log   [14:42:35.731] [debug][chromium-driver-factory][reporting] screenshotStitcher with zoom of 2 and max of 1950 and outputClips of {"x":0,"y":0,"height":404,"width":1060}
14:42:35        │ proc  [kibana]   log   [14:42:35.732] [debug][chromium-driver-factory][reporting] rows calculated by: Math.ceil(404 / 975) || 1
14:42:35        │ proc  [kibana]   log   [14:42:35.732] [debug][chromium-driver-factory][reporting] rows is 1
14:42:35        │ proc  [kibana]   log   [14:42:35.733] [debug][chromium-driver-factory][reporting] get clips with dimensions: {"x":0,"y":0,"height":404,"width":1060}
14:42:35        │ proc  [kibana]   log   [14:42:35.733] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 0 and y 0 and w: 975 and h 404
14:42:35        │ proc  [kibana]   log   [14:42:35.733] [debug][chromium-driver-factory][reporting] height calculated by: 0 === 1 - 1 ? 404 - (0 * 975) : 975
14:42:35        │ proc  [kibana]   log   [14:42:35.734] [debug][chromium-driver-factory][reporting] get clips with dimensions: {"x":0,"y":0,"height":404,"width":1060}
14:42:35        │ proc  [kibana]   log   [14:42:35.734] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 975 and y 0 and w: 85 and h 404
14:42:35        │ proc  [kibana]   log   [14:42:35.735] [debug][chromium-driver-factory][reporting] height calculated by: 0 === 1 - 1 ? 404 - (0 * 975) : 975
14:42:35        │ proc  [kibana]   log   [14:42:35.924] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":0,"y":0,"width":975,"height":404}
14:42:35        │ proc  [kibana]   log   [14:42:35.924] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":0,"y":0,"width":975,"height":404}
14:42:35        │ proc  [kibana]   log   [14:42:35.980] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":975,"y":0,"width":85,"height":404}
14:42:35        │ proc  [kibana]   log   [14:42:35.980] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":975,"y":0,"width":85,"height":404}
14:42:36        │ proc  [kibana]   log   [14:42:36.010] [debug][chromium-driver-factory][reporting] Output dimensions is {"x":0,"y":0,"width":2120,"height":808}
14:42:36        │ proc  [kibana]   log   [14:42:36.010] [debug][chromium-driver-factory][reporting] Input png w: 170 and h: 404
14:42:36        │ proc  [kibana]   log   [14:42:36.010] [debug][chromium-driver-factory][reporting] Creating output png with {"x":1950,"y":0,"width":170,"height":808}
14:42:36        │ proc  [kibana]   log   [14:42:36.030] [debug][esqueue][reporting][worker] jilsq1z103we2ad6bd8gb6mw - Failure occurred on job jilssiqk03we2ad6bd93twb9: Error: bitblt reading outside image
14:42:36        │ proc  [kibana]     at Function.PNG.bitblt (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/pngjs/lib/png.js:131:11)
14:42:36        │ proc  [kibana]     at exports.PNG.PNG.bitblt (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/pngjs/lib/png.js:150:7)

Success:

6:03:41        │ proc  [kibana]   log   [16:03:41.742] [debug][reporting][screenshots] rendering is complete
16:03:41        │ proc  [kibana]   log   [16:03:41.753] [debug][reporting][screenshots] timeRange from 2018-06-19T15:48:34Z to 2018-06-19T16:03:34Z
16:03:41        │ proc  [kibana]   log   [16:03:41.810] [debug][reporting][screenshots] taking screenshots
16:03:41        │ proc  [kibana]   log   [16:03:41.811] [debug][chromium-driver-factory][reporting] elementPosition is not null, boundingClientRect is {"top":0,"left":0,"width":1060,"height":404}
16:03:41        │ proc  [kibana]   log   [16:03:41.811] [debug][chromium-driver-factory][reporting] screenshotStitcher with zoom of 2 and max of 1950 and outputClips of {"x":0,"y":0,"height":404,"width":1060}
16:03:41        │ proc  [kibana]   log   [16:03:41.813] [debug][chromium-driver-factory][reporting] rows calculated by: Math.ceil(404 / 975) || 1
16:03:41        │ proc  [kibana]   log   [16:03:41.813] [debug][chromium-driver-factory][reporting] rows is 1
16:03:41        │ proc  [kibana]   log   [16:03:41.813] [debug][chromium-driver-factory][reporting] get clips with dimensions: {"x":0,"y":0,"height":404,"width":1060}
16:03:41        │ proc  [kibana]   log   [16:03:41.813] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 0 and y 0 and w: 975 and h 404
16:03:41        │ proc  [kibana]   log   [16:03:41.814] [debug][chromium-driver-factory][reporting] height calculated by: 0 === 1 - 1 ? 404 - (0 * 975) : 975
16:03:41        │ proc  [kibana]   log   [16:03:41.814] [debug][chromium-driver-factory][reporting] get clips with dimensions: {"x":0,"y":0,"height":404,"width":1060}
16:03:41        │ proc  [kibana]   log   [16:03:41.815] [debug][chromium-driver-factory][reporting] Screenshot stitcher: Yielding x 975 and y 0 and w: 85 and h 404
16:03:41        │ proc  [kibana]   log   [16:03:41.815] [debug][chromium-driver-factory][reporting] height calculated by: 0 === 1 - 1 ? 404 - (0 * 975) : 975
16:03:41        │ proc  [kibana]   log   [16:03:41.816] [debug][license][xpack] Calling [data] Elasticsearch _xpack API. Polling frequency: 30001
16:03:41        │ proc  [kibana]   log   [16:03:41.968] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":0,"y":0,"width":975,"height":404}
16:03:41        │ proc  [kibana]   log   [16:03:41.969] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":0,"y":0,"width":975,"height":404}
16:03:42        │ proc  [kibana]   log   [16:03:42.062] [debug][chromium-driver-factory][reporting] captured screenshot clip {"x":975,"y":0,"width":85,"height":404}
16:03:42        │ proc  [kibana]   log   [16:03:42.063] [debug][chromium-driver-factory][reporting] Creating capture dimensions for clip {"x":975,"y":0,"width":85,"height":404}
16:03:42        │ proc  [kibana]   log   [16:03:42.093] [debug][chromium-driver-factory][reporting] Output dimensions is {"x":0,"y":0,"width":2120,"height":808}
16:03:42        │ proc  [kibana]   log   [16:03:42.093] [debug][chromium-driver-factory][reporting] Input png w: 170 and h: 808
16:03:42        │ proc  [kibana]   log   [16:03:42.093] [debug][chromium-driver-factory][reporting] Creating output png with {"x":1950,"y":0,"width":170,"height":808}
16:03:42        │ proc  [kibana]   log   [16:03:42.125] [debug][license][xpack] Calling [monitoring] Elasticsearch _xpack API. Polling frequency: 30001
16:03:42        │ proc  [kibana]   log   [16:03:42.236] [debug][chromium-driver-factory][reporting] Output dimensions is {"x":0,"y":0,"width":2120,"height":808}
16:03:42        │ proc  [kibana]   log   [16:03:42.236] [debug][chromium-driver-factory][reporting] Input png w: 1950 and h: 808
16:03:42        │ proc  [kibana]   log   [16:03:42.236] [debug][chromium-driver-factory][reporting] Creating output png with {"x":0,"y":0,"width":1950,"height":808}
16:03:42        │ proc  [kibana]   log   [16:03:42.582] [debug][kibana-monitoring][monitoring-ui] Fetching data from kibana collector
16:03:42        │ proc  [kibana]   log   [16:03:42.583] [debug][kibana-monitoring][monitoring-ui] Fetching data from kibana_stats collector
16:03:42        │ proc  [kibana]   log   [16:03:42.583] [debug][kibana-monitoring][monitoring-ui] Fetching data from kibana_settings collector
16:03:42        │ proc  [kibana]   log   [16:03:42.584] [debug][kibana-monitoring][monitoring-ui] Fetching data from reporting_stats collector
16:03:42        │ proc  [kibana]   log   [16:03:42.591] [debug][plugin] Checking Elasticsearch version
16:03:42        │ proc  [kibana]   log   [16:03:42.596] [debug][reporting][screenshots] screenshot took 781ms
16:03:42        │ proc  [kibana]   log   [16:03:42.706] [debug][kibana-monitoring][monitoring-ui] not sending [kibana_settings] monitoring document because [undefined] is null or invalid.
16:03:42        │ proc  [kibana]   log   [16:03:42.731] [debug][kibana-monitoring][monitoring-ui] Uploading bulk stats payload to the local cluster
16:03:43        │ proc  [kibana]   log   [16:03:43.212] [debug][esqueue][reporting][worker] jilvmdmm0lk0056de57n8kxd - Completed job jilvosqq0lk0056de55z6p48
16:03:43        │ proc  [kibana]   log   [16:03:43.229] [debug][reporting][worker] PDF: Worker completed: (jilvosqq0lk0056de55z6p48)

@stacey-gammon
Copy link
Author

jenkins, test this

@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elastic elastic deleted a comment from elasticmachine Jun 19, 2018
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon stacey-gammon force-pushed the 2018-06-13-chromium-png-bug-tests branch from 7e0b3c2 to 71a4fd7 Compare June 25, 2018 00:54
@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Author

Sweet, hit the bug:

16:47:42                    │ proc  [kibana]   log   [16:47:42.106] [debug][reporting][screenshots] positioning elements
16:47:42                    │ proc  [kibana]   log   [16:47:42.106] [debug][reporting][screenshots] waiting for rendering to complete
16:47:42                    │ proc  [kibana]   log   [16:47:42.133] [debug][browser][reporting][screenshots] [0626/164742.133021:VERBOSE1:network_delegate.cc(31)] NetworkDelegate::NotifyBeforeURLRequest: http://localhost:5640/elasticsearch/_msearch
16:47:42                    │ proc  [kibana] 
16:47:42                    │ proc  [kibana]   log   [16:47:42.135] [debug][basic][security] Trying to authenticate user request to /elasticsearch/_msearch.
16:47:42                    │ proc  [kibana]   log   [16:47:42.135] [debug][basic][security] Trying to authenticate via header.
16:47:42                    │ proc  [kibana]   log   [16:47:42.138] [debug][basic][security] Request has been authenticated via header.
16:47:42                    │ proc  [kibana] respons [16:47:42.134]  POST /elasticsearch/_msearch 200 33ms - 9.0B
16:47:42                    │ proc  [kibana]   log   [16:47:42.395] [debug][reporting][screenshots] rendering is complete
16:47:42                    │ proc  [kibana]   log   [16:47:42.397] [debug][reporting][screenshots] timeRange from 2018-04-09T21:56:08Z to 2018-04-11T21:56:08Z
16:47:42                    │ proc  [kibana]   log   [16:47:42.400] [debug][reporting][screenshots] taking screenshots
16:47:42                    │ proc  [kibana]   log   [16:47:42.400] [debug][chromium-driver-factory][reporting] elementPosition is not null, boundingClientRect is {"top":0,"left":0,"width":1002,"height":441}
16:47:42                    │ proc  [kibana]   log   [16:47:42.950] [debug][chromium-driver-factory][reporting] Captured screenshot clip {"height":441,"width":975,"x":0,"y":0}
16:47:42                    │ proc  [kibana]   log   [16:47:42.994] [debug][chromium-driver-factory][reporting] Captured screenshot clip {"height":441,"width":27,"x":975,"y":0}
16:47:42                    │ proc  [kibana]   log   [16:47:42.994] [debug][chromium-driver-factory][reporting] Combining screenshot clips into final, scaled output dimension of {"height":882,"width":2004}
16:47:43                    │ proc  [kibana]   log   [16:47:43.167] [error][chromium-driver-factory][reporting] Screenshot captured with width:54 and height: 441) is not of expected width: 54 and height: 882
16:47:43                    │ proc  [kibana]   log   [16:47:43.178] [debug][esqueue][reporting][worker] jivxbh6f054ladd59bfofrkw - Failure occurred on job jivxbze8054ladd59b97emp6: Error: Screenshot captured with width:54 and height: 441) is not of expected width: 54 and height: 882
16:47:43                    │ proc  [kibana]     at Rx.from.pipe.operators_1.mergeMap (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/x-pack/plugins/reporting/server/browsers/chromium/driver/screenshot_stitcher/combine.js:59:19)
16:47:43                    │ proc  [kibana]     at MapSubscriber.project (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/rxjs/internal/operators/mergeMap.js:20:157)
16:47:43                    │ proc  [kibana]     at MapSubscriber._next (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/rxjs/internal/operators/map.js:46:35)
16:47:43                    │ proc  [kibana]     at MapSubscriber.Subscriber.next (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/rxjs/internal/Subscriber.js:64:18)
16:47:43                    │ proc  [kibana]     at AsyncSubject.Subject.next (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/rxjs/internal/Subject.js:57:25)
16:47:43                    │ proc  [kibana]     at AsyncSubject.complete (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/rxjs/internal/AsyncSubject.js:50:35)
16:47:43                    │ proc  [kibana]     at handler (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/rxjs/internal/observable/bindNodeCallback.js:52:33)
16:47:43                    │ proc  [kibana]     at exports.PNG.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/pngjs/lib/png.js:75:7)
16:47:43                    │ proc  [kibana]     at Object.onceWrapper (events.js:315:30)
16:47:43                    │ proc  [kibana]     at emitOne (events.js:116:13)
16:47:43                    │ proc  [kibana]     at exports.PNG.emit (events.js:211:7)
16:47:43                    │ proc  [kibana]     at exports.PNG.<anonymous> (/var/lib/jenkins/workspace/elastic+kibana+pull-request+multijob-x-pack/install/kibana/node_modules/pngjs/lib/png.js:37:10)
16:47:43                    │ proc  [kibana]     at emitOne (events.js:116:13)
16:47:43                    │ proc  [kibana]     at module.exports.emit (events.js:211:7)
16:47:43                    │ proc  [kibana]     at module.exports.ParserAsync._complete (/var/lib/jenkins/workspace/elastic+kibana+pull-request+mu

Lets see if I'll hit it every time now.

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Author

adding the retry caused all the reporting tests to pass - not because the error was caught and retried but because the error was never caught. Could be the timing of adding in the PNG creation??

lets just try again.

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon stacey-gammon force-pushed the 2018-06-13-chromium-png-bug-tests branch from d6ceda2 to 851e4ef Compare June 27, 2018 16:08
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon stacey-gammon force-pushed the 2018-06-13-chromium-png-bug-tests branch from 9274328 to dd3c1f3 Compare July 10, 2018 14:06
@elasticmachine
Copy link
Contributor

💔 Build Failed

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Author

failed on #20640 but xpack tests passed. Although now I notice that's because the api reporting tests are being skipped.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@stacey-gammon
Copy link
Author

Check it out @kobelb - no more issues when I pushed the png creation earlier. I wonder if there is some bug with the parsing of the png in Rx. This code specifically:

// Turn the screenshot data into actual PNGs
  const pngs$ = Rx.from(screenshots).pipe(
    mergeMap(
      (screenshot: Screenshot): ObservableInput<PNG> => {
        const png = new PNG();
        const buffer = Buffer.from(screenshot.data, 'base64');
        const parseAsObservable = Rx.bindNodeCallback(png.parse.bind(png));
        return parseAsObservable(buffer);
      },
      }

Reading up on bindNodeCallback, this seems like it should all work. Perhaps I should try to take Rx out of the equation and do the png conversion manually here and see if that fixes it. ughghghgh.

@stacey-gammon
Copy link
Author

lets try again.

jenkins, test this

@elasticmachine
Copy link
Contributor

💔 Build Failed

@stacey-gammon
Copy link
Author

xpack passed, failure was on oss

@stacey-gammon
Copy link
Author

closing in favor of #20770

@stacey-gammon stacey-gammon deleted the 2018-06-13-chromium-png-bug-tests branch June 11, 2019 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

zDeprecated Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chromium: capture png size error

2 participants