Skip to content

[ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k#198504

Merged
guskovaue merged 2 commits intoelastic:mainfrom
guskovaue:MX-increase-mw-limit-to-1k
Oct 31, 2024
Merged

[ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k#198504
guskovaue merged 2 commits intoelastic:mainfrom
guskovaue:MX-increase-mw-limit-to-1k

Conversation

@guskovaue
Copy link
Copy Markdown
Contributor

@guskovaue guskovaue commented Oct 31, 2024

Here in this PR I am increasing the limit for MW to 1K.
Even I've changed schema for query params(deleted maybe) I did not add additional tests, because we already have one integration test for the case, when we do not have page and per_page params.

@guskovaue guskovaue added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v9.0.0 Feature:Alerting/RulesManagement Issues related to the Rules Management UX backport:prev-minor v8.16.0 v8.17.0 labels Oct 31, 2024
@guskovaue guskovaue self-assigned this Oct 31, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

💚 Build Succeeded

Metrics [docs]

✅ unchanged

cc @guskovaue

@guskovaue guskovaue marked this pull request as ready for review October 31, 2024 14:05
@guskovaue guskovaue requested a review from a team as a code owner October 31, 2024 14:05
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

Copy link
Copy Markdown
Member

@cnasikas cnasikas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and LGTM!

@guskovaue guskovaue merged commit 3413cbb into elastic:main Oct 31, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11614071292

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.15:
- Update ftr (main) (#198455)
8.16 Backport failed because of merge conflicts

You might need to backport the following PRs to 8.16:
- Update docker.elastic.co/wolfi/chainguard-base:latest Docker digest to 7082adc (main) (#198500)
- Update ftr (main) (#198455)
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 198504

Questions ?

Please refer to the Backport tool documentation

@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11615475701

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 31, 2024
…c#198504)

Here in this PR I am increasing the limit for MW to 1K.
Even I've changed schema for query params(deleted maybe) I did not add
additional tests, because we already have one integration test for the
case, when we do not have `page` and `per_page` params.

(cherry picked from commit 3413cbb)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.16 Backport failed because of merge conflicts
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 198504

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 31, 2024
…198504) (#198551)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k
(#198504)](#198504)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-31T14:40:36Z","message":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to 1k (#198504)\n\nHere in this PR I am
increasing the limit for MW to 1K.\r\nEven I've changed schema for query
params(deleted maybe) I did not add\r\nadditional tests, because we
already have one integration test for the\r\ncase, when we do not have
`page` and `per_page`
params.","sha":"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RulesManagement","backport:prev-major","v8.16.0","v8.17.0"],"title":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to
1k","number":198504,"url":"https://github.com/elastic/kibana/pull/198504","mergeCommit":{"message":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to 1k (#198504)\n\nHere in this PR I am
increasing the limit for MW to 1K.\r\nEven I've changed schema for query
params(deleted maybe) I did not add\r\nadditional tests, because we
already have one integration test for the\r\ncase, when we do not have
`page` and `per_page`
params.","sha":"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198504","number":198504,"mergeCommit":{"message":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to 1k (#198504)\n\nHere in this PR I am
increasing the limit for MW to 1K.\r\nEven I've changed schema for query
params(deleted maybe) I did not add\r\nadditional tests, because we
already have one integration test for the\r\ncase, when we do not have
`page` and `per_page`
params.","sha":"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julia <iuliia.guskova@elastic.co>
cnasikas pushed a commit to cnasikas/kibana that referenced this pull request Nov 1, 2024
…c#198504)

Here in this PR I am increasing the limit for MW to 1K.
Even I've changed schema for query params(deleted maybe) I did not add
additional tests, because we already have one integration test for the
case, when we do not have `page` and `per_page` params.

(cherry picked from commit 3413cbb)
cnasikas added a commit that referenced this pull request Nov 1, 2024
…198504) (#198662)

# Backport

This will backport the following commits from `main` to `8.16`:
- [ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k
(#198504) (3413cbb)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-31T14:40:36Z","message":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to 1k (#198504)\n\nHere in this PR I am
increasing the limit for MW to 1K.\r\nEven I've changed schema for query
params(deleted maybe) I did not add\r\nadditional tests, because we
already have one integration test for the\r\ncase, when we do not have
`page` and `per_page`
params.","sha":"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8"},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[]}]
BACKPORT-->

Co-authored-by: Julia <iuliia.guskova@elastic.co>
nreese pushed a commit to nreese/kibana that referenced this pull request Nov 1, 2024
…c#198504)

Here in this PR I am increasing the limit for MW to 1K.
Even I've changed schema for query params(deleted maybe) I did not add
additional tests, because we already have one integration test for the
case, when we do not have `page` and `per_page` params.
@cnasikas cnasikas mentioned this pull request Nov 4, 2024
12 tasks
@cnasikas
Copy link
Copy Markdown
Member

cnasikas commented Nov 9, 2024

💚 All backports created successfully

Status Branch Result
8.15

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cnasikas pushed a commit to cnasikas/kibana that referenced this pull request Nov 9, 2024
…c#198504)

Here in this PR I am increasing the limit for MW to 1K.
Even I've changed schema for query params(deleted maybe) I did not add
additional tests, because we already have one integration test for the
case, when we do not have `page` and `per_page` params.

(cherry picked from commit 3413cbb)
cnasikas added a commit that referenced this pull request Nov 11, 2024
…198504) (#199576)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k
(#198504)](#198504)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Julia","email":"iuliia.guskova@elastic.co"},"sourceCommit":{"committedDate":"2024-10-31T14:40:36Z","message":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to 1k (#198504)\n\nHere in this PR I am
increasing the limit for MW to 1K.\r\nEven I've changed schema for query
params(deleted maybe) I did not add\r\nadditional tests, because we
already have one integration test for the\r\ncase, when we do not have
`page` and `per_page`
params.","sha":"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Alerting/RulesManagement","backport:prev-minor","v8.16.0","v8.17.0","v8.15.5"],"number":198504,"url":"https://github.com/elastic/kibana/pull/198504","mergeCommit":{"message":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to 1k (#198504)\n\nHere in this PR I am
increasing the limit for MW to 1K.\r\nEven I've changed schema for query
params(deleted maybe) I did not add\r\nadditional tests, because we
already have one integration test for the\r\ncase, when we do not have
`page` and `per_page`
params.","sha":"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198504","number":198504,"mergeCommit":{"message":"[ResponseOps]]MaintenaceWindow]
Increase MW table limit to 1k (#198504)\n\nHere in this PR I am
increasing the limit for MW to 1K.\r\nEven I've changed schema for query
params(deleted maybe) I did not add\r\nadditional tests, because we
already have one integration test for the\r\ncase, when we do not have
`page` and `per_page`
params.","sha":"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198662","number":198662,"state":"MERGED","mergeCommit":{"sha":"62f11d0d8f0dc6f46dee4d641e4a7755d7f05278","message":"[8.16]
[ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k (#198504)
(#198662)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.16`:\n- [ResponseOps]]MaintenaceWindow] Increase MW table
limit to 1k\n(#198504) (3413cbb)\n\n<!--- Backport version: 8.9.8
-->\n\n### Questions ?\nPlease refer to the [Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"Julia\",\"email\":\"iuliia.guskova@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-10-31T14:40:36Z\",\"message\":\"[ResponseOps]]MaintenaceWindow]\nIncrease
MW table limit to 1k (#198504)\\n\\nHere in this PR I am\nincreasing the
limit for MW to 1K.\\r\\nEven I've changed schema for
query\nparams(deleted maybe) I did not add\\r\\nadditional tests,
because we\nalready have one integration test for the\\r\\ncase, when we
do not have\n`page` and
`per_page`\nparams.\",\"sha\":\"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8\"},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[]}]\nBACKPORT-->\n\nCo-authored-by:
Julia
<iuliia.guskova@elastic.co>"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198551","number":198551,"state":"MERGED","mergeCommit":{"sha":"a8d8cbdb4dd0830358824a069b8ffa814963dab5","message":"[8.x]
[ResponseOps]]MaintenaceWindow] Increase MW table limit to 1k (#198504)
(#198551)\n\n# Backport\n\nThis will backport the following commits from
`main` to `8.x`:\n- [[ResponseOps]]MaintenaceWindow] Increase MW table
limit to
1k\n(#198504)](https://github.com/elastic/kibana/pull/198504)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"Julia\",\"email\":\"iuliia.guskova@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-10-31T14:40:36Z\",\"message\":\"[ResponseOps]]MaintenaceWindow]\nIncrease
MW table limit to 1k (#198504)\\n\\nHere in this PR I am\nincreasing the
limit for MW to 1K.\\r\\nEven I've changed schema for
query\nparams(deleted maybe) I did not add\\r\\nadditional tests,
because we\nalready have one integration test for the\\r\\ncase, when we
do not have\n`page` and
`per_page`\nparams.\",\"sha\":\"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"Team:ResponseOps\",\"v9.0.0\",\"Feature:Alerting/RulesManagement\",\"backport:prev-major\",\"v8.16.0\",\"v8.17.0\"],\"title\":\"[ResponseOps]]MaintenaceWindow]\nIncrease
MW table limit
to\n1k\",\"number\":198504,\"url\":\"https://github.com/elastic/kibana/pull/198504\",\"mergeCommit\":{\"message\":\"[ResponseOps]]MaintenaceWindow]\nIncrease
MW table limit to 1k (#198504)\\n\\nHere in this PR I am\nincreasing the
limit for MW to 1K.\\r\\nEven I've changed schema for
query\nparams(deleted maybe) I did not add\\r\\nadditional tests,
because we\nalready have one integration test for the\\r\\ncase, when we
do not have\n`page` and
`per_page`\nparams.\",\"sha\":\"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\",\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198504\",\"number\":198504,\"mergeCommit\":{\"message\":\"[ResponseOps]]MaintenaceWindow]\nIncrease
MW table limit to 1k (#198504)\\n\\nHere in this PR I am\nincreasing the
limit for MW to 1K.\\r\\nEven I've changed schema for
query\nparams(deleted maybe) I did not add\\r\\nadditional tests,
because we\nalready have one integration test for the\\r\\ncase, when we
do not have\n`page` and
`per_page`\nparams.\",\"sha\":\"3413cbbb1bbe323f40cb9c6b9ff7a98a32b534d8\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.x\",\"label\":\"v8.17.0\",\"branchLabelMappingKey\":\"^v8.17.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by:
Julia
<iuliia.guskova@elastic.co>"}},{"branch":"8.15","label":"v8.15.5","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Julia <iuliia.guskova@elastic.co>
@mistic
Copy link
Copy Markdown
Contributor

mistic commented Nov 12, 2024

This PR didn't make on time to the latest 8.16.0 and 8.15.4 BC. Updating the labels.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Feature:Alerting/RulesManagement Issues related to the Rules Management UX release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Platform ResponseOps team (formerly the Cases and Alerting teams) t// v8.15.5 v8.16.1 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants