Skip to content

add aria-label to select without label #19830

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 12, 2018
Merged

add aria-label to select without label #19830

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions ...lugins/input_control_vis/public/components/editor/__snapshots__/controls_tab.test.js.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,7 @@ exports[`renders ControlsTab 1`] = `
id="selectControlType"
>
<EuiSelect
aria-label="Select control type"
compressed={false}
fullWidth={false}
hasNoInitialSelection={false}
Expand Down Expand Up @@ -130,6 +131,7 @@ exports[`renders ControlsTab 1`] = `
id="addControl"
>
<EuiButton
aria-label="Add control"
color="primary"
data-test-subj="inputControlEditorAddBtn"
fill={true}
Expand Down
2 changes: 2 additions & 0 deletions src/core_plugins/input_control_vis/public/components/editor/controls_tab.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -157,6 +157,7 @@ export class ControlsTab extends Component {
]}
value={this.state.type}
onChange={evt => this.setState({ type: evt.target.value })}
aria-label="Select control type"
/>
</EuiFormRow>
</EuiFlexItem>
Expand All @@ -169,6 +170,7 @@ export class ControlsTab extends Component {
onClick={this.handleAddControl}
iconType="plusInCircle"
data-test-subj="inputControlEditorAddBtn"
aria-label="Add control"
>
Add
</EuiButton>
Expand Down