[ML] Fixes agg-type dropdowns size and styling. #19816
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Pinging @elastic/ml-ui |
Contributor
💚 Build Succeeded |
walterra
added a commit
to walterra/kibana
that referenced
this pull request
Jun 13, 2018
- Fixes an issue with cut off text within aggregation type dropdowns in the multi-metric and population wizard. - Fixes the style of the dropdown to be consistent across browsers. - Fixes 1px vertical offset between dropdown and trash-icon.
walterra
added a commit
that referenced
this pull request
Jun 13, 2018
- Fixes an issue with cut off text within aggregation type dropdowns in the multi-metric and population wizard. - Fixes the style of the dropdown to be consistent across browsers. - Fixes 1px vertical offset between dropdown and trash-icon.
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
- Fixes an issue with cut off text within aggregation type dropdowns in the multi-metric and population wizard. - Fixes the style of the dropdown to be consistent across browsers. - Fixes 1px vertical offset between dropdown and trash-icon.
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #18880.
1pxvertical offset between dropdown and trash-icon.Before (macOS Chrome/Safari/Firefox)
Multi-Metric
Population
After (macOS Chrome/Safari/Firefox)
Multi-Metric
Population
The icons in the dropdowns now match the ones ones in other
ui-selectbased components.(couldn't do IE11 testing because there's currently an issue with EUI in IE11)