Skip to content

Conversation

@walterra
Copy link
Contributor

Fixes #18873 by migrating the advanced job wizard's page wrapping HTML to use EUI.

The original issue could occur when @media queries set the width of the content to a wider width than the available width because it didn't consider the left main menu's width.

Before and after:

@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui

Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

💔 Build Failed

@walterra
Copy link
Contributor Author

jenkins retest this.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@walterra walterra merged commit 0b73671 into elastic:master Jun 12, 2018
walterra added a commit to walterra/kibana that referenced this pull request Jun 12, 2018
@walterra walterra deleted the ml-fix-advanced-wizard-width branch June 12, 2018 13:04
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants