[ML] Fix the Trained Models table expanded row refresh #198149
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darnautov
added
Team:ML
Contributor
|
Pinging @elastic/ml-ui (:ml) |
rbrtj
approved these changes
Oct 29, 2024
Contributor
rbrtj
left a comment
rbrtj
left a comment
There was a problem hiding this comment.
LGTM, tested and worked fine 👍
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
cc @darnautov |
peteharverson
requested review from
jgowdyelastic
and removed request for
peteharverson
Contributor
|
Starting backport for target branches: 8.16 https://github.com/elastic/kibana/actions/runs/11596565652 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
## Summary Fixes a regression introduced in elastic#194614, where the content of expanded rows in the Trained Model table stopped being updated on refresh. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 7e05d5c)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
… (#198391) # Backport This will backport the following commits from `main` to `8.16`: - [[ML] Fix the Trained Models table expanded row refresh (#198149)](#198149) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:34:29Z","message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:3rd Party Models","Team:ML","v8.16.0","backport:version"],"title":"[ML] Fix the Trained Models table expanded row refresh","number":198149,"url":"https://github.com/elastic/kibana/pull/198149","mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198149","number":198149,"mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
darnautov
added
v8.17.0
and removed
backport:version
Contributor
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11609519297 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 31, 2024
## Summary Fixes a regression introduced in elastic#194614, where the content of expanded rows in the Trained Model table stopped being updated on refresh. Co-authored-by: Elastic Machine <[email protected]> (cherry picked from commit 7e05d5c)
Contributor
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 31, 2024
#198484) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Fix the Trained Models table expanded row refresh (#198149)](#198149) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Dima Arnautov","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:34:29Z","message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:fix",":ml","v9.0.0","Feature:3rd Party Models","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML] Fix the Trained Models table expanded row refresh","number":198149,"url":"https://github.com/elastic/kibana/pull/198149","mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198149","number":198149,"mergeCommit":{"message":"[ML] Fix the Trained Models table expanded row refresh (#198149)\n\n## Summary\r\n\r\nFixes a regression introduced in\r\nhttps://github.com//pull/194614/, where the content of\r\nexpanded rows in the Trained Model table stopped being updated on\r\nrefresh.\r\n\r\nCo-authored-by: Elastic Machine <[email protected]>","sha":"7e05d5c2e8084212584770fa52fe5701e2dd2166"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/198391","number":198391,"state":"MERGED","mergeCommit":{"sha":"8d3515762850843c99545881d5b43b024b5a8bd2","message":"[8.16] [ML] Fix the Trained Models table expanded row refresh (#198149) (#198391)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.16`:\n- [[ML] Fix the Trained Models table expanded row refresh\n(#198149)](https://github.com/elastic/kibana/pull/198149)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT [{\"author\":{\"name\":\"Dima\nArnautov\",\"email\":\"[email protected]\"},\"sourceCommit\":{\"committedDate\":\"2024-10-30T15:34:29Z\",\"message\":\"[ML]\nFix the Trained Models table expanded row refresh (#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression introduced\nin\\r\\nhttps://github.com//pull/194614/, where the content\nof\\r\\nexpanded rows in the Trained Model table stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:fix\",\":ml\",\"v9.0.0\",\"Feature:3rd\nParty Models\",\"Team:ML\",\"v8.16.0\",\"backport:version\"],\"title\":\"[ML] Fix\nthe Trained Models table expanded row\nrefresh\",\"number\":198149,\"url\":\"https://github.com/elastic/kibana/pull/198149\",\"mergeCommit\":{\"message\":\"[ML]\nFix the Trained Models table expanded row refresh (#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression introduced\nin\\r\\nhttps://github.com//pull/194614/, where the content\nof\\r\\nexpanded rows in the Trained Model table stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.16\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/198149\",\"number\":198149,\"mergeCommit\":{\"message\":\"[ML]\nFix the Trained Models table expanded row refresh (#198149)\\n\\n##\nSummary\\r\\n\\r\\nFixes a regression introduced\nin\\r\\nhttps://github.com//pull/194614/, where the content\nof\\r\\nexpanded rows in the Trained Model table stopped being updated\non\\r\\nrefresh.\\r\\n\\r\\nCo-authored-by: Elastic Machine\n<[email protected]>\",\"sha\":\"7e05d5c2e8084212584770fa52fe5701e2dd2166\"}},{\"branch\":\"8.16\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: Dima Arnautov <[email protected]>"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Dima Arnautov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a regression introduced in #194614, where the content of expanded rows in the Trained Model table stopped being updated on refresh.