Add option to exclude tests in functional test runner #19806
Conversation
💚 Build Succeeded |
There was a problem hiding this comment.
Pulled the changes and confirmed that --invert was passed through to mocha and works as intended. One nitpick, but otherwise LGTM!
For the record, these are two pretty different changes and should probably be in two different PRs. They're both so small and I feel like there isn't much debating the approach, so no reason to split it up now. But for next time.
| const PageObjects = getPageObjects(['common', 'home', 'settings']); | ||
|
|
||
| describe('test large number of fields', function () { | ||
| describe('@skipcloud test large number of fields', function () { |
There was a problem hiding this comment.
I can't think of a better way to do this though, aside from hard coding the test names in the cloud test runner, but I'd prefer if we put directives like this at the end of the test/suite name.
|
Thanks for the review @spalger! I agree these should have been two PRs, I was thinking about doing that, but since the changes were so small I grouped them together, but will separate items like these next time. Also, I moved the tag name to the end of the test name. Will merge once CI is green. |
💚 Build Succeeded |
* Add option to exclude tests in functional test runner * Move tag to end of test name
* Add option to exclude tests in functional test runner * Move tag to end of test name
* Add option to exclude tests in functional test runner * Move tag to end of test name
3 participants
Adding option to exclude tests in functional test runner. Also adding a tag for the test that is not applicable to be run on cloud.
Issue #19228