[DataUsage][Serverless] Add missing tests#198007
Merged
ashokaditya merged 10 commits intoelastic:mainfrom Nov 7, 2024
Merged
Conversation
ashokaditya
added
release_note:skip
ashokaditya
force-pushed
the
task/serverless-data-usage-tests
branch
4 times, most recently
from
b373558 to
0f0119e
Compare
Member
Author
|
/ci |
ashokaditya
force-pushed
the
task/serverless-data-usage-tests
branch
from
0f0119e to
486ad91
Compare
Member
Author
|
/ci |
ashokaditya
force-pushed
the
task/serverless-data-usage-tests
branch
7 times, most recently
from
31465b1 to
f159af5
Compare
ashokaditya
force-pushed
the
task/serverless-data-usage-tests
branch
from
f159af5 to
13aa1b1
Compare
ashokaditya
commented
Nov 6, 2024
| storageSizeBytes: stat.size_in_bytes ?? 0, | ||
| })); | ||
| const body = | ||
| meteringStats && !!meteringStats.length |
Member
Author
There was a problem hiding this comment.
@neptunian I added this change just in case the metering stats API does not return anything useful.
ashokaditya
commented
Nov 6, 2024
| }); | ||
| }); | ||
|
|
||
| it.each([ |
Member
Author
There was a problem hiding this comment.
@neptunian and the tests for that change here
neptunian
approved these changes
Nov 6, 2024
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11730353082 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
Unknown metric groupsESLint disabled in files
Total ESLint disabled count
History
cc @ashokaditya |
kibanamachine
added a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 7, 2024
## Summary Adds missing UX/API tests for changes added in - elastic#193966 - elastic#197056 - elastic#195556 - elastic#196559 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> (cherry picked from commit 207894e)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
4 tasks
kibanamachine
added a commit
that referenced
this pull request
Nov 7, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[DataUsage][Serverless] Add missing tests (#198007)](#198007) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Ash","email":"1849116+ashokaditya@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-11-07T19:57:46Z","message":"[DataUsage][Serverless] Add missing tests (#198007)\n\n## Summary\r\n\r\nAdds missing UX/API tests for changes added in \r\n- https://github.com/elastic/kibana/pull/193966\r\n- https://github.com/elastic/kibana/pull/197056\r\n- https://github.com/elastic/kibana/pull/195556\r\n- https://github.com/elastic/kibana/pull/196559\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"207894edd5c8bd2530dee2f54d47b4f497aa3687","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:version","v8.17.0"],"title":"[DataUsage][Serverless] Add missing tests","number":198007,"url":"https://github.com/elastic/kibana/pull/198007","mergeCommit":{"message":"[DataUsage][Serverless] Add missing tests (#198007)\n\n## Summary\r\n\r\nAdds missing UX/API tests for changes added in \r\n- https://github.com/elastic/kibana/pull/193966\r\n- https://github.com/elastic/kibana/pull/197056\r\n- https://github.com/elastic/kibana/pull/195556\r\n- https://github.com/elastic/kibana/pull/196559\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"207894edd5c8bd2530dee2f54d47b4f497aa3687"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/198007","number":198007,"mergeCommit":{"message":"[DataUsage][Serverless] Add missing tests (#198007)\n\n## Summary\r\n\r\nAdds missing UX/API tests for changes added in \r\n- https://github.com/elastic/kibana/pull/193966\r\n- https://github.com/elastic/kibana/pull/197056\r\n- https://github.com/elastic/kibana/pull/195556\r\n- https://github.com/elastic/kibana/pull/196559\r\n\r\n\r\n### Checklist\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>","sha":"207894edd5c8bd2530dee2f54d47b4f497aa3687"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Ash <1849116+ashokaditya@users.noreply.github.com>
mbondyra
pushed a commit
to mbondyra/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Adds missing UX/API tests for changes added in - elastic#193966 - elastic#197056 - elastic#195556 - elastic#196559 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
CAWilson94
pushed a commit
to CAWilson94/kibana
that referenced
this pull request
Nov 8, 2024
## Summary Adds missing UX/API tests for changes added in - elastic#193966 - elastic#197056 - elastic#195556 - elastic#196559 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds missing UX/API tests for changes added in
Checklist