Skip to content

remove redux tools from presentation_utils plugin#197891

Merged
nreese merged 5 commits intoelastic:mainfrom
nreese:remove_redux_tools
Dec 10, 2024
Merged

remove redux tools from presentation_utils plugin#197891
nreese merged 5 commits intoelastic:mainfrom
nreese:remove_redux_tools

Conversation

@nreese
Copy link
Copy Markdown
Contributor

@nreese nreese commented Oct 25, 2024 •
edited by kibanamachine
Loading

null

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Oct 25, 2024

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Oct 25, 2024

/ci

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Dec 10, 2024

@elasticmachine merge upstream

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Dec 10, 2024

/ci

@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Dec 10, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

@nreese
Copy link
Copy Markdown
Contributor Author

nreese commented Dec 10, 2024

/ci

@nreese nreese added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// release_note:skip Skip the PR/issue when compiling release notes v9.0.0 project:embeddableRebuild backport:version Backport to applied version labels v8.18.0 labels Dec 10, 2024
@nreese nreese marked this pull request as ready for review December 10, 2024 21:27
@nreese nreese requested a review from a team as a code owner December 10, 2024 21:27
ThomThomson
ThomThomson approved these changes Dec 10, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@ThomThomson ThomThomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this removed!

@nreese nreese merged commit fb885ea into elastic:main Dec 10, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 10, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/12265564331

kibanamachine added a commit to kibanamachine/kibana that referenced this pull request Dec 10, 2024
@nreese @kibanamachine @elasticmachine
remove redux tools from presentation_utils plugin (elastic#197891)
dc531b5 
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
(cherry picked from commit fb885ea)
@kibanamachine kibanamachine mentioned this pull request Dec 10, 2024
Merged
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Dec 10, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Dec 10, 2024
Merged
5 tasks
kibanamachine added a commit that referenced this pull request Dec 11, 2024
@kibanamachine @nreese
[8.x] remove redux tools from presentation_utils plugin (#197891) (#2…
7a8c311 
…03701)

# Backport

This will backport the following commits from `main` to `8.x`:
- [remove redux tools from presentation_utils plugin
(#197891)](#197891)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Nathan
Reese","email":"reese.nathan@elastic.co"},"sourceCommit":{"committedDate":"2024-12-10T22:08:01Z","message":"remove
redux tools from presentation_utils plugin (#197891)\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fb885eaeffcdbbcab399f11ab1e8e524b174bd69","branchLabelMapping":{"^v9.0.0$":"main","^v8.18.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Presentation","release_note:skip","v9.0.0","project:embeddableRebuild","backport:version","v8.18.0"],"title":"remove
redux tools from presentation_utils
plugin","number":197891,"url":"https://github.com/elastic/kibana/pull/197891","mergeCommit":{"message":"remove
redux tools from presentation_utils plugin (#197891)\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fb885eaeffcdbbcab399f11ab1e8e524b174bd69"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197891","number":197891,"mergeCommit":{"message":"remove
redux tools from presentation_utils plugin (#197891)\n\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by:
Elastic Machine
<elasticmachine@users.noreply.github.com>","sha":"fb885eaeffcdbbcab399f11ab1e8e524b174bd69"}},{"branch":"8.x","label":"v8.18.0","branchLabelMappingKey":"^v8.18.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Nathan Reese <reese.nathan@elastic.co>
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Dec 12, 2024
@nreese @kibanamachine
@elasticmachine @CAWilson94
remove redux tools from presentation_utils plugin (elastic#197891)
e7ed964 
Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Co-authored-by: Elastic Machine <elasticmachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ThomThomson ThomThomson ThomThomson approved these changes

Assignees

No one assigned

Labels

backport:version Backport to applied version labels project:embeddableRebuild release_note:skip Skip the PR/issue when compiling release notes Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas t// v8.18.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@nreese @elasticmachine @kibanamachine @ThomThomson