[Dashboard/Markdown] Add tabindex #197848
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kowalczyk-krzysztof
added
bug
kibanamachine
added
Team:Presentation
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
2 similar comments
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Contributor
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
kowalczyk-krzysztof
added
loe:small
Member
Author
|
Looks like the |
kowalczyk-krzysztof
force-pushed
the
fix/dashboard-markdown-panel
branch
from
81e3b51 to
adff184
Compare
kowalczyk-krzysztof
changed the title
Member
Author
So EDIT: Link to an issue about standardizing markdown across kibana, which I didn't know existed before I tried replacing markdown in this PR. |
Heenawter
approved these changes
Oct 30, 2024
Contributor
Heenawter
left a comment
Heenawter
left a comment
There was a problem hiding this comment.
Adding tabIndex LGTM - quick test locally to ensure keyboard interactivity + code review 👍
Contributor
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
Contributor
|
Starting backport for target branches: 8.x https://github.com/elastic/kibana/actions/runs/11596906820 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 30, 2024
## Summary This PR adds `tabIndex` to [markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f). Closes: elastic#186559 ## Visuals: https://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f This video demonstrates the markdown panel being tabbable and the scrollbar in being controlled with keyboard. (cherry picked from commit 6cc8b97)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 30, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Dashboard/Markdown] Add tabindex (#197848)](#197848) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Krzysztof Kowalczyk","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-30T15:53:19Z","message":"[Dashboard/Markdown] Add tabindex (#197848)\n\n## Summary\r\n\r\nThis PR adds `tabIndex` to\r\n[markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f).\r\n\r\nCloses: #186559\r\n\r\n## Visuals:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f\r\n\r\nThis video demonstrates the markdown panel being tabbable and the\r\nscrollbar in being controlled with keyboard.","sha":"6cc8b97b60e78bf0638fa91b0925eb944133841a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","Feature:Dashboard","Feature:Markdown","Team:Presentation","loe:small","release_note:skip","impact:medium","v9.0.0","backport:prev-minor"],"title":"[Dashboard/Markdown] Add tabindex","number":197848,"url":"https://github.com/elastic/kibana/pull/197848","mergeCommit":{"message":"[Dashboard/Markdown] Add tabindex (#197848)\n\n## Summary\r\n\r\nThis PR adds `tabIndex` to\r\n[markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f).\r\n\r\nCloses: #186559\r\n\r\n## Visuals:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f\r\n\r\nThis video demonstrates the markdown panel being tabbable and the\r\nscrollbar in being controlled with keyboard.","sha":"6cc8b97b60e78bf0638fa91b0925eb944133841a"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197848","number":197848,"mergeCommit":{"message":"[Dashboard/Markdown] Add tabindex (#197848)\n\n## Summary\r\n\r\nThis PR adds `tabIndex` to\r\n[markdown_vis_controller.tsx](https://github.com/elastic/kibana/compare/main...kowalczyk-krzysztof:kibana:fix/dashboard-markdown-panel?expand=1#diff-47267cf2f7d8f9e72e157ddb40292226a88ad5e51f9c92486799d381c5085e5f).\r\n\r\nCloses: #186559\r\n\r\n## Visuals:\r\n\r\n\r\nhttps://github.com/user-attachments/assets/8264c584-e7ca-4647-946a-7b9bd9f7aa8f\r\n\r\nThis video demonstrates the markdown panel being tabbable and the\r\nscrollbar in being controlled with keyboard.","sha":"6cc8b97b60e78bf0638fa91b0925eb944133841a"}}]}] BACKPORT--> Co-authored-by: Krzysztof Kowalczyk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
tabIndexto markdown_vis_controller.tsx.Closes: #186559
Visuals:
chrome_aWPkAz51AM.mp4
This video demonstrates the markdown panel being tabbable and the scrollbar in being controlled with keyboard.