[Global search bar] Fix search bar outline disappeared#197790
Closed
viajes7 wants to merge 2 commits intoelastic:mainfrom
Closed
[Global search bar] Fix search bar outline disappeared#197790viajes7 wants to merge 2 commits intoelastic:mainfrom
viajes7 wants to merge 2 commits intoelastic:mainfrom
Conversation
Contributor
Author
|
And maybe it should add a test case? Waiting for your message. |
Contributor
Author
|
@elasticmachine merge upstream |
Contributor
Contributor
|
@sebelga, pls see: #197542 (comment) |
Contributor
|
Hey y'all - you read our minds, EUI has a fix for this coming soon: elastic/eui#8100 Would you all want us to backport this fix to 8.16 as well? |
Contributor
|
@cee-chen, great news thank you. I think 8.16 would be nice, but not critical |
cee-chen
added a commit
that referenced
this pull request
Oct 31, 2024
`97.0.0-backport.0`⏩`97.0.0-backport.1` This backport release addresses #197542 and #197790 (comment) --- ## [`v97.0.0-backport.1`](https://github.com/elastic/eui/releases/v97.0.0-backport.1) **This is a backport release only intended for use by Kibana.** **Bug fixes** - Fixed `EuiSelectableTemplateSitewide`s within dark-themed `EuiHeader`s missing input borders ([#8100](elastic/eui#8100))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #197542
In Eui
header.styles.ts, add a border-color to form control group.But if the search bar is clearable, this style will not be applied.
So, I'm considering if we can add a border to the input element when it's clearable.
After fixup: