[ResponseOps] Cleanup alerting RBAC exception code #197719
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
doakalexi
changed the title
doakalexi
added
Team:ResponseOps
Contributor
|
Pinging @elastic/response-ops (Team:ResponseOps) |
ymao1
reviewed
Oct 28, 2024
| }); | ||
|
|
||
| describe('execute()', () => { | ||
| describe('authorization', () => { |
Contributor
There was a problem hiding this comment.
we should keep the RBAC authorization tests right?
Contributor
Author
There was a problem hiding this comment.
Yes you're right! I prob shouldn't have removed all of them
ymao1
approved these changes
Oct 28, 2024
Contributor
ymao1
left a comment
ymao1
left a comment
There was a problem hiding this comment.
LGTM, just one comment about keeping some RBAC auth tests.
Contributor
💚 Build Succeeded
Metrics [docs]Unknown metric groupsESLint disabled line counts
Total ESLint disabled count
History
cc @doakalexi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves https://github.com/elastic/response-ops-team/issues/250
Summary
This PR eliminates the alerting RBAC exemption code. It removes all references to
getAuthorizationModeBySourceandbulkGetAuthorizationModeBySource, along with the corresponding legacy RBAC usage counters. Additionally, downstream code paths that rely on RBAC for authorization have been updated, and all related test cases have been removed.