Skip to content

Conversation

@bmcconaghy
Copy link
Contributor

Ups to EUI 0.0.52 and updates snapshot tests.

Copy link
Contributor

@cjcenizal cjcenizal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

exports[`LicenseStatus component should display display warning is expired 1`] = `"<div><div class=\\"euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceAround euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><div class=\\"euiFlexGroup euiFlexGroup--gutterSmall euiFlexGroup--alignItemsCenter euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><svg class=\\"euiIcon euiIcon--medium euiIcon--danger\\" focusable=\\"false\\" xmlns=\\"http://www.w3.org/2000/svg\\" width=\\"16\\" height=\\"16\\" viewBox=\\"0 0 16 16\\"><g fill-rule=\\"evenodd\\"><path d=\\"M7.5 2.236L1.618 14h11.764L7.5 2.236zm.894-.447l5.882 11.764A1 1 0 0 1 13.382 15H1.618a1 1 0 0 1-.894-1.447L6.606 1.789a1 1 0 0 1 1.788 0z\\"></path><path d=\\"M7 6h1v5H7zM7 12h1v1H7z\\"></path></g></svg></div><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><h2 class=\\"euiTitle euiTitle--large\\">Your Platinum license has expired</h2></div></div></div></div><div class=\\"euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceAround euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><div class=\\"euiText\\"><span class=\\"euiTextColor euiTextColor--subdued\\"><span>Your license expired on <strong></strong></span></span></div></div></div><div class=\\"euiSpacer euiSpacer--l\\"></div></div>"`;

exports[`LicenseStatus component should display normally when license is active 1`] = `"<div><div class=\\"euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceAround euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><div class=\\"euiFlexGroup euiFlexGroup--gutterSmall euiFlexGroup--alignItemsCenter euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><svg class=\\"euiIcon euiIcon--medium euiIcon--success\\" width=\\"16\\" height=\\"16\\" viewBox=\\"0 0 16 16\\" xmlns=\\"http://www.w3.org/2000/svg\\"><path d=\\"M8 16A8 8 0 1 1 8 0a8 8 0 0 1 0 16zm-1.125-5a.377.377 0 0 0 .266-.11l5.25-5.25a.376.376 0 0 0-.531-.53l-4.985 4.985L4.141 7.36a.376.376 0 0 0-.531.53l3 3c.073.073.17.11.265.11z\\" fill-rule=\\"evenodd\\"></path></svg></div><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><h2 class=\\"euiTitle euiTitle--large\\">Your Gold license is active</h2></div></div></div></div><div class=\\"euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceAround euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><div class=\\"euiText\\"><span class=\\"euiTextColor euiTextColor--subdued\\"><span>Your license will expire on <strong>October 12, 2099 7:00 PM EST</strong></span></span></div></div></div><div class=\\"euiSpacer euiSpacer--l\\"></div></div>"`;
exports[`LicenseStatus component should display normally when license is active 1`] = `"<div><div class=\\"euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceAround euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><div class=\\"euiFlexGroup euiFlexGroup--gutterSmall euiFlexGroup--alignItemsCenter euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><svg class=\\"euiIcon euiIcon--medium euiIcon--success\\" focusable=\\"false\\" width=\\"16\\" height=\\"16\\" viewBox=\\"0 0 16 16\\" xmlns=\\"http://www.w3.org/2000/svg\\"><path d=\\"M8 16A8 8 0 1 1 8 0a8 8 0 0 1 0 16zm-1.125-5a.377.377 0 0 0 .266-.11l5.25-5.25a.376.376 0 0 0-.531-.53l-4.985 4.985L4.141 7.36a.376.376 0 0 0-.531.53l3 3c.073.073.17.11.265.11z\\" fill-rule=\\"evenodd\\"></path></svg></div><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><h2 class=\\"euiTitle euiTitle--large\\">Your Gold license is active</h2></div></div></div></div><div class=\\"euiFlexGroup euiFlexGroup--gutterLarge euiFlexGroup--justifyContentSpaceAround euiFlexGroup--directionRow euiFlexGroup--responsive\\"><div class=\\"euiFlexItem euiFlexItem--flexGrowZero\\"><div class=\\"euiText\\"><span class=\\"euiTextColor euiTextColor--subdued\\"><span>Your license will expire on <strong>October 12, 2099 7:00 PM EST</strong></span></span></div></div></div><div class=\\"euiSpacer euiSpacer--l\\"></div></div>"`;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe not something to do in this PR, but could we figure out how to add some line breaks to this snapshot? It's hard to compare diffs when it's all on one line.

Copy link
Contributor

@jen-huang jen-huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, ran locally and didn't find anything astray

@elasticmachine
Copy link
Contributor

💔 Build Failed

@bmcconaghy bmcconaghy merged commit a6894c6 into elastic:master Jun 8, 2018
bmcconaghy added a commit to bmcconaghy/kibana that referenced this pull request Jun 8, 2018
* upping eui to 0.0.52 and updating snapshots

* fixing yarn.lock
bmcconaghy added a commit that referenced this pull request Jun 8, 2018
* upping eui to 0.0.52 and updating snapshots

* fixing yarn.lock
@bmcconaghy bmcconaghy deleted the upping_eui_to_52 branch June 8, 2018 19:41
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 8, 2018
cjcenizal added a commit that referenced this pull request Jun 8, 2018
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 8, 2018
cjcenizal added a commit that referenced this pull request Jun 8, 2018
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 8, 2018
@cjcenizal cjcenizal mentioned this pull request Jun 8, 2018
cjcenizal added a commit that referenced this pull request Jun 12, 2018
* Revert "Revert "upping eui to 0.0.52 and updating snapshots (#19761)" (#19770)"
This reverts commit c853072, reintroducing EUI 0.0.52.
* Rename visualize page object selectors for manipulating combo box.
cjcenizal added a commit to cjcenizal/kibana that referenced this pull request Jun 12, 2018
* Revert "Revert "upping eui to 0.0.52 and updating snapshots (elastic#19761)" (elastic#19770)"
This reverts commit c853072, reintroducing EUI 0.0.52.
* Rename visualize page object selectors for manipulating combo box.
cjcenizal added a commit that referenced this pull request Jun 12, 2018
* Revert "Revert "upping eui to 0.0.52 and updating snapshots (#19761)" (#19770)"
This reverts commit c853072, reintroducing EUI 0.0.52.
* Rename visualize page object selectors for manipulating combo box.
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
* upping eui to 0.0.52 and updating snapshots

* fixing yarn.lock
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
maryia-lapata pushed a commit to maryia-lapata/kibana that referenced this pull request Jun 25, 2018
* Revert "Revert "upping eui to 0.0.52 and updating snapshots (elastic#19761)" (elastic#19770)"
This reverts commit c853072, reintroducing EUI 0.0.52.
* Rename visualize page object selectors for manipulating combo box.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants