Skip to content

[Synthetics] Fixes broken e2e tests !!#197567

Merged
shahzad31 merged 2 commits intoelastic:mainfrom
shahzad31:fix-tests
Oct 24, 2024
Merged

[Synthetics] Fixes broken e2e tests !!#197567
shahzad31 merged 2 commits intoelastic:mainfrom
shahzad31:fix-tests

Conversation

@shahzad31
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 commented Oct 24, 2024

Summary

Fixes broken e2e tests !!

Rules API behavior somehow has changed , i still not sure what changed but now it will rely on UI !!

@shahzad31 shahzad31 requested a review from a team as a code owner October 24, 2024 07:23
@botelastic botelastic Bot added ci:project-deploy-observability Create an Observability project Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. labels Oct 24, 2024
@elasticmachine
Copy link
Copy Markdown
Contributor

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@github-actions
Copy link
Copy Markdown
Contributor

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@shahzad31 shahzad31 added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor labels Oct 24, 2024
@shahzad31 shahzad31 enabled auto-merge (squash) October 24, 2024 07:31
@shahzad31 shahzad31 merged commit b61a627 into elastic:main Oct 24, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11496208800

@shahzad31 shahzad31 deleted the fix-tests branch October 24, 2024 09:11
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 24, 2024
## Summary

Fixes broken e2e tests !!

Rules API behavior somehow has changed , i still not sure what changed
but now it will rely on UI !!

(cherry picked from commit b61a627)
@kibanamachine
Copy link
Copy Markdown
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 24, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Synthetics] Fixes broken e2e tests !!
(#197567)](#197567)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-24T09:10:51Z","message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management"],"title":"[Synthetics]
Fixes broken e2e tests
!!","number":197567,"url":"https://github.com/elastic/kibana/pull/197567","mergeCommit":{"message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197567","number":197567,"mergeCommit":{"message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848"}}]}] BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11591047627

@shahzad31 shahzad31 added the backport:version Backport to applied version labels label Oct 30, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

Starting backport for target branches: 8.15, 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11591055627

@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.16
8.x Cherrypick failed because the selected commit (b61a627) is empty. It looks like the commit was already backported in #197579

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 197567

Questions ?

Please refer to the Backport tool documentation

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 30, 2024
## Summary

Fixes broken e2e tests !!

Rules API behavior somehow has changed , i still not sure what changed
but now it will rely on UI !!

(cherry picked from commit b61a627)
@kibanamachine
Copy link
Copy Markdown
Contributor

💔 Some backports could not be created

Status Branch Result
8.15 Backport failed because of merge conflicts
8.16
8.x Cherrypick failed because the selected commit (b61a627) is empty. It looks like the commit was already backported in #197579

Note: Successful backport PRs will be merged automatically after passing CI.

Manual backport

To create the backport manually run:

node scripts/backport --pr 197567

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 30, 2024
# Backport

This will backport the following commits from `main` to `8.16`:
- [[Synthetics] Fixes broken e2e tests !!
(#197567)](#197567)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"Shahzad","email":"shahzad31comp@gmail.com"},"sourceCommit":{"committedDate":"2024-10-24T09:10:51Z","message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-major","ci:project-deploy-observability","Team:obs-ux-management","v8.16.0","v8.17.0"],"title":"[Synthetics]
Fixes broken e2e tests
!!","number":197567,"url":"https://github.com/elastic/kibana/pull/197567","mergeCommit":{"message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197567","number":197567,"mergeCommit":{"message":"[Synthetics]
Fixes broken e2e tests !! (#197567)\n\n## Summary\r\n\r\nFixes broken
e2e tests !!\r\n\r\nRules API behavior somehow has changed , i still not
sure what changed\r\nbut now it will rely on UI
!!","sha":"b61a627ef3a04617b2834e6c445666318a98d848"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/197579","number":197579,"state":"MERGED","mergeCommit":{"sha":"407d794861df930e364972e938edff46fe659d0b","message":"[8.x]
[Synthetics] Fixes broken e2e tests !! (#197567) (#197579)\n\n#
Backport\n\nThis will backport the following commits from `main` to
`8.x`:\n- [[Synthetics] Fixes broken e2e tests
!!\n(#197567)](https://github.com/elastic/kibana/pull/197567)\n\n<!---
Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the
[Backport
tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"Shahzad\",\"email\":\"shahzad31comp@gmail.com\"},\"sourceCommit\":{\"committedDate\":\"2024-10-24T09:10:51Z\",\"message\":\"[Synthetics]\nFixes
broken e2e tests !! (#197567)\\n\\n## Summary\\r\\n\\r\\nFixes
broken\ne2e tests !!\\r\\n\\r\\nRules API behavior somehow has changed ,
i still not\nsure what changed\\r\\nbut now it will rely on
UI\n!!\",\"sha\":\"b61a627ef3a04617b2834e6c445666318a98d848\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.17.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"backport:prev-minor\",\"ci:project-deploy-observability\",\"Team:obs-ux-management\"],\"title\":\"[Synthetics]\nFixes
broken e2e
tests\n!!\",\"number\":197567,\"url\":\"https://github.com/elastic/kibana/pull/197567\",\"mergeCommit\":{\"message\":\"[Synthetics]\nFixes
broken e2e tests !! (#197567)\\n\\n## Summary\\r\\n\\r\\nFixes
broken\ne2e tests !!\\r\\n\\r\\nRules API behavior somehow has changed ,
i still not\nsure what changed\\r\\nbut now it will rely on
UI\n!!\",\"sha\":\"b61a627ef3a04617b2834e6c445666318a98d848\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/197567\",\"number\":197567,\"mergeCommit\":{\"message\":\"[Synthetics]\nFixes
broken e2e tests !! (#197567)\\n\\n## Summary\\r\\n\\r\\nFixes
broken\ne2e tests !!\\r\\n\\r\\nRules API behavior somehow has changed ,
i still not\nsure what changed\\r\\nbut now it will rely on
UI\n!!\",\"sha\":\"b61a627ef3a04617b2834e6c445666318a98d848\"}}]}]
BACKPORT-->\n\nCo-authored-by: Shahzad <shahzad31comp@gmail.com>"}}]}]
BACKPORT-->

Co-authored-by: Shahzad <shahzad31comp@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

backport:version Backport to applied version labels ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants