Skip to content

[8.16] [SecuritySolution] Add tooltip to entities table (#197430) #197491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
machadoum merged 1 commit into from
Oct 24, 2024
Merged

[8.16] [SecuritySolution] Add tooltip to entities table (#197430) #197491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 14 additions & 12 deletions ...ugins/security_solution/public/entity_analytics/components/entity_store/entities_list.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,9 +6,8 @@
*/

import React, { useCallback, useEffect, useMemo, useState } from 'react';
import { EuiFilterGroup, EuiFlexGroup, EuiFlexItem, EuiTitle } from '@elastic/eui';
import { EuiFilterGroup, EuiFlexGroup, EuiFlexItem } from '@elastic/eui';
import { noop } from 'lodash/fp';
import { FormattedMessage } from '@kbn/i18n-react';
import { i18n } from '@kbn/i18n';
import { useErrorToast } from '../../../common/hooks/use_error_toast';
import type { CriticalityLevels } from '../../../../common/constants';
Expand Down Expand Up @@ -116,16 +115,19 @@ export const EntitiesList: React.FC = () => {
activePage={(data?.page ?? 1) - 1}
columns={columns}
headerCount={data?.total ?? 0}
headerTitle={
<EuiTitle size="s">
<h2>
<FormattedMessage
id="xpack.securitySolution.entityAnalytics.entityStore.entitiesList.tableTitle"
defaultMessage="Entities"
/>
</h2>
</EuiTitle>
}
titleSize="s"
headerTitle={i18n.translate(
'xpack.securitySolution.entityAnalytics.entityStore.entitiesList.tableTitle',
{
defaultMessage: 'Entities',
}
)}
headerTooltip={i18n.translate(
'xpack.securitySolution.entityAnalytics.entityStore.entitiesList.tableTooltip',
{
defaultMessage: 'Entity data can take a couple of minutes to appear',
}
)}
limit={limit}
loading={isLoading || isRefetching}
isInspect={false}
Expand Down
4 changes: 4 additions & 0 deletions x-pack/plugins/security_solution/public/explore/components/paginated_table/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,7 @@ import type {
EuiBasicTableProps,
EuiGlobalToastListToast as Toast,
EuiTableRowCellProps,
EuiTitleSize,
} from '@elastic/eui';
import {
EuiBasicTable,
Expand Down Expand Up @@ -107,6 +108,7 @@ export interface BasicTableProps<T> {
dataTestSubj?: string;
headerCount: number;
headerFilters?: string | React.ReactNode;
titleSize?: EuiTitleSize;
headerSupplement?: React.ReactElement;
headerTitle: string | React.ReactElement;
headerTooltip?: string;
Expand Down Expand Up @@ -148,6 +150,7 @@ const PaginatedTableComponent: FC<SiemTables> = ({
dataTestSubj = DEFAULT_DATA_TEST_SUBJ,
headerCount,
headerFilters,
titleSize,
headerSupplement,
headerTitle,
headerTooltip,
Expand Down Expand Up @@ -277,6 +280,7 @@ const PaginatedTableComponent: FC<SiemTables> = ({
<InspectButtonContainer show={!loadingInitial}>
<Panel data-test-subj={`${dataTestSubj}-loading-${loading}`} loading={loading}>
<HeaderSection
titleSize={titleSize}
toggleStatus={toggleStatus}
toggleQuery={toggleQuery}
headerFilters={headerFilters}
Expand Down