Skip to content

[ML] Memory usage: Functional tests #197415

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rbrtj merged 2 commits into from
Oct 25, 2024
Merged

[ML] Memory usage: Functional tests #197415

rbrtj merged 2 commits into from
Oct 25, 2024

Conversation

@rbrtj
Copy link
Contributor

@rbrtj rbrtj commented Oct 23, 2024 •
edited by kibanamachine
Loading

Summary

Functional tests for memory usage page in ML.

@rbrtj rbrtj added non-issue Indicates to automation that a pull request should not appear in the release notes :ml release_note:skip Skip the PR/issue when compiling release notes v9.0.0 Team:ML Team label for ML (also use :ml) t// v8.16.0 backport:version Backport to applied version labels v8.17.0 labels Oct 23, 2024
@rbrtj rbrtj self-assigned this Oct 23, 2024
@rbrtj rbrtj requested review from a team as code owners October 23, 2024 11:59
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024

Pinging @elastic/ml-ui (:ml)

@rbrtj rbrtj mentioned this pull request Oct 23, 2024
Closed
23 tasks
@peteharverson peteharverson mentioned this pull request Oct 23, 2024
Closed
8 tasks
jbudz
jbudz approved these changes Oct 23, 2024
View reviewed changes
Copy link
Member

@jbudz jbudz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.buildkite/ftr_platform_stateful_configs.yml

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 23, 2024

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ml 4.5MB 4.5MB +427.0B

cc @rbrtj

peteharverson
peteharverson reviewed Oct 24, 2024
View reviewed changes
x-pack/test/functional/apps/ml/memory_usage/memory_usage_page.ts
await ml.memoryUsage.selectTab('memory-usage');
await ml.memoryUsage.assertTreeChartExists();

await ml.memoryUsage.clearSelectedChartItems();
Copy link
Contributor

@peteharverson peteharverson Oct 24, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it worth adding a step where you leave just the Anomaly Detection Job item and assert the tree chart exists, before clearing all?

Copy link
Contributor Author

@rbrtj rbrtj Oct 24, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm, I'm not sure what you mean exactly.
This test is responsible for ensuring that the chart is displayed properly in the memory usage tab.
image
Then, it clears the combo box and checks if the chart displays an empty state.
The same thing was done earlier, but for a chart inside an expanded row of a particular node.

Copy link
Contributor

@peteharverson peteharverson Oct 25, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry. I was thinking we could do a click on the DFA and Trained model items above the chart to get it into this state, but probably not worth the effort as there is only 1 AD job in this case.

Screenshot 2024-10-25 at 10 07 55

@rbrtj rbrtj requested a review from peteharverson October 25, 2024 08:52
peteharverson
peteharverson approved these changes Oct 25, 2024
View reviewed changes
Copy link
Contributor

@peteharverson peteharverson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

jgowdyelastic
jgowdyelastic approved these changes Oct 25, 2024
View reviewed changes
Copy link
Member

@jgowdyelastic jgowdyelastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rbrtj rbrtj merged commit 479280c into elastic:main Oct 25, 2024
21 checks passed
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 25, 2024

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11517513172

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
@rbrtj
[ML] Memory usage: Functional tests (elastic#197415)
2357989 
## Summary

Functional tests for `memory usage` page in ML.

(cherry picked from commit 479280c)
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 25, 2024
@rbrtj
[ML] Memory usage: Functional tests (elastic#197415)
6a1a7f8 
## Summary

Functional tests for `memory usage` page in ML.

(cherry picked from commit 479280c)
@kibanamachine kibanamachine mentioned this pull request Oct 25, 2024
Merged
@kibanamachine
Copy link
Contributor

kibanamachine commented Oct 25, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.16
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 25, 2024
@kibanamachine @rbrtj
[8.x] [ML] Memory usage: Functional tests (#197415) (#197809)
46122fa 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ML] Memory usage: Functional tests
(#197415)](#197415)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T11:39:38Z","message":"[ML]
Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional
tests for `memory usage` page in
ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Memory usage: Functional
tests","number":197415,"url":"https://github.com/elastic/kibana/pull/197415","mergeCommit":{"message":"[ML]
Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional
tests for `memory usage` page in
ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197415","number":197415,"mergeCommit":{"message":"[ML]
Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional
tests for `memory usage` page in
ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
kibanamachine added a commit that referenced this pull request Oct 25, 2024
@kibanamachine @rbrtj
[8.16] [ML] Memory usage: Functional tests (#197415) (#197808)
af2cd0c 
# Backport

This will backport the following commits from `main` to `8.16`:
- [[ML] Memory usage: Functional tests
(#197415)](#197415)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Robert
Jaszczurek","email":"[email protected]"},"sourceCommit":{"committedDate":"2024-10-25T11:39:38Z","message":"[ML]
Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional
tests for `memory usage` page in
ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["non-issue",":ml","release_note:skip","v9.0.0","Team:ML","v8.16.0","backport:version","v8.17.0"],"title":"[ML]
Memory usage: Functional
tests","number":197415,"url":"https://github.com/elastic/kibana/pull/197415","mergeCommit":{"message":"[ML]
Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional
tests for `memory usage` page in
ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197415","number":197415,"mergeCommit":{"message":"[ML]
Memory usage: Functional tests (#197415)\n\n## Summary\r\n\r\nFunctional
tests for `memory usage` page in
ML.","sha":"479280c0b74747056634421c9b9e05f94a3c7e07"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Robert Jaszczurek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jbudz jbudz jbudz approved these changes

@peteharverson peteharverson peteharverson approved these changes

@jgowdyelastic jgowdyelastic jgowdyelastic approved these changes

Assignees

@rbrtj rbrtj

Labels

backport:version Backport to applied version labels :ml non-issue Indicates to automation that a pull request should not appear in the release notes release_note:skip Skip the PR/issue when compiling release notes Team:ML Team label for ML (also use :ml) t// v8.16.0 v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@rbrtj @elasticmachine @kibanamachine @jbudz @peteharverson @jgowdyelastic