Skip to content

[Search] [Playground] Bug get text field for semantic field #197345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yansavitski merged 5 commits into from
Oct 25, 2024
Merged

[Search] [Playground] Bug get text field for semantic field #197345

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
979806a
Get text field for semantic field
yansavitski Oct 22, 2024
939c006
Merge branch 'main' into fix-playground-retrieval
yansavitski Oct 23, 2024
fa1efca
Add test for semantic field
yansavitski Oct 23, 2024
2908645
Merge branch 'fix-playground-retrieval' of github.com:yansavitski/kib…
yansavitski Oct 23, 2024
ded160a
Update jest inline snapshot
yansavitski Oct 24, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 13 additions & 0 deletions x-pack/plugins/search_playground/server/utils/get_value_for_selected_field.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,4 +123,17 @@ describe('getValueForSelectedField', () => {
seeking consolation and, eventually, redemption through basic compassion"
`);
});

test('should return when path is semantic field', () => {
const hit = {
_index: 'sample-index',
_id: '8jSNY48B6iHEi98DL1C-',
_score: 0.7789394,
_source: {
test: { text: 'The Shawshank Redemption' },
},
};

expect(getValueForSelectedField(hit, 'test')).toEqual('The Shawshank Redemption');
});
});
6 changes: 4 additions & 2 deletions x-pack/plugins/search_playground/server/utils/get_value_for_selected_field.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@
*/

import { SearchHit } from '@elastic/elasticsearch/lib/api/types';
import { get } from 'lodash';
import { get, has } from 'lodash';

export const getValueForSelectedField = (hit: SearchHit, path: string): string => {
if (!hit) {
Expand All @@ -21,5 +21,7 @@ export const getValueForSelectedField = (hit: SearchHit, path: string): string =
.join('\n --- \n');
}

return get(hit._source, path, '');
return has(hit._source, `${path}.text`)
Copy link
Member

@joemcelroy joemcelroy Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we have FTR tests that demonstrate this issue is fixed?

Copy link
Contributor Author

@yansavitski yansavitski Oct 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’ve added a unit test. Adding an FTR test would require significant changes in ftr, like creating an index with a semantic field and relevant data. Considering the simplicity of the case, maybe unit test would be enough?

? get(hit._source, `${path}.text`, '')
: get(hit._source, path, '');
};