Skip to content

feat(slo): improve burn rate panel#197339

Merged
kdelemme merged 19 commits intoelastic:mainfrom
kdelemme:feat/burn-rate-panel-improvements
Nov 13, 2024
Merged

feat(slo): improve burn rate panel#197339
kdelemme merged 19 commits intoelastic:mainfrom
kdelemme:feat/burn-rate-panel-improvements

Conversation

@kdelemme
Copy link
Copy Markdown
Contributor

@kdelemme kdelemme commented Oct 22, 2024 •
edited by kibanamachine
Loading

Resolves #195139

🌸 Summary

The history details page was using the burn rate component but only to show the error rate chart named as "burn rate", which is incorrect. I've removed the usage of that component, and only used the ErrorRateChart on that page. I was able to refactor this component slightly to remove the need to provide a selectedTabId.

Then, I changed the burnRatePanel component to use both the short and long window burn rates in order to handle cases like recovering/increasing burn rate.

Testing

  • Run dataforge: node x-pack/scripts/data_forge.js --events-per-cycle 50 --lookback now-7d --dataset fake_stack --install-kibana-assets --kibana-url http://localhost:5601/kibana
  • Create a few SLOs with different objective (80% and 99.9%) for example
  • Check the burn rate panel is showing the correct status based on the burn rate values returned by the API
Screenshot
image
image
image
image

@kdelemme kdelemme force-pushed the feat/burn-rate-panel-improvements branch from d857b42 to 84c47d4 Compare October 22, 2024 20:14
@kdelemme kdelemme added release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. backport:prev-minor v8.17.0 labels Oct 22, 2024
@kdelemme kdelemme self-assigned this Oct 22, 2024
@kdelemme kdelemme marked this pull request as ready for review October 22, 2024 20:20
@kdelemme kdelemme requested a review from a team as a code owner October 22, 2024 20:20
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Oct 22, 2024

Pinging @elastic/obs-ux-management-team (Team:obs-ux-management)

@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 23, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 23, 2024

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@kdelemme
Copy link
Copy Markdown
Contributor Author

kdelemme commented Oct 29, 2024 •
edited
Loading

  • Add color background to the different window badges Eui does not support it
  • Change chart color: red when burn rate is breached, otherwise neutral blue color.
  • Use single line chart instead of Area chart (like in SLO alert details page)

@mgiota mgiota self-requested a review November 8, 2024 19:52
@elasticmachine
Copy link
Copy Markdown
Contributor

elasticmachine commented Nov 13, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
slo 855.1KB 854.4KB -735.0B

History

cc @kdelemme

shahzad31
shahzad31 approved these changes Nov 13, 2024
View reviewed changes
Copy link
Copy Markdown
Contributor

@shahzad31 shahzad31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Smoke testing and code review LGTM !!

@kdelemme kdelemme merged commit a5b266c into elastic:main Nov 13, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 13, 2024

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11822950694

@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 13, 2024

💔 All backports failed

Status Branch Result
❌ 8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- chore(slo): Migrate to server-route-repository (#198726)

Manual backport

To create the backport manually run:

node scripts/backport --pr 197339

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Nov 14, 2024
Merged
4 tasks
@kdelemme kdelemme mentioned this pull request Nov 14, 2024
Merged
@kdelemme
Copy link
Copy Markdown
Contributor Author

kdelemme commented Nov 14, 2024

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kdelemme added a commit to kdelemme/kibana that referenced this pull request Nov 14, 2024
@kdelemme
feat(slo): improve burn rate panel (elastic#197339)
abf2ac5 
(cherry picked from commit a5b266c)
@kibanamachine kibanamachine added the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 14, 2024
@kibanamachine
Copy link
Copy Markdown
Contributor

kibanamachine commented Nov 14, 2024

Looks like this PR has a backport PR but it still hasn't been merged. Please merge it ASAP to keep the branches relatively in sync.

kdelemme added a commit that referenced this pull request Nov 14, 2024
@kdelemme
[8.x] feat(slo): improve burn rate panel (#197339) (#200229)
971b74e 
# Backport

This will backport the following commits from `main` to `8.x`:
- [feat(slo): improve burn rate panel
(#197339)](#197339)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Kevin
Delemme","email":"kevin.delemme@elastic.co"},"sourceCommit":{"committedDate":"2024-11-13T17:52:19Z","message":"feat(slo):
improve burn rate panel
(#197339)","sha":"a5b266c45b7db8821281a2325d919b6fdf679618","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-management","v8.17.0"],"number":197339,"url":"https://github.com/elastic/kibana/pull/197339","mergeCommit":{"message":"feat(slo):
improve burn rate panel
(#197339)","sha":"a5b266c45b7db8821281a2325d919b6fdf679618"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197339","number":197339,"mergeCommit":{"message":"feat(slo):
improve burn rate panel
(#197339)","sha":"a5b266c45b7db8821281a2325d919b6fdf679618"}},{"branch":"8.x","label":"v8.17.0","labelRegex":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->
@kibanamachine kibanamachine removed the backport missing Added to PRs automatically when the are determined to be missing a backport. label Nov 14, 2024
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@kdelemme @CAWilson94
feat(slo): improve burn rate panel (elastic#197339)
582699c
CAWilson94 pushed a commit to CAWilson94/kibana that referenced this pull request Nov 18, 2024
@kdelemme @CAWilson94
feat(slo): improve burn rate panel (elastic#197339)
a12a2a3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@shahzad31 shahzad31 shahzad31 approved these changes

@mgiota mgiota Awaiting requested review from mgiota

Assignees

@kdelemme kdelemme

Labels

ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:actionable-obs Formerly "obs-ux-management", responsible for SLO, o11y alerting, significant events, & synthetics. v8.17.0 v9.0.0

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[SLO] Burn rate panel improvement

4 participants

@kdelemme @elasticmachine @kibanamachine @shahzad31