[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section#197312
Merged
PhilippeOberti merged 3 commits intoelastic:mainfrom Oct 22, 2024
Conversation
PhilippeOberti
added
backport
Contributor
|
Pinging @elastic/security-threat-hunting-investigations (Team:Threat Hunting:Investigations) |
PhilippeOberti
force-pushed
the
notes_copy_changes
branch
from
6e2e28e to
3ed4b67
Compare
tomsonpl
approved these changes
Oct 22, 2024
Contributor
tomsonpl
left a comment
tomsonpl
left a comment
There was a problem hiding this comment.
Defend Workflows code changes LGTM 👍
christineweng
approved these changes
Oct 22, 2024
…e the unassociated note advanced setting under the Security Solution section
PhilippeOberti
force-pushed
the
notes_copy_changes
branch
from
3ed4b67 to
aeda8ac
Compare
nastasha-solomon
approved these changes
Oct 22, 2024
Member
nastasha-solomon
left a comment
nastasha-solomon
left a comment
There was a problem hiding this comment.
Left a few super minor edits. Otherwise, lgtm and thanks for making these changes!
Contributor
|
Starting backport for target branches: 8.16, 8.x https://github.com/elastic/kibana/actions/runs/11470056448 |
Contributor
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Async chunks
History
|
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
…e the unassociated note advanced setting under the Security Solution section (elastic#197312) ## Summary This PR tackles 2 small tasks: - move the unassociated advanced settings introduced in [this PR](elastic#194947) under the `Security Solution` category instead of `General` - make some copy changes on the notes functionality, mainly the following ([copy changes document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84)) - make sure we don't use a capital `N` for the word `note` - make sure that we use a capital `T` for the word `timeline` - change some of the no message and callout texts - prioritize using `attach` instead of `associate` All changes have been done with @nastasha-solomon. elastic#193495 (cherry picked from commit 800e392)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 22, 2024
…e the unassociated note advanced setting under the Security Solution section (elastic#197312) ## Summary This PR tackles 2 small tasks: - move the unassociated advanced settings introduced in [this PR](elastic#194947) under the `Security Solution` category instead of `General` - make some copy changes on the notes functionality, mainly the following ([copy changes document](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84)) - make sure we don't use a capital `N` for the word `note` - make sure that we use a capital `T` for the word `timeline` - change some of the no message and callout texts - prioritize using `attach` instead of `associate` All changes have been done with @nastasha-solomon. elastic#193495 (cherry picked from commit 800e392)
Contributor
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
…e + move the unassociated note advanced setting under the Security Solution section (#197312) (#197350) # Backport This will backport the following commits from `main` to `8.16`: - [[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)](#197312) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-22T23:20:10Z","message":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move the unassociated advanced settings introduced in [this\r\nPR](#194947) under the `Security\r\nSolution` category instead of `General`\r\n- make some copy changes on the notes functionality, mainly the\r\nfollowing ([copy changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n - make sure we don't use a capital `N` for the word `note`\r\n - make sure that we use a capital `T` for the word `timeline`\r\n - change some of the no message and callout texts\r\n - prioritize using `attach` instead of `associate`\r\n\r\nAll changes have been done with @nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section","number":197312,"url":"https://github.com/elastic/kibana/pull/197312","mergeCommit":{"message":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move the unassociated advanced settings introduced in [this\r\nPR](#194947) under the `Security\r\nSolution` category instead of `General`\r\n- make some copy changes on the notes functionality, mainly the\r\nfollowing ([copy changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n - make sure we don't use a capital `N` for the word `note`\r\n - make sure that we use a capital `T` for the word `timeline`\r\n - change some of the no message and callout texts\r\n - prioritize using `attach` instead of `associate`\r\n\r\nAll changes have been done with @nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197312","number":197312,"mergeCommit":{"message":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move the unassociated advanced settings introduced in [this\r\nPR](#194947) under the `Security\r\nSolution` category instead of `General`\r\n- make some copy changes on the notes functionality, mainly the\r\nfollowing ([copy changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n - make sure we don't use a capital `N` for the word `note`\r\n - make sure that we use a capital `T` for the word `timeline`\r\n - change some of the no message and callout texts\r\n - prioritize using `attach` instead of `associate`\r\n\r\nAll changes have been done with @nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
kibanamachine
added a commit
that referenced
this pull request
Oct 23, 2024
… + move the unassociated note advanced setting under the Security Solution section (#197312) (#197351) # Backport This will backport the following commits from `main` to `8.x`: - [[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)](#197312) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Philippe Oberti","email":"philippe.oberti@elastic.co"},"sourceCommit":{"committedDate":"2024-10-22T23:20:10Z","message":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move the unassociated advanced settings introduced in [this\r\nPR](#194947) under the `Security\r\nSolution` category instead of `General`\r\n- make some copy changes on the notes functionality, mainly the\r\nfollowing ([copy changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n - make sure we don't use a capital `N` for the word `note`\r\n - make sure that we use a capital `T` for the word `timeline`\r\n - change some of the no message and callout texts\r\n - prioritize using `attach` instead of `associate`\r\n\r\nAll changes have been done with @nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["backport","release_note:skip","v9.0.0","Team:Threat Hunting:Investigations","v8.16.0"],"title":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section","number":197312,"url":"https://github.com/elastic/kibana/pull/197312","mergeCommit":{"message":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move the unassociated advanced settings introduced in [this\r\nPR](#194947) under the `Security\r\nSolution` category instead of `General`\r\n- make some copy changes on the notes functionality, mainly the\r\nfollowing ([copy changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n - make sure we don't use a capital `N` for the word `note`\r\n - make sure that we use a capital `T` for the word `timeline`\r\n - change some of the no message and callout texts\r\n - prioritize using `attach` instead of `associate`\r\n\r\nAll changes have been done with @nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/197312","number":197312,"mergeCommit":{"message":"[Security Solution][Notes] - copy changes for note and timeline + move the unassociated note advanced setting under the Security Solution section (#197312)\n\n## Summary\r\n\r\nThis PR tackles 2 small tasks:\r\n- move the unassociated advanced settings introduced in [this\r\nPR](#194947) under the `Security\r\nSolution` category instead of `General`\r\n- make some copy changes on the notes functionality, mainly the\r\nfollowing ([copy changes\r\ndocument](https://docs.google.com/document/d/10blyxRfkMIR8gk4cw6nFzajA-L63iUzQaxQXHauL8LM/edit#heading=h.mlyibn1i5q84))\r\n - make sure we don't use a capital `N` for the word `note`\r\n - make sure that we use a capital `T` for the word `timeline`\r\n - change some of the no message and callout texts\r\n - prioritize using `attach` instead of `associate`\r\n\r\nAll changes have been done with @nastasha-solomon.\r\n\r\nhttps://github.com//issues/193495","sha":"800e39224eed1335519d00e62e423af241495be9"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Philippe Oberti <philippe.oberti@elastic.co>
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR tackles 2 small tasks:
Security Solutioncategory instead ofGeneralNfor the wordnoteTfor the wordtimelineattachinstead ofassociateAll changes have been done with @nastasha-solomon.
#193495
Checklist