set timeout for timelion search requests #19711
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nreese
added
Feature:Timelion
Contributor
💔 Build Failed |
Contributor
💔 Build Failed |
timroes
reviewed
Jun 7, 2018
| }) | ||
| } | ||
| }, | ||
| config: function () { |
Contributor
There was a problem hiding this comment.
Minor nitpick: arrow functions instead of old syntax.
timroes
approved these changes
Jun 7, 2018
Contributor
timroes
left a comment
timroes
left a comment
There was a problem hiding this comment.
Code looks good to me, tests need fixing, minor nitpick about code style.
Checked that parameters match requires ES params, but didn't try it out (since I am not aware, if we have an easy way to simulate ES delays).
ppisljar
approved these changes
Jun 7, 2018
Contributor
💚 Build Succeeded |
nreese
added a commit
to nreese/kibana
that referenced
this pull request
Jun 12, 2018
* set timeout for timelion search requests * stub out server.config for mocha testing * test timeout set * arrow functions
nreese
added a commit
that referenced
this pull request
Jun 14, 2018
maryia-lapata
pushed a commit
to maryia-lapata/kibana
that referenced
this pull request
Jun 25, 2018
* set timeout for timelion search requests * stub out server.config for mocha testing * test timeout set * arrow functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #17575
Set
timeoutforsearchrequests made by timelion. Timeout set to value ofelasticsearch.shardTimeoutconfiguration