[Discover] [Unified Data Table] Support the field stats popover in data grid column headers#196863
Draft
jughosta wants to merge 19 commits intoelastic:mainfrom
Draft
[Discover] [Unified Data Table] Support the field stats popover in data grid column headers#196863jughosta wants to merge 19 commits intoelastic:mainfrom
jughosta wants to merge 19 commits intoelastic:mainfrom
Conversation
jughosta
added
release_note:enhancement
Team:DataDiscovery
Contributor
|
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
jughosta
commented
Oct 18, 2024
Comment on lines
+359
to
+364
| <ButtonComponent | ||
| {...otherProps} | ||
| isPopoverOpen={infoIsOpen} | ||
| onTogglePopover={togglePopover} | ||
| onClosePopover={closePopover} | ||
| /> |
Contributor
Author
There was a problem hiding this comment.
Made the button to trigger the popover customizable.
jughosta
commented
Oct 22, 2024
| maxAllowedSampleSize={getMaxAllowedSampleSize(discoverServices.uiSettings)} | ||
| query={savedSearch.searchSource.getField('query')} | ||
| query={query} | ||
| filters={filters} |
Contributor
Author
There was a problem hiding this comment.
Updating it rather via another PR #197190
Contributor
⏳ Build in-progress, with failures
Failed CI Steps
Test Failures
History
cc @jughosta |
…-stats # Conflicts: # src/plugins/discover/public/embeddable/components/saved_search_grid.tsx # src/plugins/discover/public/embeddable/components/search_embeddable_grid_component.tsx
…-stats # Conflicts: # packages/kbn-unified-data-table/src/components/data_table.tsx # packages/kbn-unified-field-list/src/containers/unified_field_list_item/field_list_item.tsx
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Summarize your PR. If it involves visual changes include a screenshot or gif.
Checklist
Delete any items that are not applicable to this PR.
Risk Matrix
Delete this section if it is not applicable to this PR.
Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.
When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:
For maintainers